From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A27C0015E for ; Wed, 5 Jul 2023 20:50:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EEBC8D0002; Wed, 5 Jul 2023 16:50:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09FA78D0001; Wed, 5 Jul 2023 16:50:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E81618D0002; Wed, 5 Jul 2023 16:50:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D4A4A8D0001 for ; Wed, 5 Jul 2023 16:50:56 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A170C1402CB for ; Wed, 5 Jul 2023 20:50:56 +0000 (UTC) X-FDA: 80978752512.18.CDD68E8 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf02.hostedemail.com (Postfix) with ESMTP id 958FD80013 for ; Wed, 5 Jul 2023 20:50:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=1gi2QGer; dmarc=none; spf=pass (imf02.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688590254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ATlsphHrvoXPAVcgiiWqGZL+5stGcmqJb7QaGx/TZTY=; b=lp+1WGGzJd9ATzSt+57SdQfpC4Y7wVT3XH0z9gKBRV5Gk/T3EN4uKkouJSPgx02W0BHO2W 571U230+9lBg9v51JUJG/8WmdUc+P2sXccpBCC4HmlfBIC1PzpzBIniFbuwp99RyGS17pW Ol41hjpcU25BOScmub0awFrEWRu6ODE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=1gi2QGer; dmarc=none; spf=pass (imf02.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688590254; a=rsa-sha256; cv=none; b=Y3nthYSlhFz63rnepJDaU7hpT3DAMrE4QGo6slhvdXu4GpwoiZ1abTsWTdqImj93JQ5h/8 UO/OEcFBCxjtBsSAKzsjxXicGPKLu5XQljx05H5mC1uFvINQQZ+ypUAuZ3qGx0j1bcQ21U QbC/d7OXFJJneaDPBvkXDOFWKy3PkO0= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6687096c6ddso83166b3a.0 for ; Wed, 05 Jul 2023 13:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1688590253; x=1691182253; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ATlsphHrvoXPAVcgiiWqGZL+5stGcmqJb7QaGx/TZTY=; b=1gi2QGerArOZcqyu8Kq4cOvg8zuziVGn35t26P9TQDCgI7LVvQLzLR3SrXe22/KhrP EWezBRP2oL8ktfFwpeG6WuO8igLI6lzBPblZInvrfFpCSRobEpSTk/d4Xq9GBPodT+na OlomtymSR32nWGj6shvUrMDfzZYE0meRpSdSqnIuO0y1stYLvYXMTie9SmmuSDf9D3mv 9wRXi4e8TLS/O6UsyvZxO2WXY0zMb1PNSWyDCYNITe4fmiUf+JNTkBouSyHbVz2fsJ8u uPMCZVC8CkWRJ1YMiYIWuiUS7snbABrDkY3drTcOV27FokdQQ2hn6KQObjTeAROmHgAB SEVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688590253; x=1691182253; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ATlsphHrvoXPAVcgiiWqGZL+5stGcmqJb7QaGx/TZTY=; b=I07SCW1hkbFgy2dJ9kooMkwq27Mmyj2nqsjK0mBJ+9QIwdRRsQJGbmpavtNt1PRtva Pxbvy5/qXrYmoRTeXzTA1DoGG74Nt/YemYiI1Ht5foYhkOtbxpCF/+POr+tgV7/zgkJi iVVX+VYP3yA5zP++mEFwhZdRFPXEL5TNp4C9Dgl8oBEgsTuzCuGWJYiWirtoFmiNs1hI E8P2mmLj+WLvW4vfACJaUUEdaHVpJlpCRZpZdjS+J0sOPYf850M4MH0xW7NCf9S5Lfsj WT6HZOzMiRavdoocdbGrtU3BC0bCIH3zi3PW70bom0XpPGLmgHkXJ8f5OdwhGKiRKoX9 eIqQ== X-Gm-Message-State: ABy/qLYOx2Ug7H+CyK6Jd23VqRgY35TpwEjTGDPxQ5FldTn5LpL+UzJY QVINI+zWxljmX6JywSwXO9OsA06qGEYLVf4ociY= X-Google-Smtp-Source: APBJJlF93hFsbARecEfbdb3KDh0+O1N9izJjSFDbX+WwN+rT8t09OpkxZrl422GOlOmeM8zpscifTw== X-Received: by 2002:a05:6a00:15c6:b0:679:bc89:e45 with SMTP id o6-20020a056a0015c600b00679bc890e45mr18660pfu.6.1688590253188; Wed, 05 Jul 2023 13:50:53 -0700 (PDT) Received: from ghost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id n20-20020a62e514000000b00682b3d14005sm1752015pff.87.2023.07.05.13.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 13:50:52 -0700 (PDT) Date: Wed, 5 Jul 2023 13:50:50 -0700 From: Charlie Jenkins To: Conor Dooley Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, paul.walmsley@sifive.com, palmer@rivosinc.com, aou@eecs.berkeley.edu, anup@brainfault.org, konstantin@linuxfoundation.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, mick@ics.forth.gr, jrtc27@jrtc27.com Subject: Re: [RESEND PATCH v3 0/2] RISC-V: mm: Make SV48 the default address space Message-ID: References: <20230705190002.384799-1-charlie@rivosinc.com> <20230705-gloater-relation-29a6080ec87d@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705-gloater-relation-29a6080ec87d@spud> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 958FD80013 X-Stat-Signature: yotg65qegfmog86zwsj681rjc713pewc X-Rspam-User: X-HE-Tag: 1688590254-595685 X-HE-Meta: U2FsdGVkX1/77oJ6WlNEKQ8b1K1SAdyd+tYKcmm/q6iSlbam35RNh6EMP5wK9B6sjBS6Ht7t/9cEPDV9Ss7aQ+hSZx/eNFhh49ZzXtHdqJuxcktuncpe8tqJyc2PyJQhgL5tSiwVrGnBT0ZjLCZ328dW5858gNROV67Ap2uUn90ZNs88/TVCvbYN4NPLZ5bhKMrwqE5XLSK+vN9AmIOLJ1btSrdKeWxbcwClhw0AoT07MOUgRk54v6Z/60O/Q/0cHPr0KCAFieNJiTQxckDsAA7i5b7kMQGvC9LvfEIuUQ1nrxifvZWvQpf012T4k69eYXwW8mpw4xYq8lG06rxt29zLzYrwOMSmeOtZdIjOdD+BOQzKSWXXPok94eHUAe8wHbWEShaq+Q/ZQWZr0WMoCtYu7GEw5K51y/sJ+x4ygbifTHDZjtZKQotkRhrYtvVJcdWo7Lqfwj21aVcx190Wx9YhyZFZJM2TUt6xpfE0/+YQYLmlpLNK3KN0dLKRF7rbXRFhJUr65h7WEiFk7hr9tCokhWS4JEyGihc7XpcYvazAi6LKQfRF15D2fx4hSEbkJHZCrb/0DxueJg+EgZ5rYC47gzvyc1Rw93C0BMEKx8SoS3Si8FKi0AQ06SOJHeOv6978VQb13B5Dq+YgekbHKwElP6WTmhdf7UAyldjTmc4xVMkGTNi+AQx0XN90W4e51fuoNpUMI/1UyIKdb+T4zjYlVC0dU2dDAyWlKzWwkxjlc4MyaMhWq0ZcxWkT6sfHCibBYX0DuiNc8SMeSgCchL6WlnAVCuOdb0jvhqjW5++ZHfW38ZzVZXlL2XDj7mQnu19eTO8WnhIIB1GVpXeIKBT7A/JOmGKq7pxin7VJs4s/T4Bqij/0jP0NSEEZPeGLNIKFKhYjP0/VC61QjNtt35wUurBCQyk24Lg3Ekzj7Cy8ItESWfdC2P/tYByXKDyEbB2EgyBhoJahlIKWm4B gP2CUzsw N6NqzOqrA8ooQBNtwVIDD3iTptwy9rLM7J6OOoozFp/itu3W1CK1Fy7XAK7f7g3SpJa0zZUnbiIaI1N/KZ8e8KV4e2ms9YZDtZXjQvnqu8S/8uEm3pSt1HTtyZzbqaG8HIc0MiRBvQMYevbN+lLbjz0vHukDgwUwVsMY+z4Zuvz0tOtgBeK0D5a42Bv2LQapXScfdhERs5unmYcImPNeOJ/56yF3jMo3rLMCwt9LtLBID9QQ92TI3u2tMhsNyktTtuhhi998wHlI9Sdlnf+5JHViVl7koy7Rs3DffrMLH7Wy6nCvi68CGeVs55A8FnDCIoJ1hlly/c8lx9o0BMon2D+mdXrtMMUPh0VvPkUM92tCU83YE2epFv96T6qKkUyqTgscFH+FtSNEr7owCwIluq17yiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 05, 2023 at 09:00:18PM +0100, Conor Dooley wrote: > Hey Charlie, > > On Wed, Jul 05, 2023 at 11:59:40AM -0700, Charlie Jenkins wrote: > > Make sv48 the default address space for mmap as some applications > > currently depend on this assumption. Also enable users to select > > desired address space using a non-zero hint address to mmap. Previous > > kernel changes caused Java and other applications to be broken on sv57 > > which this patch fixes. > > > > Documentation is also added to the RISC-V virtual memory section to explain > > these changes. > > I can't find a changelog in any of these patches, nor an explanation for > why this is v3 (or a RESEND). All I can find on the list is a v1. Could > you explain and provide a changelog please? > > Cheers, > Conor. I made a series of mistakes due to an incorrect email configuration. I knew something was wrong but I didn't know what after I sent out v2. v2 bumped the default address space from sv39 to sv48. The purpose of v3 was to remove an erroneous .gitignore I had included in v2 and also modify a testcase that was supposed to check the default was sv48 but it was still checking for sv39. After sending out v3 I realized what was wrong with my configuration, so I decided to mark it as a resend because I believe some people did recieve the previous emails. This is the only patch that made it through to everybody, and includes a default address space of sv48 instead of sv39. I have tested that OpenJDK 19 works on sv39, sv48, and sv57 in QEMU on this patch. OpenJDK 19 failed to work on kernel v6.4 on sv57 but worked on sv39 and sv48. Applications like Java and Go failing on sv57 were the motivation of this patch. Setting a default of sv48 will allow applications that don't explicitly support sv57 to work on sv57 hardware but still allow applications to take advantage of sv57 by specifying a hint address to mmap that is greater than or equal to 1<<56. - Charlie