From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01ACBEB64DA for ; Wed, 5 Jul 2023 20:25:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7876E8D0002; Wed, 5 Jul 2023 16:25:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 737288D0001; Wed, 5 Jul 2023 16:25:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D7448D0002; Wed, 5 Jul 2023 16:25:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4DABA8D0001 for ; Wed, 5 Jul 2023 16:25:30 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1B005140400 for ; Wed, 5 Jul 2023 20:25:30 +0000 (UTC) X-FDA: 80978688420.09.EDE3F67 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id DC2EF18000E for ; Wed, 5 Jul 2023 20:25:26 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LOITyjV4; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688588726; a=rsa-sha256; cv=none; b=kr79TksEri8oUDFkTJoEgBSX2vLBuLcxCOJ5AostwTJHeb1soXKEOz+UC2xjiIwNtcoa82 cXoTpNCFDUvE6KtG31ODrgZeTe1xJdepSs8GDB/JN2PGHCYjHrq0j66snVwg9YCdWdT5b8 DUkLJKaNrdY2lCxRB2YWjwA2thUGQCQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LOITyjV4; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688588726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ASCe+ZaB9FC1F5583V60PJYWRONCOSusHLyER7UBBI0=; b=4kY4OQ/YAzsAMkvqPUhjT+A6zDF3+Jaxpb6ZianugXykdOOsqnnGin1e5EjiIVCOBNFQpD taYTTLB3fj3WRzonQmdDNIifyNfUdfQxBrI++zlJPN+YYZe6kuzcIyl78KjpE8xD/9oo0k Pg31SAIi+VPn6iC1WVeN8lpOAlCP5LI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688588726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ASCe+ZaB9FC1F5583V60PJYWRONCOSusHLyER7UBBI0=; b=LOITyjV431AgR8sKdea9s0kwSf/08oavUwCQrcWgTyIr5hATXbxuxs2NiRkHD7NUl6QxgV O+89kaX/GjxtP0i/ESHmpy49a47CSjfh+NTrSq8bT8ECdXcanyA3yXGF2mqSzPEuEpq1la I0ldc4hVysQkY9yapzWsLSbeVVC+NG8= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-4MnDsw7hOzeKNPI0XQY8dA-1; Wed, 05 Jul 2023 16:25:25 -0400 X-MC-Unique: 4MnDsw7hOzeKNPI0XQY8dA-1 Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-3a1ed0e9b5dso21075b6e.0 for ; Wed, 05 Jul 2023 13:25:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688588724; x=1689193524; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ASCe+ZaB9FC1F5583V60PJYWRONCOSusHLyER7UBBI0=; b=b4jQWzKXOIZatRmvRi55NkJ2Kw7kCoUX5Yiye/2MxxOY/IZSm3IToEq8LqYPaeWBkA bXF7wdw4Kz6qR8emvFQEjboTmc220rZXJ1I/+kLHXduvxPQcbhFwLFItn9dyuA5hCtgS gmcKw+rp/WlZOH7OSxVMEplL4Us/AvZnNzgsdh4azYG/VWjwdjl0Ry8SJxDQwc9t7xir IOT/BVmOKDsGntXMd/Q76KoLosYefX71PC/KYpJXsJBgPXx7Z9TJ1Fxm1trB7VS9DLAo 28vHc6QLTTPEK0w7I/bKcZ/ZPmyFT07Mk/ZOLads1CARf28xDk3t8vJnzKDGeD4oL7fv 4T0A== X-Gm-Message-State: AC+VfDwuMBcaRTe3kA4j9pwWUiHMUSKL1M4rD8zTmV+TyEFYP9YWyFrz JZ46g7vrpVrpG0aaSetqNBAaxAb68Bo0LZY4sAJ7Dl773Jk7qE/56rj96tg12IxrpcMCc4KX5n/ VrfKcpU/IhNM= X-Received: by 2002:aca:f255:0:b0:3a0:50bb:79cd with SMTP id q82-20020acaf255000000b003a050bb79cdmr10091342oih.0.1688588724347; Wed, 05 Jul 2023 13:25:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7TeQjUMpes7R98hs70EQVxuwQH2R5xfd6xizcjOqRXdqx/KtKHmiXxiORnx30bvNz+aFCQjg== X-Received: by 2002:aca:f255:0:b0:3a0:50bb:79cd with SMTP id q82-20020acaf255000000b003a050bb79cdmr10091318oih.0.1688588724031; Wed, 05 Jul 2023 13:25:24 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id l11-20020a0cc20b000000b00632266b569esm14014585qvh.87.2023.07.05.13.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 13:25:23 -0700 (PDT) Date: Wed, 5 Jul 2023 16:25:21 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: David Hildenbrand , akpm@linux-foundation.org, jirislaby@kernel.org, jacobly.alt@gmail.com, holger@applied-asynchrony.com, hdegoede@redhat.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 2/2] mm: disable CONFIG_PER_VMA_LOCK until its fixed Message-ID: References: <20230705171213.2843068-1-surenb@google.com> <20230705171213.2843068-3-surenb@google.com> <3cdaa7d4-1293-3806-05ce-6b7fc4382458@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DC2EF18000E X-Stat-Signature: j1wind8ro3uyk7h6ikpz3maukgd1nipa X-HE-Tag: 1688588726-143553 X-HE-Meta: U2FsdGVkX19ps0wj2kpHSFVA/Jw6LsiugU1nsAfB6jD9S+j1/ItRZiykyxafW/dDGJcHkJbgqeIVdQR6wuZRPQq8gVK6lFrr0GDIDkYhqv6CCc4dCmzOXCDmbdQqFAsOd91O+qrIdSHEkTn5QYTChWC50WKHQNiLQiTigevs80wspmzHhm35fHHHq6bCZbZduxE+63MClOyNbQfWV9rgF4djMma72m6YhKVwqQt5A2QizXB8niBqxHRdr5eAxv9q/0U2/+AXTkaIbHMHZEgDmBi8iGrkZj+Fd91ppC8u1q7Ms6LCEUYvs1Kaa7w2gpSd1U1bFyhQ/6V+qXBGlo3xaldwUN+LD5VaC9C1DSdB5MDpyF/VRPOOZ0wnhxNPSYQ/G7HpwviYwuMI5Cg1Hnm2fm+egMa0d1jh7ZPE4cv+Br0uAL7Lj/lNig6Tx+Jr/XGa2RxaRXsOKZR41RqjtvNuVArBqrJVR4T7mqUGIsDvaDvtObgIiFZavEiQN7iN3FemLvjwmmFecmvoAxFlrXAaX+QTsnPEFpGC3DMfoAGcrqtp7/bLI6QwOe6kev5Im0JMYr2HPKelRgM9vQy1FffQoQoOTQbGsxNhh4LUEQiKJ7SWRFj2mhmefRMXvYCJ3sBaYzvO4m5cPLDL8qXd9F2Xqx7fbWl0XZ9CpiATUts/YdcSsUmhZGAYhJeedRZLdmGE1suvMejBKhxyB2jP+mFnA6qlBHnK9a6gxUEpl7inhuSFFiIvJ2nrNfJiz8GY+t5jzmnPTYwkrTU55lDuCPr0Wm0nK+gtFqa+CntosUYj2CRg9omiTWQWZPXG5/pKui2rlrhUQ0eSpD4n6AQzm5h7qctXtYu8wPUJtLAJNQvkmIUQUkmxHy8czG5bF0g17efdqj+9I14IXTNK3/XFnWH2AyB9kyLmmc0KUNHPJ7usQBQDG/lWWfuG/uZk60md9lXKN6a5GQOvq+UQcCdTTvg jb1+bMyv 9V0I1CGl5s2gKQvx7aTRNnE8yrEVk2GWru9faJa0ig0mlEyX1NNeWoVVIcWmhWCG3COFMfy+bWkXAlyKd5JSGunjzvjzL/Z6al6IIeYyDPTV1UAX+i8ojTVsO6wnX56XYVPrER+PfsI1RtSd7vdPZvMGM+ewjKY/C7i1T9CuRPY+9fAFm3TUJkODc/YGqBGu9S7BqLGBXvbjGWkYCvojAzh5RBWUmborsqby83GJBShlX4btpVYf6OEn/5kivVNEUzKr0I+3bo5mdaDIuq9RwclrlM6cOhcVmFC5rEJRYKbmQaI2R76AKiCq/RwLZUMCo7iNzchsgjiSaFDCf5DtiwuqpkemxVEMqKR5pMkfsgy0U/CKi/AvtmViEK7iOhvZUmDiNZGFewU/1UYDfqfPly//31BBjpZ5AjB4109H9b/Rc7imrR2ChSdJXOQa4YsCnMH2aM3GRZXMYH7fEa8fsn8B9LW/TBq91CyGXU23li52dVujXnDMoLcUFjijAw7aNr39ri/wwxwvOjYVq7LmpD4QBl79sP695b13LWX+8O84rVMmg0p0Yqw9NWVY85I8z4/Dz/r6yvvACvC6pR/FiXgFNifThGgPLD3gLP8doGbUzjBY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 05, 2023 at 10:22:27AM -0700, Suren Baghdasaryan wrote: > On Wed, Jul 5, 2023 at 10:16 AM David Hildenbrand wrote: > > > > On 05.07.23 19:12, Suren Baghdasaryan wrote: > > > A memory corruption was reported in [1] with bisection pointing to the > > > patch [2] enabling per-VMA locks for x86. > > > Disable per-VMA locks config to prevent this issue while the problem is > > > being investigated. This is expected to be a temporary measure. > > > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=217624 > > > [2] https://lore.kernel.org/all/20230227173632.3292573-30-surenb@google.com > > > > > > Reported-by: Jiri Slaby > > > Closes: https://lore.kernel.org/all/dbdef34c-3a07-5951-e1ae-e9c6e3cdf51b@kernel.org/ > > > Reported-by: Jacob Young > > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217624 > > > Fixes: 0bff0aaea03e ("x86/mm: try VMA lock-based page fault handling first") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Suren Baghdasaryan > > > --- > > > mm/Kconfig | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/mm/Kconfig b/mm/Kconfig > > > index 09130434e30d..0abc6c71dd89 100644 > > > --- a/mm/Kconfig > > > +++ b/mm/Kconfig > > > @@ -1224,8 +1224,9 @@ config ARCH_SUPPORTS_PER_VMA_LOCK > > > def_bool n > > > > > > config PER_VMA_LOCK > > > - def_bool y > > > + bool "Enable per-vma locking during page fault handling." > > > depends on ARCH_SUPPORTS_PER_VMA_LOCK && MMU && SMP > > > + depends on BROKEN > > > help > > > Allow per-vma locking during page fault handling. > > > > > Do we have any testing results (that don't reveal other issues :) ) for > > patch #1? Not sure if we really want to mark it broken if patch #1 fixes > > the issue. > > I tested the fix using the only reproducer provided in the reports > plus kernel compilation and my fork stress test. All looked good and > stable but I don't know if other reports had the same issue or > something different. The commit log seems slightly confusing. It mostly says the bug was still not solved, but I assume patch 1 is the current "fix", it's just not clear whether there's any other potential issues? According to the stable tree rules: - It must fix a problem that causes a build error (but not for things marked CONFIG_BROKEN), an oops, a hang, data corruption, a real security issue, or some "oh, that's not good" issue. In short, something critical. I think it means vma lock will never be fixed in 6.4, and it can't (because after this patch it'll be BROKEN, and this patch copies stable, and we can't fix BROKEN things in stables). Totally no problem I see, just to make sure this is what you wanted.. There'll still try to be a final fix, am I right? As IIRC allowing page faults during fork() is one of the major goals of vma lock. Thanks, -- Peter Xu