From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A35BEB64DD for ; Wed, 5 Jul 2023 20:19:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 650908D0002; Wed, 5 Jul 2023 16:19:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D9B48D0001; Wed, 5 Jul 2023 16:19:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47B0E8D0002; Wed, 5 Jul 2023 16:19:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3421B8D0001 for ; Wed, 5 Jul 2023 16:19:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EF5621C8E9A for ; Wed, 5 Jul 2023 20:19:08 +0000 (UTC) X-FDA: 80978672376.28.F08DB16 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 2D92D160023 for ; Wed, 5 Jul 2023 20:19:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Q8nN/eVz"; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688588347; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T0XLnvzn5FkOLIw7q3RfBWKmkfDnS0W7AG/lbyZT7fw=; b=JmTOslBKOsmgWJ6HR1JSZxc/R1negMIdCKBn6gFVTnXhtIbHDf6V3iUbGQtBkdD3Ad0SDp ftO5Usoyh/4POdSS2qYPllctR0sEOeFuP0MPqJczo/ftcX6kZgkLIHRrt6sN5uvEwKO+vO a+TRVpkEaJneOqPVGdMG/Sdx9kJ3R2k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688588347; a=rsa-sha256; cv=none; b=xTCB642VnEOXMpVvl36eB6/kXm/I2U7GwPQzkvjkiaoqNmEijtXpy5EladZT26tXPfd9Tn m/EYTPAesd9sFQmXbJbFxEljAScn8KxRKkAiWgCBNGpuryYa2h5gS4v9tc0KuEa3Yb6kTC qIn+wVPUtdRyIPWQvC2mcOUdJI4Cwiw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Q8nN/eVz"; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=T0XLnvzn5FkOLIw7q3RfBWKmkfDnS0W7AG/lbyZT7fw=; b=Q8nN/eVzqtRFhuNEk4/aZxiwlf b7nmE8lceUwvvkelHvAh5oK6q5zyM86Kco60daX9344Go8jHWsQhYFgnDwjMdBblwWw5YWU5nZ+Lp zBH+5PCKSX65joIEYLlpbOw4UK471N0qDkcUmLnMhR/OyZ5qxj57WWKNkEvf41yxTvfoQrrhM0yc9 5F8C+pmqA0h3nHWwswjhLTC29fyoiuUiOBxiewi/YDVrcCSMIBjUFzgtj247FDte95jEFQZAQQVt4 oJfH7aftPSAW8CxkGBtSn83CXOLoYpoyoi7WrMECd0vaqo8diyrlZb0LoqVd0aMMf21rHGzI+J/V0 b1LwHeTw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qH8xp-00AORJ-Aq; Wed, 05 Jul 2023 20:19:01 +0000 Date: Wed, 5 Jul 2023 21:19:01 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH v2 4/4] mm/memory: convert do_read_fault() to use folios Message-ID: References: <20230705194335.273790-1-sidhartha.kumar@oracle.com> <20230705194335.273790-4-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705194335.273790-4-sidhartha.kumar@oracle.com> X-Stat-Signature: exn8prnuwfr1sprcoj9ri8w1s1cqoxri X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2D92D160023 X-Rspam-User: X-HE-Tag: 1688588346-794536 X-HE-Meta: U2FsdGVkX18Zq9V/olFmRMPI/ijQJIj5Ley9IJjKY3Asvn6/OqThsr7mbd8UAMsE6SrEe0v/NH9DYKtKFMU7EBypMQADhE7JX1Ka75ey9XLqdxcF5zxthl15YdrOWuMTtpB21Xa6/GcougD+Rtq464QxuhXTBOhwLbkrNjH6p8tyRY5kZGECsTungfzk8ZUNZM8sl0/Yh+h1DWgB4S8AIjkA2O0QpFjA1CoYGWIoQ1QZULnGRVA7lvEcyKyQLAhSTKPz2+Cc3ErGdPH1YRoRXhY1e1FhEtGWYqyqxjRr7tVd0UvLC++AZaTfs7Ob1OXAm/PT+61Kpx0VeuTrYqN6r1nIo5thBin3HO9Tg3vW0sY3U/9PuGezy89YBrnsKmbfhP6KyYcDRNXW9jM01IDTPa1eK7zt3DX9ZQ34LVZIV2vyY3SSc1jDEURt8uc+nqrUjjUaZ1eWRyjWc6LcG4iKLX+EzKH6aCqhQmvdGRSsP/9JtaFb7TLtIfgrCMBCF6Slq0e0NNCWVKb0yZEunHOVpVxQVxKEsKwXdbtYf3RS5w4RvKuqnwDyZo9vXhsrEPQzHDxobHHg1GYMBMg2jvnZW0tyRXXks+Mc0FJZwcg1sTfyZk6ybqyiASq5U5jOFfyTXuKkh8ljOzlGkXTo41s7jicT760PxNlRZQqowuoWnHc6Z6jYBszO2ZXL0XpF34jRGoCzxjpTnmQNaF+8DHLH9l85qhvlAQ2zWCG8N7xD+eqCy+3YndAewUIwcDWWKeF3oITkGAyDEVu0ZX71bQ1+jgCQgC93MWHbP4P80Nm4/d3lr0vztNqe1T1qhyxrfYbnke+H82lwK2u0gRJPtuUQ/IPY11oOaDG1LpjW8wklZ9iuDsdkKdpQEglENaz2HlCzsGKkaJRqfYWgmU6wi0KWff6LXxLru+7NlZI9kCPc2+YgTgdYQngGERnX/6Fk+fLgyRg/vrIeq+ma0f+artz u95RMTNO VG4UKck9ZKNPEcMhJhMNdNCCZ1qco5p3/AGE5UP46sf2VHfPp1S84wOCu9f+ETRBTP61CPJiSVYi2qFYxugAxnBqhVmrVGpe9Gn7d1rSdrecxOHoY0n5G2K4M0xZuZIzqcUmrP5GZgsYAD0ULW4kLA5Vd4s8cRcMUAppRjx8agc7bthEaj4lICHzpKjkDPBfo0ziwLK9H4BXbTy4Jzai7TM4GQKhAFgfjha1M0+NnUAyzFj/BTaSIUv3VbBngDvowQ9vLDwTFQ4Di/ic= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 05, 2023 at 12:43:35PM -0700, Sidhartha Kumar wrote: > Saves one implicit call to compound_head() > > Signed-off-by: Sidhartha Kumar Reviewed-by: Matthew Wilcox (Oracle) > @@ -4543,10 +4544,12 @@ static vm_fault_t do_read_fault(struct vm_fault *vmf) > if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY))) > return ret; > > + folio = page_folio(vmf->page); Why not move this down to after the call to finish_fault()? The compiler should be able to do a better job with that; it may have to spill it to the stack to preserve it over the function call. > ret |= finish_fault(vmf); > - unlock_page(vmf->page); > + folio_unlock(folio); > if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY))) > - put_page(vmf->page); > + folio_put(folio); > return ret;