From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B76C4EB64DA for ; Wed, 5 Jul 2023 20:04:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F6E68D0002; Wed, 5 Jul 2023 16:04:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A7488D0001; Wed, 5 Jul 2023 16:04:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36EC78D0002; Wed, 5 Jul 2023 16:04:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 27DEF8D0001 for ; Wed, 5 Jul 2023 16:04:02 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 024861C84E6 for ; Wed, 5 Jul 2023 20:04:01 +0000 (UTC) X-FDA: 80978634324.08.A299317 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 9A07B40009 for ; Wed, 5 Jul 2023 20:03:59 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=aZl41unk; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688587440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hYu/o3mpdq+vSG0rEUxmM7nw3556mrzLaeAJu/zu1Qs=; b=XbM9S+WzA5GQ2xbgKEnJiJXN5dObTxyYHpdPHFcCsJfUR3nkvugT020rv2fkR79PjbPf53 GmNIfRoi4ZbvYVzkJ/uP6tGDJsNSV6A4j/HbDchTV+BbIWlZKwxEBjzf6UhOlvboL1P9i+ JyO9EjzuolmYfLafSG1PtOWui8TW+w0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=aZl41unk; dmarc=none; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688587440; a=rsa-sha256; cv=none; b=hr2jNEV5j2hjYFrfNBGlw4Wz8UdHcevlEZiC4xLS3MIIcnb4ihDpRQ1qSSQr4/0mEcJEtY fKIGpUkkDB3iwGAUq0VfW698+9QgXkTEhc4P5iKuiLFAc4zf+U9egB9np0O2OPHrDqYY77 HR2U9PVJNJ83wp2y3h264TRn3IysvqM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hYu/o3mpdq+vSG0rEUxmM7nw3556mrzLaeAJu/zu1Qs=; b=aZl41unkOjryNr+eFfIF42oXWU jOwgmOQmLrp6G7WW9S63RIPCZ2hiLgPxisQ+80/X9THBVSTXUg6p3ugVFumbTcjrgLUXGO1qq4uuR GGHASJA2Pp3fiwDakd2kGZT3YRPO/CQqGckFoQ6sE0M2+VkXWuOpGXP+LARV7YiBoNH6ItUfaiP6U TyJIgjPjUOzOHh3EXs5jaIeXA9djKcxKEXxKSn8omhSaqDC+hkvHK/nhifwj7LAdeRZ/VY+TmgXwo Gzo6eMbeC1cUm495Sl6RTbztKcONMs1iLnV2jC4eMUtn+wLfmAEuPthCLDaXoDJenTQR3F5qOOp5a KiZkA3kg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qH8jA-00ANt8-05; Wed, 05 Jul 2023 20:03:52 +0000 Date: Wed, 5 Jul 2023 21:03:51 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH v2 2/4] mm/memory: convert wp_page_shared() to use folios Message-ID: References: <20230705194335.273790-1-sidhartha.kumar@oracle.com> <20230705194335.273790-2-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705194335.273790-2-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: 9A07B40009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qkmp1fuesj61mo7gox9dm64f8f5h1udt X-HE-Tag: 1688587439-686384 X-HE-Meta: U2FsdGVkX1+3HZGVPKx0k9lh9wrQku6fwksibqlLaQU48hOu/3eENRrwBDEMKiKcddhOdxsD86MKAA3McCeONNlXvaWOb3FHX3LJgwB6kjpM7NLwJW0ij+BDhPiU06yp7X/rJGwZ9tnTv9zJMaWwQEFQNmfz1yiCfioxKCudZw6ZpLrQHfzLeaLriGgGggKuVjO+6q16A1CFI1i0VsvJrniKG/HoaQJAdFhUhX8LGZRrG0RMQf8ARs3U+8pPsVhDWcf0VtagESK0K7EGiu9ZUlJEWr9uX6ODtFjElpOdFGRMfdBPZ/R/A8xf+YNSPH/Alp1DuqEllSgcbhLoKqMa7VMV65vVNOLZRhdnRU7ahH6HJrQwQxKyVpDxpI26Vwuy5wXRl+mmWgPeiFMScTdHQSO9RGMnIxFdLGhsEDkMU2RJy2k+A2v+uOCkV6Y0mpZzn3I4iHcrBqez1Wy3bZP7N7imb/nKNgwN2ZbeKrVpq+1oQQhxsy29jreIX0f+tR6PyahGyD5de8NYCUdJ5OYPKFvYMDxcMuGSCzrwLOQbM/w+OElQE/1ZH8quljN+iWYgPCkfUJi/QOp609Dr7tzJvrVyYliBCm+d5HxVRyAe8j3aXl7cJVywQSgKNGDZDZU10B/Fnwd2dcjr/ILBuESHtICez53yd+qsjMxyUIBQNYvYAgjB/AM0lt5eT3XhjFI0OOvwm4mY+DJ4CkByM8BgLPBRhZNdiMzP7ju/FnkTscxT6yH4mNJbWYQDo/np45cR6V1/NV46IabJM/7iwHi3iixRZ3TJfZblf8lX9GmIJAhWY/NCs8jvTIzA9M+kxg/MeDb5dvuQQZOI4voKtwtxS3corpQp68cCVxfwc7MGYyRDcLRcB6cs1aoXud7M8PBW2ZbOCA8K81wtLa9urgkb7HVanZ3nl+IQZI6gNOVLoxT7LiUHbBbbwB7RHUJyV5fxUNQEgQvLnTgtyI+P39R B9M8/J6i KpjKR8ph5UWxZSaNa4L7GtUYUliA25Ds4TTs0jwlXIWWEcDU65uUH6vi4nREhA3IqZu9i9Mcue1ruRY8pWEBiKtrPFtpQbvsswLwsOUNebx/imZGG5xge82WWlZ64393gx/HGmAjMGA5Ll80Vih+tlnZ1kM1oIF1xr4cvwWMQ1lHORmp+ZU8r0jB2yqrwCAhsOlBQ16wfk5Lgxgg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 05, 2023 at 12:43:33PM -0700, Sidhartha Kumar wrote: > @@ -3375,7 +3375,7 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) > */ > if (!vmf->page) > return wp_pfn_shared(vmf); > - return wp_page_shared(vmf); > + return wp_page_shared(vmf, page_folio(vmf->page)); > } > > if (vmf->page) I was actually hoping you'd move: if (vmf->page) folio = page_folio(vmf->page); up to immediately after the call to vm_normal_page(), and avoid even this call to page_folio().