From: Matthew Wilcox <willy@infradead.org>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org
Subject: Re: [PATCH v2 2/4] mm/memory: convert wp_page_shared() to use folios
Date: Wed, 5 Jul 2023 21:03:51 +0100 [thread overview]
Message-ID: <ZKXMp84KxEvlsWKi@casper.infradead.org> (raw)
In-Reply-To: <20230705194335.273790-2-sidhartha.kumar@oracle.com>
On Wed, Jul 05, 2023 at 12:43:33PM -0700, Sidhartha Kumar wrote:
> @@ -3375,7 +3375,7 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf)
> */
> if (!vmf->page)
> return wp_pfn_shared(vmf);
> - return wp_page_shared(vmf);
> + return wp_page_shared(vmf, page_folio(vmf->page));
> }
>
> if (vmf->page)
I was actually hoping you'd move:
if (vmf->page)
folio = page_folio(vmf->page);
up to immediately after the call to vm_normal_page(), and avoid even
this call to page_folio().
next prev parent reply other threads:[~2023-07-05 20:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 19:43 [PATCH v2 1/4] mm/memory: convert do_page_mkwrite() " Sidhartha Kumar
2023-07-05 19:43 ` [PATCH v2 2/4] mm/memory: convert wp_page_shared() " Sidhartha Kumar
2023-07-05 20:03 ` Matthew Wilcox [this message]
2023-07-05 19:43 ` [PATCH v2 3/4] mm/memory: convert do_shared_fault() to folios Sidhartha Kumar
2023-07-05 20:13 ` Matthew Wilcox
2023-07-05 20:16 ` Sidhartha Kumar
2023-07-05 20:19 ` Matthew Wilcox
2023-07-05 19:43 ` [PATCH v2 4/4] mm/memory: convert do_read_fault() to use folios Sidhartha Kumar
2023-07-05 20:19 ` Matthew Wilcox
2023-07-05 20:25 ` Sidhartha Kumar
2023-07-05 19:52 ` [PATCH v2 1/4] mm/memory: convert do_page_mkwrite() " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKXMp84KxEvlsWKi@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sidhartha.kumar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox