From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 585CEEB64DD for ; Wed, 5 Jul 2023 06:47:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E620F6B0071; Wed, 5 Jul 2023 02:47:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E115A8D0003; Wed, 5 Jul 2023 02:47:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB2368D0002; Wed, 5 Jul 2023 02:47:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BD6846B0071 for ; Wed, 5 Jul 2023 02:47:52 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8D878B02E8 for ; Wed, 5 Jul 2023 06:47:52 +0000 (UTC) X-FDA: 80976627984.14.AC56088 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf26.hostedemail.com (Postfix) with ESMTP id 1672414000F for ; Wed, 5 Jul 2023 06:47:49 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=aRu+YCjg; spf=pass (imf26.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688539670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yv/FrLpT08L3Apc6b/gXrDeCk9yGnPzfjdRohkIs4Xg=; b=ml7GjI9Cz0r+Gylbm+wWZh2CfaGEdLFJuFROs7681Bp/Cce9mJhLAkC3jfVQNrDNMCsGcG DRvT+8LQMq4qVjDB9wkn0ROVG9JlbHFMKFVE/oHMk8DxsvtTsxxwzbWYvUyWprLRDjs+xU FpU24/QqabZLDwmEsG0cgOXZsZ4FFMA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688539670; a=rsa-sha256; cv=none; b=vOf+Rv4UiIPPjd9Wf1PA9cbPCTaSm5li4Xns/OntVL8jE8WDXdo4d6nm7R04JntRyPhqwC qb3TL82BYbckFyzDmnihdSaRdZag/mMUFBMBsuO5/nUQl76H12sVlcJ2DT8Hti+lCoC0EB eTRFyOn5Xz5MqX+rIQqrgja9dh4Y5tk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=aRu+YCjg; spf=pass (imf26.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3656f1xm028694; Wed, 5 Jul 2023 06:47:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=yv/FrLpT08L3Apc6b/gXrDeCk9yGnPzfjdRohkIs4Xg=; b=aRu+YCjguXlaQs3KW57NglPu5FkypAP2AchYFw5pBdBy9y7U8L1iFj9tqPw43Wp9KWUM h1uJfl0AS3xvPJmY5nt2yNJf2XbEWf4a6URxjTtmnCbK+1a7lkOxV3KwP6MYk9+LfPHM dEvE0YrFYGaoWymxsQikjBSOSnCwMulfTGGJ6VoZuzrRVHvvDlj443Pi86yjGsxVawpf JZFRMi3/b+p+TPgOyIXphdvtaT1LwTCNDRyg593RYD/6iVgKmhyBW4Vw7nKLNpy5uiE+ AkC7aaoVdUP10eZw3L8f2jMd3L+W/0xKo/3SiiYgaAVYB7OfQuvx8Cqe+BKGj0K+T7k5 6w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rn34arebt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Jul 2023 06:47:02 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3656gT3K032743; Wed, 5 Jul 2023 06:46:56 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rn34are2f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Jul 2023 06:46:56 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3652HG3Z002094; Wed, 5 Jul 2023 06:46:48 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3rjbs4tef2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 Jul 2023 06:46:48 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3656kiFM38142352 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Jul 2023 06:46:44 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B4E8E20040; Wed, 5 Jul 2023 06:46:44 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DA85B20043; Wed, 5 Jul 2023 06:46:41 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.171.53.49]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 5 Jul 2023 06:46:41 +0000 (GMT) Date: Wed, 5 Jul 2023 08:46:40 +0200 From: Alexander Gordeev To: Hugh Dickins Cc: Gerald Schaefer , Jason Gunthorpe , Andrew Morton , Vasily Gorbik , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Russell King , "David S. Miller" , Michael Ellerman , "Aneesh Kumar K.V" , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , Jann Horn , Vishal Moola , Vlastimil Babka , linux-arm-kernel@lists.infradead.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 07/12] s390: add pte_free_defer() for pgtables sharing page Message-ID: References: <54cb04f-3762-987f-8294-91dafd8ebfb0@google.com> <20230628211624.531cdc58@thinkpad-T15> <20230629175645.7654d0a8@thinkpad-T15> <7bef5695-fa4a-7215-7e9d-d4a83161c7ab@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7bef5695-fa4a-7215-7e9d-d4a83161c7ab@google.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: hruV8AkSHZl3ANlxXk4XPZerf2HqhW4w X-Proofpoint-GUID: qjKoYY9T1h-a6Vm3seAHuVTkQEuDrdL1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-04_16,2023-07-04_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 suspectscore=0 adultscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307050058 X-Stat-Signature: mjgcb48szorda9k9dkapqbmsygdy3zex X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1672414000F X-Rspam-User: X-HE-Tag: 1688539669-156221 X-HE-Meta: U2FsdGVkX1/lP4wl/K5DAgoaSyKQ9D3Ee31jJMIwz7n0Xx39kmLp6V8Cjy6LVpMAO0nerI7rIr02L/rwom8s8hiTYkQfnQroW++dbz6rcgAdXZIdQlM1qWTqaj4KRUnrHCwBBygArW5Mp7BZTFCP/JTeXsp4vxuMUqVWWSer2efU/AbKm01ENrjYHleJqzjlprhWkNZE6bO+LTyscRiFJ8QXKFDMWNGyFIlXiDgvoWucqY2pu9IQmKknxtN8nmmLplu4Olc91dwtIIQ/n+Og3tdGbptIdqZ/8FtopF9cSRAEWCKNyRdOpWB8MjLOuukYiphwhpxS58P6D9ZyuNpljUPI1Zhr33TXJ5LylujWk39JwoMmuxmAM5kP6Y+U8MWfQTaW5CKnKCKoUt9BWJNh3QCAUeaASqy1JS1ouofsBLb/EdXO1dcWl5aYEaysdb/oYjh1A2ESOufH75DsIhLwyYi/QMJc+iZL39o1twrBYRJZEaDy/6cG+2P7Rv/PwCuCRplZNF/E2ehHSnkV9D2ReeSzuvUft89QTgn5ZHtOZsahqSuIVsUw0jIV1aaGnCAdn7hM7Fp2FhmIATi21cndLA+slcTRbXgQCWVRfwravY/wBtx7l6E1QQfFDHDJWSG6Xfzkwd1JvXdOwaOsKzcqfKjbNRAQg6jvlP7rapF9p2KoX6mUxWE3lNRzzGva9Tdf7M/jhsif3QY2C0ukRewnXQfJ3fRiiMztJO9alWA3HhAGtmUO4YG8+WgeU7kluSDJLlC+/w4VWv3xW3jUwXiuKo/gcLpoIuxlFKOY39+sA11gTPTxrCbuwiEYJhfVJ69ff9aXz9OdqTCkDDXRe6hRG1u1p0o7ZPYrTH+hOgsY2H8bo0qhrxyHQMALZe7C2jWFRnQAmS6FfLZVzZLzxbWNPvu8B48tRpLWpP+ytTgYSBKoYsAl7DUST84J9n5hwMdYj9ThQSWvOAtzEn4rgSD qeMnKRNb f42YOONJpqyyp7/bIY56JPmw3qgaB0DyBQFd3f7+S73i4Bitj0bgw6OUBl8lh7Y2b/ul5jyfcHV+j8ftS62IKWd0NNICoBnyIMPbxmz0GelYKl0JHatP8kA75J19fGbmHp0jEiLhyggy1ae8RTlxPMW1Q5ZH9WfD0b/CDbeRmPub4s7AJZU0P2BCywzE69mDHbZi3of2N088YRRWhOtqD9MrQJVrgfEuwdAcFk6fckNPTUZLA7Fy0JxmmnWyIvIAfkmrG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 01, 2023 at 09:32:38PM -0700, Hugh Dickins wrote: > On Thu, 29 Jun 2023, Hugh Dickins wrote: Hi Hugh, ... > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable) > +{ > + struct page *page; If I got your and Claudio conversation right, you were going to add here WARN_ON_ONCE() in case of mm_alloc_pgste(mm)? > + page = virt_to_page(pgtable); > + SetPageActive(page); > + page_table_free(mm, (unsigned long *)pgtable); > +} > +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > + > /* > * Base infrastructure required to generate basic asces, region, segment, > * and page tables that do not make use of enhanced features like EDAT1. Thanks!