From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B18DEB64D9 for ; Tue, 4 Jul 2023 22:43:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8F2F2800C2; Tue, 4 Jul 2023 18:43:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3F3E2800B2; Tue, 4 Jul 2023 18:43:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C06D72800C2; Tue, 4 Jul 2023 18:43:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B14B12800B2 for ; Tue, 4 Jul 2023 18:43:13 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 80DABAF4A1 for ; Tue, 4 Jul 2023 22:43:13 +0000 (UTC) X-FDA: 80975406666.28.5446F30 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 114D3120017 for ; Tue, 4 Jul 2023 22:43:10 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NjFRomCS; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688510591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8WYalEsw0RtarZQQ0fbThUM1/qMvUSLTpKAEJ6snO18=; b=dFmwZbwgCOABZWxhWOGJRV9/iUZXvZUZ8gytF1tnri6OLKxkBm/petmv4MCqE9R3tN8ghW C6P0cpedesDi1ZJkA1hypXZZpYulzxBsjInkw0S2j/kvhuRy2Bp3a7/3c1iiRmGxI6AuaT PxI9sRKNQ6zV8lFkqlAe2UIKfR6fWBo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NjFRomCS; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688510591; a=rsa-sha256; cv=none; b=n2S6ze/CWWW4hUB914LX5926rzudYcuj6ZwXzmZsoaXoqLLmZ7ehOjT+Nb73ph1nF8ap0z aapUrFSpt74nRphdwHZP/cqQ8pZ9DU3+NcGsrbxoObQIJ2j82rNyNm8hoeJWxbfGk8r7z+ iQVZWWZYNcILZY1PnpELSMjAbI8PTSo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=8WYalEsw0RtarZQQ0fbThUM1/qMvUSLTpKAEJ6snO18=; b=NjFRomCSKP60NIzVBD8efvEKXF mOQOBN2DQdZQUlTfDeYrCqlE+hcJ6+hoLfNcEHeR5AUUBP6IhZyV8jvdZmuZmns06W7U8j63/XBpV QF7Gdiyaa69zJvWnvOwyZvh20+mddQHgsxCyPABvEVFqspF6DnXhyY7VVMxlwd7dTHN5qI9CM7Z2W xhS95dlm95olYdocbqCLQmsDEt/hK1oYKjF/RHOz8Y33OUPHfB6uaN8FregmTW5XCSWY5LtoGDP1j ICCcXWX6H2HJAB4mCDWAk9P0fO1t6lWiXbS2lrAc4dFFo+QfUh2jwtCMHWhLs3IlPoFouEZQKOl+a e9KE1p6w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qGojH-009Wy9-98; Tue, 04 Jul 2023 22:42:39 +0000 Date: Tue, 4 Jul 2023 23:42:39 +0100 From: Matthew Wilcox To: Holger =?iso-8859-1?Q?Hoffst=E4tte?= Cc: Suren Baghdasaryan , David Hildenbrand , akpm@linux-foundation.org, jirislaby@kernel.org, jacobly.alt@gmail.com, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, linux-mm@kvack.org Subject: Re: [PATCH 1/1] mm: disable CONFIG_PER_VMA_LOCK by default until its fixed Message-ID: References: <2efa2c89-3765-721d-2c3c-00590054aa5b@redhat.com> <3c042dcd-192e-7050-07f1-ce891b95dfca@redhat.com> <7d6ba07b-ee60-8920-b91c-04c826eb4690@applied-asynchrony.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7d6ba07b-ee60-8920-b91c-04c826eb4690@applied-asynchrony.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 114D3120017 X-Stat-Signature: rm38fc8izshpz57bj7ps8fj8xun1iua1 X-HE-Tag: 1688510590-689878 X-HE-Meta: U2FsdGVkX1+0SxygIo0bsFBAjIxO1Jserh0ASEKU/aMuour8iIm9SdErBniNR4Jn8M29J/LoO2LVgzRC5j/kweFT70nn/aMIbpV/eXQpYPAq8aeBN0p8EaB7uCq2ZfKYPKVc2Lwgfwc8FsWLr2wEK5HJYGCazauAv/UdMyF4TxsVtnr5vDJSe0mAZUo4uPSAVGixvZfA4PW5+NugAxm+/ePFLl9ESID7YM8ktVPG8bBugtyT+aI8hx3m+kQ+zY+CQ54EmC3wgtgc+8XiEP1EGy4gYu6wo868B6f5YKKez4g8pbgB/+tR1aOFYxRGbefMc563cuLd7sPgmKoUUQ2mvRE2hRwYZH/itaOgJLlCB7UPVfKO9KLI/XW3Se6t1Ok8HXweLYYGjXDHv4BhFtKpTgbB99/umhyrzLWySKSGVmEbxYunaWj+jbKj7+QW1OJSMeihRm50Z2oTnbZcJgDq74lsk2cDn5zvTOj1thiYbuypyrribpU2g6+2L00wqsaf3tuyed3e3eerfY/+3OPNSFk1DGH2YdSG5tAL3pIv51t4lgnQUzMHqGnpfN2CZjnc6gQJSknFjw8NV7B040HPTFt2RHzMAA7nJ2Pj3gaxPLoaLlUzC3SPOMniN3e4dPD8/aCYE0PfP8mgmB5QI8BghFPneYkmEMkjMuHZAHh1GYgefEbbGtP9z+/MmILiVHIfSu+3Ra6bt/S1Pa4mRxDVLkF+DEMq7hM6exQ5RAS2uPblaUZlP2gl/eCHWmRKr/vyQhVF1GyJUz//PnZ4C5zznq9MsHxp29+zF9F5llY8Y5iUBkDT8/WY9q2UnGGPwQllatX//z2b9oryBfZh39V6357BCXMVOG7o5V374lD/e9ErPZHY9KJTTYYtoC7NRi1ag8U/JsEPlzGfV5/5hOWIZ3SquIDcH+GofkAwQ2JBkhbyWWPVCyQiBsfzvsDojvTu+TMVSYKcJX8P4FU4FzW 0pp6zNFS IEA4lZsnRuq40aeVMuo6uxnr7UPcxYe6qxwv4dk4D8nDvPbZ2VaUDolOnSxsQ7zXjyROcGFm5GFoT/1csguPGfNOKZwdoMNmKAnnTNFrMz0ZmwkxeY9ehXTO5bFr+XM3mNqJCZxO91XUjNGC8dMkvyZkBXA+XtlBWR0cPrTtB8kok17IBcoOwjmkb3W7SzvK6dNxoNULmajY3FkFE0WLGdJZqKhfAwaeYvEJimhkj/MvwcJOW1RggaX7kSOvN/TkHqPG1rnKm/RHVkNGqcOWri4/sLLQsj8gVp0uAe4vBF9+sYoqsbmdHIxh9P8yuzzjNRTKettrp4204R63EDqshbd320pUpaml5Qof6gb7dOJ08eWbW3ZTVKLoaYQY/QktaAgaL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 04, 2023 at 11:34:27PM +0200, Holger Hoffstätte wrote: > I applied the fix and did a clean rebuild. The first attempt to boot resulted in > the following oops, though it kind of continued: It would be helpful to run this through decode_stacktrace.sh > Jul 4 22:35:22 hho kernel: BUG: kernel NULL pointer dereference, address: 0000000000000052 > Jul 4 22:35:22 hho kernel: #PF: supervisor read access in kernel mode > Jul 4 22:35:22 hho kernel: #PF: error_code(0x0000) - not-present page > Jul 4 22:35:22 hho kernel: PGD 0 P4D 0 > Jul 4 22:35:22 hho kernel: Oops: 0000 [#1] SMP > Jul 4 22:35:22 hho kernel: CPU: 10 PID: 1740 Comm: start-stop-daem Not tainted 6.4.1 #1 > Jul 4 22:35:22 hho kernel: Hardware name: LENOVO 20U50001GE/20U50001GE, BIOS R19ET32W (1.16 ) 01/26/2021 > Jul 4 22:35:22 hho kernel: RIP: 0010:wq_worker_comm+0x63/0xc0 > Jul 4 22:35:22 hho kernel: Code: 43 2c 20 75 1d 5b 5d 48 c7 c7 e0 a4 43 82 41 5c 41 5d 41 5e e9 7e 6b 8b 00 5b 5d 41 5c 41 5d 41 5e c3 48 89 df e8 ad 35 00 00 <4c> 8b 70 48 48 89 c3 4d 85 f6 74 cf 4c 89 f7 e8 29 b6 8b 00 80 7b Faulting insn: 0: 4c 8b 70 48 mov 0x48(%rax),%r14 and rax is 0xa, which matches up with 0x52 as the faulting address. I'm not sure this is related to the VMA patches. It might be something unrelated that doesn't often come up? > Jul 4 22:35:22 hho kernel: RSP: 0018:ffffc90000fb7bb8 EFLAGS: 00010202 > Jul 4 22:35:22 hho kernel: RAX: 000000000000000a RBX: ffff88810cd43300 RCX: 0001020304050608 > Jul 4 22:35:22 hho kernel: RDX: ffff88811395bfc0 RSI: 7fffffffffffffff RDI: ffff88810cd43300 > Jul 4 22:35:22 hho kernel: RBP: 000000000000000f R08: ffffc90000fb7be8 R09: 0000000000000040 > Jul 4 22:35:22 hho kernel: R10: fefefefefefefeff R11: 0000000000000040 R12: ffffc90000fb7be8 > Jul 4 22:35:22 hho kernel: R13: 0000000000000040 R14: 000000000000000c R15: 0000000000000001 > Jul 4 22:35:22 hho kernel: FS: 00007f39dde1c740(0000) GS:ffff8887ef680000(0000) knlGS:0000000000000000 > Jul 4 22:35:22 hho kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > Jul 4 22:35:22 hho kernel: CR2: 0000000000000052 CR3: 0000000112188000 CR4: 0000000000350ee0 > Jul 4 22:35:22 hho kernel: Call Trace: > Jul 4 22:35:22 hho kernel: > Jul 4 22:35:22 hho kernel: ? __die+0x1f/0x60 > Jul 4 22:35:22 hho kernel: ? page_fault_oops+0x14d/0x410 > Jul 4 22:35:22 hho kernel: ? xa_load+0x82/0xa0 > Jul 4 22:35:22 hho kernel: ? exc_page_fault+0x60/0x100 > Jul 4 22:35:22 hho kernel: ? asm_exc_page_fault+0x22/0x30 > Jul 4 22:35:22 hho kernel: ? wq_worker_comm+0x63/0xc0 > Jul 4 22:35:22 hho last message buffered 1 times > Jul 4 22:35:22 hho kernel: proc_task_name+0xa4/0xb0 > Jul 4 22:35:22 hho kernel: ? seq_put_decimal_ull_width+0x96/0x100 > Jul 4 22:35:22 hho kernel: do_task_stat+0x44b/0xe10 > Jul 4 22:35:22 hho kernel: proc_single_show+0x4b/0xa0 > Jul 4 22:35:22 hho kernel: seq_read_iter+0xff/0x410 > Jul 4 22:35:22 hho kernel: ? generic_fillattr+0x45/0xf0 > Jul 4 22:35:22 hho kernel: seq_read+0x93/0xb0 > Jul 4 22:35:22 hho kernel: vfs_read+0x9b/0x2c0 > Jul 4 22:35:22 hho kernel: ? __do_sys_newfstatat+0x22/0x30 > Jul 4 22:35:22 hho kernel: ksys_read+0x53/0xc0 > Jul 4 22:35:22 hho kernel: do_syscall_64+0x35/0x80 > Jul 4 22:35:22 hho kernel: entry_SYSCALL_64_after_hwframe+0x46/0xb0 > Jul 4 22:35:22 hho kernel: RIP: 0033:0x7f39ddf5877d > Jul 4 22:35:22 hho kernel: Code: b9 fe ff ff 48 8d 3d 1a 71 0a 00 50 e8 2c 12 02 00 66 2e 0f 1f 84 00 00 00 00 00 66 90 80 3d 81 4c 0e 00 00 74 17 31 c0 0f 05 <48> 3d 00 f0 ff ff 77 5b c3 66 2e 0f 1f 84 00 00 00 00 00 53 48 83 > Jul 4 22:35:22 hho kernel: RSP: 002b:00007ffe4b98b6f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000000 > Jul 4 22:35:22 hho kernel: RAX: ffffffffffffffda RBX: 00005655194cab40 RCX: 00007f39ddf5877d > Jul 4 22:35:22 hho kernel: RDX: 0000000000000400 RSI: 00005655194ccd30 RDI: 0000000000000004 > Jul 4 22:35:22 hho kernel: RBP: 00007ffe4b98b760 R08: 00007f39ddff8cb2 R09: 0000000000000001 > Jul 4 22:35:22 hho kernel: R10: 0000000000001000 R11: 0000000000000246 R12: 00007f39de0324a0 > Jul 4 22:35:22 hho kernel: R13: 00005655194cd140 R14: 0000000000000a68 R15: 00007f39de031ba0 > Jul 4 22:35:22 hho kernel: > Jul 4 22:35:22 hho kernel: Modules linked in: mousedev sch_fq_codel bpf_preload snd_ctl_led amdgpu iwlmvm snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec_hdmi mac80211 pkcs8_key_parser drm_ttm_helper ttm iommu_v2 gpu_sched snd_hda_intel libarc4 i2c_algo_bit snd_intel_dspcfg drm_buddy drm_suballoc_helper uvcvideo snd_hda_codec drm_display_helper edac_mce_amd videobuf2_vmalloc snd_hwdep crct10dif_pclmul videobuf2_memops uvc crc32_pclmul cec snd_hda_core crc32c_intel videobuf2_v4l2 ghash_clmulni_intel lm92 r8169 sha512_ssse3 snd_pcm videodev psmouse thinkpad_acpi iwlwifi drivetemp ledtrig_audio drm_kms_helper rapl videobuf2_common realtek snd_timer serio_raw snd_rn_pci_acp3x wmi_bmof platform_profile cfg80211 mc snd_acp_config k10temp snd syscopyarea mdio_devres ucsi_acpi snd_soc_acpi sysfillrect drm snd_pci_acp3x i2c_piix4 sysimgblt soundcore typec_ucsi ipmi_devintf rfkill roles libphy ipmi_msghandler typec video battery ac wmi i2c_scmi button > Jul 4 22:35:22 hho kernel: CR2: 0000000000000052 > Jul 4 22:35:22 hho kernel: ---[ end trace 0000000000000000 ]--- > Jul 4 22:35:22 hho kernel: RIP: 0010:wq_worker_comm+0x63/0xc0 > Jul 4 22:35:22 hho kernel: Code: 43 2c 20 75 1d 5b 5d 48 c7 c7 e0 a4 43 82 41 5c 41 5d 41 5e e9 7e 6b 8b 00 5b 5d 41 5c 41 5d 41 5e c3 48 89 df e8 ad 35 00 00 <4c> 8b 70 48 48 89 c3 4d 85 f6 74 cf 4c 89 f7 e8 29 b6 8b 00 80 7b > Jul 4 22:35:22 hho kernel: RSP: 0018:ffffc90000fb7bb8 EFLAGS: 00010202 > Jul 4 22:35:22 hho kernel: RAX: 000000000000000a RBX: ffff88810cd43300 RCX: 0001020304050608 > Jul 4 22:35:22 hho kernel: RDX: ffff88811395bfc0 RSI: 7fffffffffffffff RDI: ffff88810cd43300 > Jul 4 22:35:22 hho kernel: RBP: 000000000000000f R08: ffffc90000fb7be8 R09: 0000000000000040 > Jul 4 22:35:22 hho kernel: R10: fefefefefefefeff R11: 0000000000000040 R12: ffffc90000fb7be8 > Jul 4 22:35:22 hho kernel: R13: 0000000000000040 R14: 000000000000000c R15: 0000000000000001 > Jul 4 22:35:22 hho kernel: FS: 00007f39dde1c740(0000) GS:ffff8887ef680000(0000) knlGS:0000000000000000 > Jul 4 22:35:22 hho kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > Jul 4 22:35:22 hho kernel: CR2: 0000000000000052 CR3: 0000000112188000 CR4: 0000000000350ee0 > Jul 4 22:35:22 hho kernel: note: start-stop-daem[1740] exited with irqs disabled > Jul 4 22:35:22 hho kernel: Generic FE-GE Realtek PHY r8169-0-200:00: attached PHY driver (mii_bus:phy_addr=r8169-0-200:00, irq=MAC) > Jul 4 22:35:22 hho kernel: r8169 0000:02:00.0 eth0: Link is Down > Jul 4 22:35:24 hho kernel: r8169 0000:02:00.0 eth0: Link is Up - 1Gbps/Full - flow control rx/tx > Jul 4 22:35:24 hho kernel: IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready > > It then kind of limped along until I rebooted again. This second attempt to boot > died and locked up completely, again during amdgpu initialization, and is on display here: > https://imgur.com/a/3ZE66kh refill_obj_stock() is also somewhat unrelated to VMA stuff. This is all very bizarre. > Finally I just edited mm/Kconfig and set config PER_VMA_LOCK to "defbool n" to override > any setting in my old config. That made everything work again - it's what I'm using now. Could I ask you to try a few boots with PER_VMA_LOCK set to "n", just to eliminate the possibility that this is a coincidence?