From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF7C8EB64D9 for ; Tue, 4 Jul 2023 21:15:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 574672800BA; Tue, 4 Jul 2023 17:15:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 523B72800B2; Tue, 4 Jul 2023 17:15:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 412EE2800BA; Tue, 4 Jul 2023 17:15:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 32EF22800B2 for ; Tue, 4 Jul 2023 17:15:57 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EC86D1C7C15 for ; Tue, 4 Jul 2023 21:15:56 +0000 (UTC) X-FDA: 80975186712.28.E132842 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id D6EEF40010 for ; Tue, 4 Jul 2023 21:15:54 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cq1sTclz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688505355; a=rsa-sha256; cv=none; b=xo0GiIH+QVNzR3LTXyMo9EqI4wsJXP3RmDqFu0otosXbuRGmI3Ky9ueN7j1M0Fb1/BHl2X XxXYkalDDbp6HyOop+QZdpbSmcmy1+5XCk/cJ+OjwwyYxtxnBWh+GOE3+tBXaAgP5E/f/l ekAMK66R+vUGMT6TkOBu+Udm5Ew1hk0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cq1sTclz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688505354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y8bJxR2hg9jZOo9xJJwily7Z9DBcJ34R5Ty+xrrHVZo=; b=SYkEZM44XCCs2tLaWt82Rp0sQ15bwHEa+orBjA1a2Re1hwYvjwPzQzpr6xOOnknqMpUhIw ZNUkgZoKbLWqEDmtr8fNW7bT1HrFsF11LyKs1Qz2kbk6rJ6CwU3WfaRyCWy5exHcmIJRpM YSpLbcw9ZAGetGtUfD2plcvlZVlIS3w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688505354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y8bJxR2hg9jZOo9xJJwily7Z9DBcJ34R5Ty+xrrHVZo=; b=cq1sTclzrKy5GRRZ6BowhtHGn2GJSmXuR003H402e6szEhHzB8GOxTfXWEu0/45G2ZgGwP bsc9eNiS2MsGn7aNaxIXHd6NUuqLaLJxnbmBGxdPCunMFqMirUAxiKA240UjBGZ9/VXb8q FLnsBhx48NpdZy2Ep9jhGpKszoPvr3E= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-aVpdI_6YOtGzXsEcx_C8Rw-1; Tue, 04 Jul 2023 17:15:53 -0400 X-MC-Unique: aVpdI_6YOtGzXsEcx_C8Rw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-62dd79f63e0so13514916d6.0 for ; Tue, 04 Jul 2023 14:15:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688505352; x=1691097352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y8bJxR2hg9jZOo9xJJwily7Z9DBcJ34R5Ty+xrrHVZo=; b=OPr8WL0yPF9jnjCzhvyJipK5APXXOEisKomYm5bbZ8j29QTK7sZzCmqtEKOnRIoC8N qck7Rk9scpt6bG7AP2+wximVnCAnJ+xBViS2mv/QCSMFUdXvhkTdnWHmdYXw5nsrOAo4 /meMS+Vy3unYBuraQS6QrPSh2dCUhM/TgSRCN6+bFH8m4Rml9WKecILCBd427k/OZNwZ RumvXopbZ9JpKS8W/0T0RMyfc6Fg/RMTCzLW0q0EyGiUnJBJjMW/H00b21cm374sGgfg MRxHzzfTZRk4V4uvEbkTvJjnoFjrBbMyYiIP8+VVxcxsyRlzDim1+cFgZtQ+4V+rYB5p I9yg== X-Gm-Message-State: ABy/qLaa5W18dhacP8hba6s6nC7HCPUt3m0OBXqzAx0YIRYAShrydmlc yjZcjVu9D3IdXqS71dWkk8aiaXHTeueujIkXqx56b9x75TgRWi/XnOigoAmTiB+bDBtQ+xc+bTr f2ZeK6CEDbDo= X-Received: by 2002:a05:6214:2685:b0:635:d9d0:cccf with SMTP id gm5-20020a056214268500b00635d9d0cccfmr15299203qvb.4.1688505352759; Tue, 04 Jul 2023 14:15:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlGplsPlE6k/Ac9I4olk/6Quorme09kXiBKYGVccc9DwPZ/ze9ZJey/GJMFKHSw2A+5sGFeDSQ== X-Received: by 2002:a05:6214:2685:b0:635:d9d0:cccf with SMTP id gm5-20020a056214268500b00635d9d0cccfmr15299183qvb.4.1688505352469; Tue, 04 Jul 2023 14:15:52 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id px11-20020a056214050b00b006238f82cde4sm12696617qvb.108.2023.07.04.14.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 14:15:52 -0700 (PDT) Date: Tue, 4 Jul 2023 17:15:50 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Christian Brauner , David Hildenbrand , Huang Ying , Hugh Dickins , James Houghton , Jiaqi Yan , Jonathan Corbet , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Shuah Khan , ZhangPeng , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 5/6] selftests/mm: add uffd unit test for UFFDIO_POISON Message-ID: References: <20230629205040.665834-1-axelrasmussen@google.com> <20230629205040.665834-5-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20230629205040.665834-5-axelrasmussen@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D6EEF40010 X-Stat-Signature: zbwrnzjah8wtxsm9og3iqgqgid8z6oz7 X-HE-Tag: 1688505354-74668 X-HE-Meta: U2FsdGVkX1/Rc5PbZHAy6KbdzedgB4OZj03j6JkHQh8iLqYRr4HEtg8rlPXiRMH8guuisnpuqMu4EL4cqOJVVAwbc5R0ixF2OMRsobK0WHm6hoCmoq4b9p1NNg3/2h65XVHFGOvOFSaYmmA3eZHmlELfcc1xZikfUk6MofuBFzy5BOtavvvx4j8v9C2T6FM5UdpJsc75QjIyIbgD3ernipcm9s9t96IQ8Z3j1GCoQZhKhVJLx1ZYDqlmR4NCABQZ+cFMDeAnZgnkcFgFPxd0yt5MAXZmLqtPck3RTykobBlAVz0Aw8ElM62K3YyYwmshVL30TY4nqr6fUppPYl8aOrG3O+iBSbaP70M3mJ5GawE0oLw6J+cj3PLLNtJ4Xm9zJ72n0CdolWI7au0744zr+azCKtOxDdaG5Pm40wdxNaBYA7ktsyCnZIgt8FJOSJKY9cLk/CQ+ygcPQ+nC4QckzhR7wWNysTTZ5bNZDbyDrejTT/IcfIfviKfnc+bmDq8XwFUqiZ8fgt5Qt9vxBauQ04c+qv/IGE+Vww/j1kRzYU/N0iBbs4BWUsv9VkFpLn1j/buZnC9eZrKiK5ffsGY3e9DikNmGyLf/Kwr7N/DD2ZsSmMXNlzUjI+fRA40l1GrT8DLqIb4QHbREhaAQ8k3U1PQ8ZKSlAILsE/eos1LK2d6lGxbQmVtEMChZodszTQhWH+WS6oKZPvTtmpt/Clcv4DGLV3oP0pvxOlH6ctp/YWfSusnCZ9kYRS3ffj0CouI1upUdsJghO9Q7A40Wv3+8XJ50crc0fS4SNNonEoXAKsWa1013j8JE5B324UbQ5O4yqHhR2PZ5+I7zglzwy3OAMY8tihIs8WVR4LWwO02gbVlYWuCGCOgAoNT6MXQKzcvMUdi60FS3ubu6CBABLDt2L42jR5j1695twzLHF7RJ5Ite+hgEfREf53gtIu4B+HHvXAjUiPrgLOv1Mdchc4S 7SAvXkoA 1oMfYKeOaBzSBeBon6qULvNdmEbiO5LywwjqjwpR/Or/GtrbQqbNXeOKuUhGxlv5KzV0uozOzNvbfa0vStEAGfH0YlXfyvV+dzhCqHnoiiNwWWUAAsfp0Z1bWjDiAFwTyQT0N5u71rdF/xaPhMEGh32G6F/n9CoYY8i9kFmOPasL5CKwR2WQqltPd4EarCQMu7k4Sz5Htf9sOdxQJMaVuC1gz+8pUcKv+K7b6rdc/MB1x6txcd3pik5uKuVI7EdannhJyDQmvdv8WM+Gq4ERWq4bbBd7EPtRcH2fenD/+v+038vknN9ENEp3ntT/pfYuYjRFSX0gj6cerQd7/8CbMXHE5b5c2p/Z9N+VPA7osydPT6foMfQLG7jiYu79P4CrRkh9TBmcpalexZM6x+TcxNZJaZ64zYYCz+75idYEDU6zEVLTTZCw9pL4NKEDkmgs9XpO7qTGaXLZWs88= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 29, 2023 at 01:50:39PM -0700, Axel Rasmussen wrote: > The test is pretty basic, and exercises UFFDIO_POISON straightforwardly. > We register a region with userfaultfd, in missing fault mode. For each > fault, we either UFFDIO_COPY a zeroed page (odd pages) or UFFDIO_POISON > (even pages). We do this mix to test "something like a real use case", > where guest memory would be some mix of poisoned and non-poisoned pages. > > We read each page in the region, and assert that the odd pages are > zeroed as expected, and the even pages yield a SIGBUS as expected. > > Why UFFDIO_COPY instead of UFFDIO_ZEROPAGE? Because hugetlb doesn't > support UFFDIO_ZEROPAGE, and we don't want to have special case code. > > Signed-off-by: Axel Rasmussen Acked-by: Peter Xu -- Peter Xu