From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C307AEB64D9 for ; Tue, 4 Jul 2023 18:08:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EDB32800AC; Tue, 4 Jul 2023 14:08:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17F4F280096; Tue, 4 Jul 2023 14:08:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 015652800AC; Tue, 4 Jul 2023 14:08:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DFECA280096 for ; Tue, 4 Jul 2023 14:08:16 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A39591202ED for ; Tue, 4 Jul 2023 18:08:16 +0000 (UTC) X-FDA: 80974713792.30.4DF11E5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id E8199C0010 for ; Tue, 4 Jul 2023 18:08:14 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Uag6pglI; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688494095; a=rsa-sha256; cv=none; b=KnFZTz2X1sEqEyu1sctGNEBGKk31GesMpL8TsMPklo2ZMD1N/zmNxUBeru8Uv+I6XNjnBo YSyO/eH+Jv2mVqNP123nzRJkI+xcDg0rktFR0b9hMTv1x+9TMbzAQYaSZp1B3rh8hm+fyK CMe/J/fPO0lT6PHNge8w9g/omEgx/yw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Uag6pglI; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688494095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/QQ+Y+14Y8wHCcIurGp5zUfHCaeH/cPOa7LyRJZnARI=; b=vUWhLi0wIdVdZ4XirWSus7v8epBzJHvA+uv6wEV6gdiSRyshLkLNKOAebWljbWKyET+Q34 U8b54wHpoi/lEUz1wquqeh2g61lw1lwVEAEmKF9xynOZXRX8slQ8N74SOLZF0nZ8MR88my mPe27hG8Ph3bmar9d4rB5gCPj4BHGHU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/QQ+Y+14Y8wHCcIurGp5zUfHCaeH/cPOa7LyRJZnARI=; b=Uag6pglI2bOJeECLpGyALXzsbc Q0NaPAwHEDf7FUlP/Y++2CoZe9Cm2yM/WfzM38xyNpjxlNRthoaH+6Ace2usGLeqec1FC8j1iUoqi PKmLd3TiNy+i1Bvc/HhE0Dp3EKo6qISsd/heyWV/5mxMOBjFI+C9vlrpIsYCXOvVM8PNh5tNNehfn KxlKgqlat8ndp/Gw1F5SFOXdNoNt/0Izp1KAGsAAhqwjPt4Nf+0iDLq6mK0LzxfNvrCpBIABWINPV PcMg6bT9xJKvE3QNWYHvYjetkckTquJiSqb+wQH3JUVWLFSFaK0RXOeFB/rqP8IwfAygJdhyn5r0c L/MfWmQA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qGkRf-009MKK-M8; Tue, 04 Jul 2023 18:08:11 +0000 Date: Tue, 4 Jul 2023 19:08:11 +0100 From: Matthew Wilcox To: David Howells Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH 00/12] Convert write_cache_pages() to an iterator Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <3130123.1687863182@warthog.procyon.org.uk> <3697885.1687982590@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3697885.1687982590@warthog.procyon.org.uk> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E8199C0010 X-Stat-Signature: ipxxgmzohwqbf38qbb4ptnm19sxz7bc7 X-HE-Tag: 1688494094-917443 X-HE-Meta: U2FsdGVkX1+LY95pmsKehij524MK2Plazz4FOcMpIDNJn5V+C+vgIBM7tDkJdIL11vcsXozc4dgEoTRxZm4qdO61L671J5hCbvX18vJY4Jpgx65nEUhX2iTlS+ep2etyrc9OxNO52Q2dUXxLEH2ecjvi4Tmc+SSDEJkY3BHUKJ22jU79OCsHJZIoMJ0swHiitiT5aOxDrfsTW0sUi5YZF26Ej6KUfTusvIFxQvs7+ZxOlesXr6VmKl2e2nV1sL78NwdKGYsDX0wZ5ERWH6D/1nYreGq0gyCQDuwrT6Idtz7RoQjx4qe0jwdFTdRXUCsodLAgrZ0EMfjG+U+qG65BiRoqO7tofmek603RW62RSRRrMIq6K4FnUF5TttgmYx0agm+rExv19EvE93CiTGoAIYCVnydhSAiPO12E3wm7miud51IoDpM/Dz68/4jt5LorSPss2xuoHpTILfNQjcClip3qQi7o6iUJnEfRAYixU/o0Hh7mJdTt6kbig63d14SqbaIIJ53WAD+z3DUaifVztW917UMgKtP7SYqUfmQgpXzKzMeCUpQUAruJyyonEDcI1mm3L3KqAkIIds44l1NV3iGeBU+cFMODUEL4phfms0C4O2ZYWjkBDN6QYS65V+oTM+h5xrEwCk3/VhPKVHkfc3lQgAk6KYc+YKRlV+0JE7TpIQ+yT0BcyeW8QBUQ+x/gJbI6d6J5gyn77bevndt1uJ6j6pWfs0GhvzfQ7xNo58JOAUMHNDC9SrnjXMWuTBwT7SCKcI3sJJhci7UN1+YfKE2+V3VGyk048j7cM8g9qb/h2Z1peqoVofyXm3lM8vlafW8Cm5FnOeX8nVmxipyS5YbWrkQsN09/Jiy2Yfe43H4sRZNFZWG6foPJN8Ch2CM6wgMshVLBXS0sXlKS/5ck2jdE4rFRWLxi7SscZxpbE548LEXZOi7R7gYuqAtg5ChZUGJjTI6hEbShKJgEWtF S1o8fpZh Bl5BHDsBp1qdF8Urx1IwaSNTCNk4w+i+NU3moWn+7LZeyrK8Hj+ltMPn+QPAEBpWCxNDkUuihw4ccPh8RV4642Su0plGv5naXYwdRYJH04ckpCkTQ0dJoRsfIoVx8JtKr6SuBfeFRRXlwshlDT+BI4XGzwyS13EMlpjetW/dWp2hctOGyS/e9x3ALVb3t5vAfOPo5rpg7J0FYU1uK2i2HD5yALT9Fwr3oBi6WoBzSlbfMsvI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 28, 2023 at 09:03:10PM +0100, David Howells wrote: > Matthew Wilcox wrote: > > > I'm looking at afs writeback now. > > :-) > > > fs/iomap/buffered-io.c | 14 +- > > include/linux/pagevec.h | 18 +++ > > include/linux/writeback.h | 22 ++- > > mm/page-writeback.c | 310 +++++++++++++++++++++----------------- > > 4 files changed, 216 insertions(+), 148 deletions(-) > > Documentation/mm/writeback.rst too please. $ ls Documentation/mm/w* ls: cannot access 'Documentation/mm/w*': No such file or directory $ git grep writeback Documentation/mm Documentation/mm/multigen_lru.rst:do not require TLB flushes; clean pages do not require writeback. Documentation/mm/page_migration.rst:2. Ensure that writeback is complete. Documentation/mm/page_migration.rst:15. Queued up writeback on the new page is triggered. Documentation/mm/physical_memory.rst:``nr_writeback_throttled`` Documentation/mm/physical_memory.rst: Number of pages written while reclaim is throttled waiting for writeback. Or are you suggesting I write a new piece of kernel documentation? If so, I respectfully decline. I've updated the kernel-doc included in Documentation/core-api/mm-api.rst and I think that's all I can reasonably be asked to do.