From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CCADEB64D9 for ; Tue, 4 Jul 2023 12:44:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8910280075; Tue, 4 Jul 2023 08:44:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B119B6B008C; Tue, 4 Jul 2023 08:44:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98CBD280075; Tue, 4 Jul 2023 08:44:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 812376B0089 for ; Tue, 4 Jul 2023 08:44:37 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 40C67160AAC for ; Tue, 4 Jul 2023 12:44:37 +0000 (UTC) X-FDA: 80973898194.17.90C8066 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 270321C000E for ; Tue, 4 Jul 2023 12:44:34 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FQ7AVaBk; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688474675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MTt8zrAicdNCIRJKdOYeAgLwlWREbjuubDrB9LDLoHk=; b=qWiStCJMNwZTmblnRtERxRyV5XUdYNdUR9TZU05ymabDHyD8zTfPa8hWKrOWOJDIs6HMmx RJW4iVxBZklw7eckL+nCYnh0F2/axU11RBvVUttcmHeKoUMuN3lxv5Mm6vJNTZxaXDu13t nakag9gdRGlP/3ws5VdFd16CbtNT4Fw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688474675; a=rsa-sha256; cv=none; b=SAYl88a1pZBKvaN6ZqWKVLBEm9dU/HAKfjZmRbJ6FWLGXjmNHkBYMHe1cxxS+tVpIHnFiI dWyn4xAFoBOs2ZoVT29/5WcswfTyVrY7mEkSZ7zi8ro5wVzrT02W2eF8YJ4NFjDiEAMWz7 t60t2b6K6pK9TqGWdKY6iVfdFQmiho0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FQ7AVaBk; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MTt8zrAicdNCIRJKdOYeAgLwlWREbjuubDrB9LDLoHk=; b=FQ7AVaBk1GiVkQjqboSqkOGPBq D5twh1rJ7Iuli9ASCg3UlAH0AvBtBUwBmFvGFlq65Bob5lYyyxVWcYsI1kpmfheq88Wy3j6xoPYkH Yr8SWDhirVenxTbYcufP9aI7qtE9tPtw2HdVYrOWl8KhXSL1///8tHp1coXORoa2/ua7NUKFkm8+i dZTW2mGKIGBkD8nw9XAEiECk0hIGw3K+rH1tSbKt2yF6JFa6PpHTgJc3LTGgE/JGwL7FWrIxLj7Op grzKnmKKjadKIKnXmQRg0cnlXA7KWmhAcv93Lftb6rhIWGVuVJI8IrHKh1M51oSxQqR7AKzuvj0MI qnUduz9Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qGfNn-0099Sz-9Z; Tue, 04 Jul 2023 12:43:51 +0000 Date: Tue, 4 Jul 2023 13:43:51 +0100 From: Matthew Wilcox To: Jan Kara Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions Message-ID: References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704122224.16257-1-jack@suse.cz> X-Stat-Signature: q467yhee4r4wez5779nghqpb779cs6ax X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 270321C000E X-Rspam-User: X-HE-Tag: 1688474674-406399 X-HE-Meta: U2FsdGVkX19oSIMPEpIs2SMCCcvzcypJ6aeSd+Q2xMP2jz9la86rJ58mec6Cr2U2F+q55QZ2XvqjhGE92veGZHZsB40o5wm0SR+rx6SC0rWJ/zZKhYSj8isI2yL2e7JaWWkBmZx7bk6Hp1BdiPN6hWiHkZkMC45AvB8Sac/Crlm46wG8GYBqAbQ1qLJ5nfK3EYdvBXFMfbV23IXkaKryf9LgKmax1DOnx3yoV13OwIqwGL7Fg4+s/nQUSAk4yonoNZymwMcwcDOZjzZAiG14Jr3vN1pq66echEv28+u3h9VdlHNqxvXoa8RCDz1T8o1jgZV2HL521HryOIHh024X/C+dQwwaC/ar8hQz62UjGVPr8eKoRxfCEg0xBOSJ8yRcbzfwQiqHwJwCWuBHoRm8ELdshzm52+XEFIecdJXgMN1Qe2v2PXuQCmKqO9VptVXJtdsElU4vXH5CwR0HYExKtL2oAzCuJKR5lA8rcO3tFAOnhCOawtuBUuewFbBJnhedHHOWyjVdJCRl0wEqbgstA2/EqdGE86EneG7kPZ3ggrpU1nbFqabx/QutYN8l9Xl60hx1VGFejgFcya59/0+DjJ4hERJIig75KJXFUtIAbQoJqEqRu4BC6Ph5RNtFZClrK6Si1eZBnkziLFNwsc7QX8GTRfbM3ssV6YZ9Rje4pcZ+c1ErwG6MtS9Fist9Aeusu6yxCCMuCjcWyxIJ2fvevbfNNSobRySmkQbjNvDN53hD9HONeLYNg75TzcNXmIIWU0vUzbZwgfR/NL2WswIOIzM9o68ICPmdDpMXuTXS0AL2SF/jfrmaGuIvMgC02n5s3fEz/Q99KkHRUR4ZUFP3FQuhdgDL+avuoq4SuHYsrLmpkUOgrRu8DfN0i6F8hHaPWlN0fAZvCdvCu6zK19PCWKhYISOJw64yDa+cN3rbzGjChvyrThaYdZ8RUzqCHxV1K0cU/6wNUQYdhUfCVdY fXE56fBE PIwGz34veM+c3RHswLtfBhSM6egLTba0+UKd3zmMbmD+3L5h/Dhfl8eNYhIQZVCpMnpueuoatM/2xMeZYOqJC4zPNLkAKvSWzfZEYQt+ETaraHpJ9nYqOC5CYVYKtqpixOyo5SLSMScnOI7aC9G/dGs8bHC1BNAmJzBtK6h8+B15Yu5sZV+YZ4gWtIi7gm2NdD7xYwXHqqgytqwcK5aeEOTK/guBbUGlDRBHIZ7Wv+2i3XMWGebS0d3Hqco1D17HSelupPwpAI7v2/lzpdBArr7CFRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > +struct bdev_handle *blkdev_get_handle_by_dev(dev_t dev, blk_mode_t mode, > + void *holder, const struct blk_holder_ops *hops) > +{ > + struct bdev_handle *handle = kmalloc(sizeof(struct bdev_handle), > + GFP_KERNEL); > + struct block_device *bdev; > + > + if (!handle) > + return ERR_PTR(-ENOMEM); > + bdev = blkdev_get_by_dev(dev, mode, holder, hops); > + if (IS_ERR(bdev)) > + return ERR_CAST(bdev); Would we be better off with a handle->error (and a NULL return from this function means "we couldn't allocate a handle")? I have no objection to what you've done here, just wondering if it might end up nicer for the users.