From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA72BC0015E for ; Tue, 4 Jul 2023 12:13:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32F1A900018; Tue, 4 Jul 2023 08:13:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DEED90000D; Tue, 4 Jul 2023 08:13:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CE75900018; Tue, 4 Jul 2023 08:13:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0D55E90000D for ; Tue, 4 Jul 2023 08:13:22 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CF98D409FF for ; Tue, 4 Jul 2023 12:13:21 +0000 (UTC) X-FDA: 80973819402.04.7680811 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 0151718001F for ; Tue, 4 Jul 2023 12:13:18 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EuDxWAmY; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688472800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AeT8U3XbrJM+IpxFqUmrW6am26kBs6TNymHmIaQUPXs=; b=1dAmDcf5NO15GijtXZvxYaZ6vBEvb1zC30fC0WnWFy/MZIz2Vgq8nivMFEJ7/u7WqDiDgH c2I76UOhsuAG4odJxuaG9GjUFpI5ppTac6rbXXmqz1p0jH2h23yyC7WWdwY6TVh8eA783W tnqJWz712qXIeg5+av7UknB5nEom+uo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EuDxWAmY; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688472800; a=rsa-sha256; cv=none; b=SZ/3cI1p0/RQq9J3Ab5fpso0lGToR726PVZ84CUQc7sUFhpYeZ0yhT9nZaFs2v7bPA/pid Js9BbaPytq3O4a3mMvsDFvpbhd1/GZiv07Xie+5U61nukdgDU4oLJUSeJNBQmEFcZhlMnv AJPEZiMZDiD+m6vmOeC2uH6qv//yf90= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AeT8U3XbrJM+IpxFqUmrW6am26kBs6TNymHmIaQUPXs=; b=EuDxWAmYbZuisMm6kdnNRQdfAy Bt8Qmglfmqzn0VXmuT15QuhZt/G1PgzwTmcglPZAeydtPV5szhEou1GRXfqfK6BGFk3O71eZHHb+5 eTxipTRjPMlHRR4mEkbZBvZSyJWheBhvfuL6XDUyVpGtzlQdGk6RpGSzpkEwrlEaxY5LTa02vi6aJ dWsGA6XYSy150Km/IaEPXwf6fhsQLh4fHXnCm7kuivoF9wYA6DrRLgOvz4OZxS2KaT2ms3qodApVs luasXECj6+ZxO6QNzioH4IAzEv+st3/YJGcqwCwxZvkQwaHhD+zwUmaGTlJClp942Tvtfnx/inNR4 Wx7TPaPg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qGeuA-0098BO-RB; Tue, 04 Jul 2023 12:13:14 +0000 Date: Tue, 4 Jul 2023 13:13:14 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: page_alloc: avoid false page outside zone error info Message-ID: References: <20230704111823.940331-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704111823.940331-1-linmiaohe@huawei.com> X-Rspamd-Queue-Id: 0151718001F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 6o3bfs1opawt4igkepfthu4foptwcqjj X-HE-Tag: 1688472798-975767 X-HE-Meta: U2FsdGVkX18JE75dIqv0eqto8TiKHwnmJcNqEggnyokD5p7uYkTAtMH71Oke+dTQWPu7nM4P8uQ5iXFOL93SsLcRZ+FCJBpAz3m1vZoAIAp9+mgN/s6Mz3+nHvpoBenwTxSxvFhO0VluCTSLxBDeY2AVQ7tAc6wtesye2PizIIk9X+Fam5ZNq1FXhLrgxieFYwnD2n3be/1uQPvdtybN9YOM9KznjvrNcfRHlJ/2rydH+gv9CQzJsgJw8nrjuFuSc9NSURsCFToCREQlu85XA+rH+x7VwsFKcWffLMR6NKHlYJjJltnWPvJ6hpOuDo/2oz2p9+W4SXBUPYrhwBlT/nTE6fz58veuq7PeJOcz6iglIPEpehtO/UQ61RqELdks9Pj7YwnA/wh4/8bEo6argRjnq08TbKNNntPqvxb5P11KEBNaEj+O1mG/mn2Nbrs9Jo6b4zxsyblx+fVYQV05ri71Af/vxj963KWvKYkRZ/N+lZW3FZJ8YsjmUpMgWqJ9aXrk/nDaT7/Kc0abGtQCSqyms7ecxXJphDQKhYeKDZVL5/5i+Zc+yy82LWNGpKJbcek94ffRwaDVveW5neTODxKt9q93rkDZBQN6DVv+trkzxaldOwBEOIprAfWlTzY9vyewDkoAU06ppmvTmBNSIGb3xV5CtKL1i9sJdzlfMqdVr1bwFshlA6Ct3qMFwiSdaREpE6yd1ED+mCjZeqs9ibieL+D3Z4X7IuSu/rhjpFpCp0CsmnP71CqlZEKWfFccklBmFHQcHvNWLb3GLp36Zad7hSFQInFvJu1AnyHsSE0OIVYmLe8/HvfdKD/m967E2K/BgVoOzjiRzBfYCxr+rAjUPlnpl70rvoUMRcwbRa6AHIRq88yj4vAsDWJiFsLl4ZkSMavpjYChzN6cwBdzqxhMIRs1ptE8sBYfJegRGOvcnNAHIlYdfWA9yslvu0/diU+K+dnHLFNENuBHB7+ knAsH6UQ Kx0EHzLLeUjZexC1ZKR83/YPVt+3Z5lIY6zPUY0vNQ4pEOVyaOykJ/Y4Ih8cdeNR+cppADIxhA47LgDNHMj8CZ1T/E8IEf7MHfY7mh786EEtugwzrVlc6tdgFvaE4O73Nl0PaIJRiyhsQR/sh2RH7WLvIguURDNk92SPqJ1ChLfuCjmStkDG/sj3UMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 04, 2023 at 07:18:23PM +0800, Miaohe Lin wrote: > @@ -470,6 +470,8 @@ static int page_outside_zone_boundaries(struct zone *zone, struct page *page) > sp = zone->spanned_pages; > if (!zone_spans_pfn(zone, pfn)) > ret = 1; > + else > + ret = 0; Surely 'ret = zone_spans_pfn(zone, pfn);' ? Also, did you spot this by inspection or do you have a test-case or bug report? Should this have a Fixes: tag?