From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F5DC001B0 for ; Mon, 3 Jul 2023 23:32:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27B13280045; Mon, 3 Jul 2023 19:32:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22A3228003F; Mon, 3 Jul 2023 19:32:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11A43280045; Mon, 3 Jul 2023 19:32:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0579828003F for ; Mon, 3 Jul 2023 19:32:46 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C9B32C0193 for ; Mon, 3 Jul 2023 23:32:45 +0000 (UTC) X-FDA: 80971902690.22.0D36D4C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 8472714000D for ; Mon, 3 Jul 2023 23:32:43 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=X1jPdpxt; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688427164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T9FI83Ur/A9H8bnhCFZUzb7scpiDs9V+6FiDlWpLnpA=; b=tsE0Iz1e4W+0FA3cf1Vz/FY71UB51a3TS0EBmDlsKBujJ9FI+l7r8iKfUWLfz36OXrvU0e Qc56AYtuufGOL7dZKZ1ZXs4yWRqYAlva9EIpxCruyCc6HV1A97hfRS1fvgaHAw8Bf8T0yi mzQbIeL8mUWf3Rq554ZAtMZRBVTBtng= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=X1jPdpxt; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688427164; a=rsa-sha256; cv=none; b=0anKQ1kQA4hGaLdw6pOFPQpTle38DX/A9k5AUf1cljno0O6wggOVYsrt7DUVO6o1AzGRHC PU+iZONryU9aqEqjQekS+tBSfpz9VdqW9bPqBmlzCHxSnl3tMQReObBm4zVAWixe2pWKyt z9Uqt2IWw3Sa7w/SsNKl7Pii/E+Z/d4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=T9FI83Ur/A9H8bnhCFZUzb7scpiDs9V+6FiDlWpLnpA=; b=X1jPdpxtNWH9nZx7CmSlW42aWa yX3MEthOI1xIgbeiAYE8OL3gE9Z11T16zC5HKFw8zwCWSM6FLHv11kEvMOqOPvflzZDiNDbcPMQvQ n/B7+H6DImjKJv3VPixCyuINvBCDGT8gngjTnpSbpsx2gEtcD3xrOiqkDrx6awZxEaMsumTDlsMM6 1/QVlNzjU+zMPNiJkt3+HkBgOLSGxlTTBrJwUm/L9M+vOwOChFKNiqPsvoRbrvqZRqAQXvr0z6ZqF iNGaBKhjfB7p+LPHPENPg0Op51/0B2p1Wz63c30GJ34AS11Cj1xZazcsN/lAIphZxWVhxmD31Dfgm l1/zIv4Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qGT26-008czC-VB; Mon, 03 Jul 2023 23:32:39 +0000 Date: Tue, 4 Jul 2023 00:32:38 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH 4/4] mm/memory: convert do_read_fault() to use folios Message-ID: References: <20230703055850.227169-1-sidhartha.kumar@oracle.com> <20230703055850.227169-4-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230703055850.227169-4-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: 8472714000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5x8i68c5ntm8g7qhhx8r1u6rmdzf84aq X-HE-Tag: 1688427163-597630 X-HE-Meta: U2FsdGVkX1+ge8tdkfw7dhGGBdFY31hgt204RBxXytqN1unlCXUm+X0iU7DEGpj0XCyewu9C9g/yjHCgcb2ZvfbMqH9L+BPITrYzhzqfXw1ryIG8ZndIdMo1oIUz0AhRq7aT9NOHGnEosep3dN0PbRrXKgOcnITgLjO0lknMUn1CIQPEXGEMoTmlemLqQaFtWbnXHz1xuLV+8caD1f9+16LO0kuG1GwqmhpFF5TUypNglPi3RWuJTSqZ8HDGt4wAZlIc6KlB0QlsHHeC9GDl+/0Is29ezU8HxsKhvTnA1Hs5sL2aGSR/QzNEDtbEodJUW9WsFTvVDLMt3fYSp+QzGlgXkj9S8+eLw/qP91zJWw/MuSYkXg3p+9Nfxux0u0emU+3Z368mG4vfhhzerJf5bo3CXXWtR9/Zru6RpkwDfmhIvG5+cD1NS9ohmCw38ln+bFYsqXHamS5taqBfOWuqMGC2eZ7csSoFi3COqZeKkvNLbdTE8AWinFxHiE+rwow2jKHmD7bbMDJ7sLPzDd7cSq5Uw6j+Pnnxpaso8sZRzo42phrYpDFUdnhPLhKZD8cHK2FYn0tvpkzbZBDzwOzlTNWE4J096OPSwP+pcqmLiTME0y7hklhq0iZh94d2J97xKDC+W8CmSao1eREO/lC995zKWaZPFKBvUkOlfhbnmW4gaEvbfK3BoyBy/l4TpXFfZLjQRPtf6GXZ7V95Dk09k37eWaUkI8luFy6fhvDNmmCAXui4mpLFsEMkwDcMZuVeTwcoYRIbgGzXC/jLvDLKuoWa7ohIGU3U2flgCDHZXn7a6ThDkpQ/Bpwpx6SZGrvtEYyNgirsjz0jRhoztpmomeQeyxXwJPpgrX/IjxmVCfJ/mRlaIa4hWkhpDrCeNwNBSOIhfq8hdApqy6WzWaqtTPG1BXWvfL3mFDpaQKj3+kNAswav7jdSC9Riwm1UE9NsLgZcZwrw0M2r4uGDYF4 ZPskkQB6 9qd9S7hJ5bZu9/xEMq2Cy7OdgGWMaY9rB/fRgHs3RnDSXx+6A4RLggqa/PExGEiCHR5mm/mjDP7j/JH1gNmfxnPCXRnr5yKPdNIo6pdnbtauguExUNR1s4mSiYltC7Gg1OG7EbBFySWgq+ulQfLgb7kNAsYZ/9ZoDSiRnE0ttYn3uV/ksUgKpuLh3qUGLWZbA9TdjUoMt2N4EY8E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 02, 2023 at 10:58:50PM -0700, Sidhartha Kumar wrote: > +++ b/mm/memory.c > @@ -4528,6 +4528,7 @@ static inline bool should_fault_around(struct vm_fault *vmf) > static vm_fault_t do_read_fault(struct vm_fault *vmf) > { > vm_fault_t ret = 0; > + struct folio *folio = page_folio(vmf->page); Similarly, vmf->page is not initialised until after __do_fault().