From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B733C001B0 for ; Mon, 3 Jul 2023 23:31:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EFD3280044; Mon, 3 Jul 2023 19:31:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29FDB28003F; Mon, 3 Jul 2023 19:31:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18E51280044; Mon, 3 Jul 2023 19:31:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 08EB028003F for ; Mon, 3 Jul 2023 19:31:40 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C9AF240344 for ; Mon, 3 Jul 2023 23:31:39 +0000 (UTC) X-FDA: 80971899918.22.16902B1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 23A77A0009 for ; Mon, 3 Jul 2023 23:31:37 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AbmctD4x; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688427098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+FjGWFml8+ZT0b8rY3qqX0B8OTNXfVUrO6Yai+Z1Yn8=; b=IpjhIyMNbPSbzTGZTU3FC/Pot2+NdJmuJWyW08Fd62wyT9xuCaPNr/dJ9yvuDaKdNWoAbx Tn930GxM/jjlsUJ3oIOoFv0GYAzVPeY5asgHSMsi8UAm/y6x9K20pwr4yVvXTQyMLbznDc p4gx7iJwhma/nxWOTC8sz6DQJ+RMFN4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AbmctD4x; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688427098; a=rsa-sha256; cv=none; b=unLUZsgvc7fMdyi8prN7voEU3zam0MDuNJrFcsZEUksH82ePhfZymr2pZFOFLaIqMq7/J5 BXa1CehxNERHJEeMFr1uILlD0wXlJ9AA8w274VjD2+eb2LZgK0ceFpYd6/uaVFoGRBCpQL xrfF1r2FZq603tJSgS0Cowct3UMtUhI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+FjGWFml8+ZT0b8rY3qqX0B8OTNXfVUrO6Yai+Z1Yn8=; b=AbmctD4xXOqgyXpWNyyWMokas1 zQ/NtQhjdsd0UHcuKQanPQJi+PLAWXPLque+QmwOSMsHdA3Dx3+aQSgHI8Pw9jgWf7u1FXnBoxT5w vNXeTJwKrOO1gIZhw+OIWkQl0UvZ4A+jOK9OlXtwhvt+g2h/fzks8XElAfF1t9jLdkTpxu42XNnTs oeKPlqxtoJ8BNH3TnLwohW1PcEx84qVawUxoIEOIaQWkWz8vgKTqm0JcKVYTqyciI/MnYeXIgiIQ7 55BdgqUqjFYVht7/oLq6tJFm7ug77PtnbLJzx1g+JPvExXD0xILCJwHM8EJAS5IkpGNGzSgUVjMAU 6PYAtmzw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qGT12-008cva-Tn; Mon, 03 Jul 2023 23:31:33 +0000 Date: Tue, 4 Jul 2023 00:31:32 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH 3/4] mm/memory: convert do_shared_fault() to folios Message-ID: References: <20230703055850.227169-1-sidhartha.kumar@oracle.com> <20230703055850.227169-3-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230703055850.227169-3-sidhartha.kumar@oracle.com> X-Rspamd-Queue-Id: 23A77A0009 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: te8bjf1yb1oy5fyaoogjt17an5fyn93u X-HE-Tag: 1688427097-342187 X-HE-Meta: U2FsdGVkX19/rNwSiA4pXZZqH/9LKrnt/iO1MaDQI1P7iFEes8OiNFYOs53McWf+zYmRHmCSohiyOTqnMDViUTlqBuyMi/s1mWRNf/R7o3HKk2dqohXTqMetVVmAQ2YsevYtvQenH0JKhigmToqv6BW7uygiIeJM67Q7rtNusjjWxfMk7eQny2p251iddCe2KD3Ky/woz+J8viRjRyhJJ2TGhQ2EqfaUvILXallKenvKXzCzOYjM+Fxarrqt3HXb+FP57RogX6hbuKmyDIelqLk+Ak6MdbsTScZV7UH/POZld9/eagEpoH1mcw6YpmIP1oH93OsqA82GNO22JdooZnyjDYN9P/EKmlUOSdAKHoVIIRIbi3fTXS7fOmuC+JHYlJjmWf3PcB8vRtSuzTygOSofClrUOU8TqsuZqcYtxTDK2wOAOiJtO7zC8Om3kZgzevMAWOstaXWM8FQkp6gAitIpafSbdnVDKsMBmddcgMXlhm4j8rD+cmzwn6Rl27c6onx9FopCRW9Jc+ExEz0FXmxri48UmVAosZgiQvWIrwJvnIqM7g+hCxApa/29w2lu1SoHe5bYrWJ6NMD4Egx4JABnw7TLjM/73MKzjTXX2xCiRs0+NOLqaw83P4OAbtEtgElJkw55akSrlUkW9tluyplc5iT6o1Bz0Kzk2+OAq35R5OHJvRCryVPfBXTRHZMAOoq304/zD06a2vLqA3BD6JzqYpq6kvHdX35gqSrY6kO14fxXsOzGfThSBQSiwpy2bhESv39LGMt8udYW7X+eQNMQsb0kng30TiBeyJU+oS+YJN772++l1q+LYcIYS1Dkz0gyCNyIS7M+XDY2iE88H2JafwkqR1nNFCc8g5lXm7P0kvcQBGOGgdR3EOpkBEsVevukJbUwFdfKcgI5sjXg0HIvzttaczKprxbO/rG+ql2FkdnzVM3m5FXyp3RBko1pakQ21OVp/TGpr6xXWQF HsNSyKj7 +dOm31bK07/JReJOCZsY1MXdG95PXTRHXh+67ONKtDlU1B9YCrrRp8R3FvzolqgeyHIGFKN6bLlRFc5yArZh1piHgzRuToxKj6P6uUgWYo8owBjDJ19BoUr2qnEuOwrkfIwo8fmyap1S57XXHg2cs7FGQdnPYnQmyzEj7LMZPyTIts/FsPcjTd6VbS8VdDoP2B05C6rmfcNqPr6M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 02, 2023 at 10:58:49PM -0700, Sidhartha Kumar wrote: > Saves three implicit calls to compound_head(). > > Signed-off-by: Sidhartha Kumar > --- > mm/memory.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 93480e846ace6..33bf13431974c 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4594,6 +4594,7 @@ static vm_fault_t do_shared_fault(struct vm_fault *vmf) > { > struct vm_area_struct *vma = vmf->vma; > vm_fault_t ret, tmp; > + struct folio *folio = page_folio(vmf->page); You can't call page_folio() until after __do_fault(). Did you test this series? > ret = __do_fault(vmf); > if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY)))