From: Matthew Wilcox <willy@infradead.org>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 3/4] mm/memory: convert do_shared_fault() to folios
Date: Tue, 4 Jul 2023 00:31:32 +0100 [thread overview]
Message-ID: <ZKNaVJCDH7ac8SCu@casper.infradead.org> (raw)
In-Reply-To: <20230703055850.227169-3-sidhartha.kumar@oracle.com>
On Sun, Jul 02, 2023 at 10:58:49PM -0700, Sidhartha Kumar wrote:
> Saves three implicit calls to compound_head().
>
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
> mm/memory.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index 93480e846ace6..33bf13431974c 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -4594,6 +4594,7 @@ static vm_fault_t do_shared_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> vm_fault_t ret, tmp;
> + struct folio *folio = page_folio(vmf->page);
You can't call page_folio() until after __do_fault(). Did you test this
series?
> ret = __do_fault(vmf);
> if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY)))
next prev parent reply other threads:[~2023-07-03 23:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 5:58 [PATCH 1/4] mm/memory: convert do_page_mkwrite() to use folios Sidhartha Kumar
2023-07-03 5:58 ` [PATCH 2/4] mm/memory: convert wp_page_shared() " Sidhartha Kumar
2023-07-03 9:29 ` zhangpeng (AS)
2023-07-03 23:29 ` Matthew Wilcox
2023-07-03 5:58 ` [PATCH 3/4] mm/memory: convert do_shared_fault() to folios Sidhartha Kumar
2023-07-03 9:29 ` zhangpeng (AS)
2023-07-03 22:05 ` SeongJae Park
2023-07-04 2:25 ` Sidhartha Kumar
2023-07-03 23:31 ` Matthew Wilcox [this message]
2023-07-04 2:18 ` Sidhartha Kumar
2023-07-03 5:58 ` [PATCH 4/4] mm/memory: convert do_read_fault() to use folios Sidhartha Kumar
2023-07-03 9:29 ` zhangpeng (AS)
2023-07-03 23:32 ` Matthew Wilcox
2023-07-03 9:29 ` [PATCH 1/4] mm/memory: convert do_page_mkwrite() " zhangpeng (AS)
2023-07-03 23:25 ` Matthew Wilcox
2023-07-04 19:35 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKNaVJCDH7ac8SCu@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sidhartha.kumar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox