From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABFE9C001B0 for ; Mon, 3 Jul 2023 23:29:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16997280043; Mon, 3 Jul 2023 19:29:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11A0F28003F; Mon, 3 Jul 2023 19:29:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00841280043; Mon, 3 Jul 2023 19:29:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E58EE28003F for ; Mon, 3 Jul 2023 19:29:37 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B92CF140324 for ; Mon, 3 Jul 2023 23:29:37 +0000 (UTC) X-FDA: 80971894794.16.45FAFE6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id AB21E40023 for ; Mon, 3 Jul 2023 23:29:35 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XAhAkYYN; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688426976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wt4a8RXJ2JiYk/Pl31BqCi5HFHSZASXBHI2soh1Xmv0=; b=ABnPYW9EwHem1q+xBsLPq4hTCbkNMef13eaarTtGQocGnHX/kpKlf+8QdVJ/wbPbUTPP7F zY5Psfoges1nL6Fs7+E6I67oyZ5+klaJahZBCYCGvJZQTny5q5CkVci+/3aK0pcJ+xnP6G iqPksCoCB0ht5rjd5NaFSjc0fPieYpo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XAhAkYYN; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688426976; a=rsa-sha256; cv=none; b=Fl0z3ETpPjx3nDVxerEUvdf4OCHRodypyYtING0zeOAxamcndY2/dA3hXx/PH3TIfPILiP By/0aZ4SMR1BpZ58SxRR+xWNs288dtn/mBSeipCnITqPHxKCmzMwUrTwQGYvcI/3QAayHg NVQvM9hw1ofVk50mZE12oO6fQamtM2g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wt4a8RXJ2JiYk/Pl31BqCi5HFHSZASXBHI2soh1Xmv0=; b=XAhAkYYNNjRvruE1yDRVPXBErg 9BfU/bc6Ntz02LFkbsWOLfgjNfbHcn9/v+A/9LWu++OCVgLTgSF8GM13v/uzY8Ibuf920n8vuWxhm TgngC213z5oB/3QepAl4a4xmzKTbSHvaoJSOnjW2j7+1wWCQauo/TZ9KB4A7YUd4TpQbQo4qgq1Na 6l7cnzBAO0TCYt6Lywaa+noX1sGZLeirees01YEM9S6CFhBmkR6ZA1LxG/cBRMSZCF63Q2MYHfAfW gEutZAM/qjUNNP0D8wwxUhavZ7gALUekQGwL4FrNOojTLrKk6MigFerLpYYBoOskd6C+3o/CMUR0j a4piZS3Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qGSz4-008crP-Ki; Mon, 03 Jul 2023 23:29:30 +0000 Date: Tue, 4 Jul 2023 00:29:30 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH 2/4] mm/memory: convert wp_page_shared() to use folios Message-ID: References: <20230703055850.227169-1-sidhartha.kumar@oracle.com> <20230703055850.227169-2-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230703055850.227169-2-sidhartha.kumar@oracle.com> X-Rspam-User: X-Stat-Signature: 7z6k65nzoymi6dc6sap3itdwhuqzcb35 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AB21E40023 X-HE-Tag: 1688426975-787260 X-HE-Meta: U2FsdGVkX18BEDAvs2ad/VYZOQkVgWRodjBQ5wzwS1Izleldp3+byVc1LFiWZAG4Zs7ai11DW4/JyC7Lj9bv91ITnGZkFsfg61cQjQehOgg4hxoxwAsyB20Z5GIX6fVehZoEQmnfJjDQZB6ooW3t/y+/nbhlnctDr/IzLWdxepGChPaD2H2Mpm+VzjnH3U6v2o9NA5N9H4C/ZeN03qgoXH0qjhbAW/lh1JYl6QYgvdbTJKLFkkbPnlMWL8upDWid3oVzUhLCG25y6Bz8/OZXKUdRgyQfmX+pd6WY97rsg3Pv02FwgGG0U2d/NT5pwSVFR1WpGGWS9YeYav3KYehXITybvJCuF++bb2fqnzCNGUrhvUPXLQIE/9J8xAOzJRdMO5kov/TbN3oKJ8TPbkVyZ4BwfXYG7eGUt8CPREZcrcKt5EEBJLpZOz2wX/ti2MoUrJq/qXxSDD2aHHbJjMb1blQmlsaR5diK4EXvOoCDzQg9YGGkn5E5yzHnZmL/HBu7EuNT2HHlIxcNq0eTz1GTC2cO5HYTqGKlWx4CFaJgutWwnq6C6HkQkVYjLS3848aDKPOXD2mTuodv8E5HBbUKqzYjRQgFhSHIwiQ+gUpAxmd9MMyIJe4ZssKSQHWASEkzplpJKRAIwpE3uU6uFbfUUdEDo8WLZVi5SgkUTuKx8hzhfX3wE4hmcULMjl49/oeunqSvfHufoMDIqa1/Z5EdsF1oMc+bA7zEEzvTcGrycgyP0i9+HXsORWrKjmQIUrYcX/NWtUHF47nL+dIu/18o0l+SAmXEI7OYbgyZW0K7eOtMYvBXJM4Kk3gMactYIWBP8bIkHIjznQVIErJh1d3D3jJ/feXQxGXcjmojI+aP4OewkLAS9jmVU1qz9EzB+tNBJWIKVDI387+7kQf51dtM880cr+pPb3pkH2347hAzXGKAdI2pmG6x1FrdlaZhBicwILhQszPVNmVX/quqKXk 7P+UaD54 bumvcHYRKPD4e+GvN2pzdpgfttId3NxAB2Mxm9OK7EUJn8CmT5TI0y7RO0/s+3uSETsHDHXHiPrQ05q+fE0+FX9uxhjxftTchaDySTMXnIhmJTQnMkaPh0KksrpAFa5xvKNl+/rB5Ez3TXUjpGJFgjMG8oMwoDF/2PpZh3kuuMB+zZinQIOXm+rqxDxRtm6ahrKexG7DQFCAAcy0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 02, 2023 at 10:58:48PM -0700, Sidhartha Kumar wrote: > @@ -3296,21 +3297,21 @@ static vm_fault_t wp_page_shared(struct vm_fault *vmf) > tmp = do_page_mkwrite(vmf); A nice improvement to make after the series might be to pass (vmf, folio) to save even more calls to compound_head().