From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E452C001B1 for ; Mon, 3 Jul 2023 21:37:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB79E280030; Mon, 3 Jul 2023 17:37:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C67D56B0088; Mon, 3 Jul 2023 17:37:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3020280030; Mon, 3 Jul 2023 17:37:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A39436B0087 for ; Mon, 3 Jul 2023 17:37:25 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6E24A1203F2 for ; Mon, 3 Jul 2023 21:37:25 +0000 (UTC) X-FDA: 80971612050.25.EFEB1C5 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf26.hostedemail.com (Postfix) with ESMTP id C6B9B14000E for ; Mon, 3 Jul 2023 21:37:22 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=kUFS60rs; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf26.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688420243; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J1yYukfh+CgT+RxPOIniYqFZ33Swz4P1lYS5Scmtogs=; b=BaybE66612VfqXprANZ614KawQLl9vUW/s8YxYP5C2r9oqqYDhng2ZjgTulMTvXOMKn+UT fBO/2cIZ9HsHkMwHmAHZPmtIhi846eylmLTZynEhQH3NuYtvrM6OpQnq8Rd9HlwGUsMiXY SEO2Gq46ivMqVzwLDBmZeUQHHSPlzbU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=kUFS60rs; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf26.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688420243; a=rsa-sha256; cv=none; b=YWyZvspDL7Otgg+gA4ArxefEDWaQSJowfBFpyKVhydB93lTOD+Igr6V4u9hJ8aB9JgVRIG 0fwGRUF2kBgKY1qUbwO2HCdtOA66k4d7fUrskdjm6pWcaTpzU1ejfp+ZJWupF9kHpEniSI DM7N3i/ulNBKKQhQZe5dkBdP4WfGnzE= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-666e6541c98so3990256b3a.2 for ; Mon, 03 Jul 2023 14:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1688420242; x=1691012242; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J1yYukfh+CgT+RxPOIniYqFZ33Swz4P1lYS5Scmtogs=; b=kUFS60rsh5WTEJERHjyUxocc9x8/sIb0CCEV3Mb397K4x8Oa5rJfvHeRaT59GJ0QpL 5LFiAax33DKQsKW3rHL0a4YHnP+W5Bx7R5hGDP1M4IM0wn+19ykFk5aFaIOxWRS1p7Fw fvLEi3h3wqNQRxlsgiEGgaV5iN611wanRHq7TcYir4Z4QN3RazbqII3Fnz+k0bIZLwvg T7NQS1C1OvVCLdFKoTRef3NWUz4r1+0J8I9K2BCffZQfbzciAoeT9YokSwMCELO2KG1k XHxH9zo1CXpklV0U+L/d8YLbgX4AvdEeaSsZ1M38ObzyJjWALai0/EjO/jRlUd+7l+oA b96w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688420242; x=1691012242; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J1yYukfh+CgT+RxPOIniYqFZ33Swz4P1lYS5Scmtogs=; b=aNFu3St5pVVcbogxEL1BFJCO2XIXo7J7v1822MKw9R1qa771qB4jjHH5LqTaVA9JTK Jo4IxxfZuqBVKSwLoMYReETETxgWXzW6IzEy0MfYU7JaBaWBVsw4kO02gpCUFOHrHc6W M10PF52n4M8s14fHHpTGDacgjgywPOV14CUvmke3LCjvHvBivJQILwK+t6vVsaczvc7X 520FXvnfZ2tOKmKdanaP4s3QxXRz28JEdK1kl7JGo2OnNx+fdmIUhKnt8TFCu52embZn JMjeve3xSY6Dcggqn/Ojn+Bo+2X5R7XVK2+sK9kcBj4EfVPwuTxfoheK8rfOKwYbl+kk M2vQ== X-Gm-Message-State: ABy/qLaOQ2KJFf5BBkHX3E+3LNDif1M1h+FY6Jp5JmoPxaeUiiLYspsP QCXtQ0YCtuPD2QrJLkJFG/iLLg== X-Google-Smtp-Source: APBJJlG8cAJr0dpzAku3LWshZd9EoTaSBaJgZu/e4IEXhV2kYUK6+we/zvcjNSf+3BBEFenCLDMxag== X-Received: by 2002:a05:6a00:14ce:b0:67f:1d30:9e51 with SMTP id w14-20020a056a0014ce00b0067f1d309e51mr15869878pfu.33.1688420242210; Mon, 03 Jul 2023 14:37:22 -0700 (PDT) Received: from dread.disaster.area (pa49-186-53-194.pa.vic.optusnet.com.au. [49.186.53.194]) by smtp.gmail.com with ESMTPSA id r9-20020a63ec49000000b0050a0227a4bcsm15393528pgj.57.2023.07.03.14.37.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 14:37:21 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qGRET-001lTl-2i; Tue, 04 Jul 2023 07:37:17 +1000 Date: Tue, 4 Jul 2023 07:37:17 +1000 From: Dave Chinner To: Matthew Wilcox Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jan Kara , Christoph Hellwig Subject: Re: [PATCH] writeback: Account the number of pages written back Message-ID: References: <20230628185548.981888-1-willy@infradead.org> <20230702130615.b72616d7f03b3ab4f6fc8dab@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: 74h1yed3z5mfoa8xaedoj9jimxak7m1e X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C6B9B14000E X-HE-Tag: 1688420242-295984 X-HE-Meta: U2FsdGVkX1+xR5xX5EJDK0u71cJyjgZquqVo6BRI4eqP1uyHuzBKxmWCi2bMGg//HRD1idHFa/DeAIU8Rl8uLWegXI8Z5C8Ccn4Yx9meAE90q318xbSHS4Patz+NlNrIegPkZwWhvW39x8nTJMOwrGsta4cm8eVfHNpZrxsT8ABWE/NSED/HdObQEwlDgHOatZ+MoGkCW+SL8SzDlS03Z/Pw0m75aO6aJ+1kxERcZ81GBKtFvxqamwwAthEsttxX/nYuOLc++HHyljfOgyLhKOcOZFQtxM16FjnaybmxhpUInSGP53nN4kC9kgYiFbS0PErWWRB7mMCxp2lN6jyyaYpqSSmUmogcYmgWR4mM2XGLGnznH3CuvFu/kvx0mBLK3qy1zDerGxGK5s2Rh/49QiTelhBaXRIBEm6JkDrP2Vo2efl/4BeJnHGGKnE1TNf64sNdWbDtgaUajZ1gzUALfXQTbL9gWPC02b4fNU7NEexilk1xNazJCynQuj5Jm/51Ge1+veWKOY502FK5OiA430EFWn0Mlby2nebEl4ZaJ3pFlM2Ar08vraN2Y8mj3u32RnZTggtpX5z6LOJR8bnkJr2nR0krcMQS+aJTzJ1w9IZCPIPA/25QTt/4/NoaEkEE+bgPess/IMwev3FRH0V0WdBGBA5XBHnFuy9+q6ZtA+InVnIG+i2ixvmflhKBYLqFvhvT3JOGjJyh4TFd4wJhFKIB2HtcJ610FOej032Hzf47IjoUkEjlIjstO7EM+YDXRG2Lm6V5GPtN8XOu8XTqPGEXQfKTDdO9BQ2sVsjnIuSOMEV4RISCR3q/OuDsPHSHBoUar3HDE2j3zT1d89RieNmHaaGzdRtPR8hCInwIrbvYxxzDG/9M7QfnLbpWrGeGcSqkejV5EMdJRJrraXs7a3im64NzKrxVcF91LnWZbPo5N/a52uwOTTwRqNDPSXPE1wRFBLqLGeU8CJ2M2CZ ArgJ/MoB XHl5ahjfmSBohlLkDn0sC80A4vN32fzEQVLeoYKr9P5BR2dh74DmHrrzPIGM/huzq6dOe7KVJfT0JLl34R02ATS7vw/vP498zJdVN9fI4j1agFBS/HYP0PpDRZNYnVQ3Jlk9mSLc0w8AT8qCAJEqHFLHq7QgCwP2nN8vmFOXISiSOTlABB3ylbt8U9Bpd/8mta98xe1dSz1LRuj+7Lt56MOZzTU4Dnmck11GSA2rg4XLXaxp95BaZ0hkbW3tcqYJ3a42ZP/xN2imEl2/DgcS/vodqAJP6S0v/ODVcnCDaNyJlefvpCCm4+uGj5GLhU0rWaXUU2HWI4/lTp5yawzHonzfe/w6JL6ikHKFPjdKDC6ziEUI9v9GwKCn54I8D/6PE2YfZZPHHFmrbf138pc5YTeL0XR8w/3EcYXA/ZkVWmScSoTurPUpmCVqOgBURAAhZSq24X8P6pRfCRHohbpsEFsOR/44Sh9qnzVzLNJk1osZEY9sE/E4nk92j+GQ4MSjlcoUQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 03, 2023 at 03:13:15AM +0100, Matthew Wilcox wrote: > On Sun, Jul 02, 2023 at 01:06:15PM -0700, Andrew Morton wrote: > > On Wed, 28 Jun 2023 19:55:48 +0100 "Matthew Wilcox (Oracle)" wrote: > > > > > nr_to_write is a count of pages, so we need to decrease it by the number > > > of pages in the folio we just wrote, not by 1. Most callers specify > > > either LONG_MAX or 1, so are unaffected, but writeback_sb_inodes() > > > might end up writing 512x as many pages as it asked for. > > > > 512 is a big number, Should we backport this? > > I'm really not sure. Maybe? I'm hoping one of the bots comes up with a > meaningful performance change as a result of this patch and we find out. XFS is the only filesystem this would affect, right? AFAIA, nothing else enables large folios and uses writeback through write_cache_pages() at this point... In which case, I'd be surprised if much difference, if any, gets noticed by anyone. -Dave. -- Dave Chinner david@fromorbit.com