From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB3DEB64DC for ; Mon, 3 Jul 2023 10:51:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EDC26B011F; Mon, 3 Jul 2023 06:51:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 876966B0121; Mon, 3 Jul 2023 06:51:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 717B68E00BA; Mon, 3 Jul 2023 06:51:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5B26B6B011F for ; Mon, 3 Jul 2023 06:51:08 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 357501601B6 for ; Mon, 3 Jul 2023 10:51:08 +0000 (UTC) X-FDA: 80969983416.12.B0DC9FA Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf23.hostedemail.com (Postfix) with ESMTP id 0CE4914000C for ; Mon, 3 Jul 2023 10:51:04 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=htHZX9Cd; spf=none (imf23.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688381465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dcEfFuaLU8WuZ734FC2zjBdbWqPM0/tL5GbnbkXmB5c=; b=y5aJaP44xU/jmW0g8LERB3v2BNYvR/OzEI0OE5vQ0TMlQvJu6zcjrN+VYqCA3ccuKuDojr tUU8JvoUp00Mu5ubo31HnFkpNE5e5yLg8ErIvRdjXLa+HVsuxKVC2+w+oPDr69MoEqSZo8 m2WX0m5s/K+F56wSGEDJR2Y/5/q+m14= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688381465; a=rsa-sha256; cv=none; b=xIpENPw+kXSAuc2urQKaRNQxernW5jSYo6M7mh0jgl5pt8sD5GFi1OD0ooCCZDqKIXQ0mn mDot84uHrNeLB3C7vveEC2iy70vweFwz3VyLLFa4T3q/XPEiEzd31nPCkPgOEklH8wbUcr 5FNdnh2vSHoLu1haGqGb3vKxENgzxrw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=htHZX9Cd; spf=none (imf23.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688381465; x=1719917465; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BadCQA6HO8laQVNoZwiU3/nTxzC9qflmlgQcwaZtETA=; b=htHZX9CdxglCG+ZrP0xBCzmQocaBEJSQM0F+XZ46j7EzNArC5puLW8hr A4cxU70zqPiu4REy06PqzLl25xjNx1tetk89C3hr4zITj3+xUFaW9j2Os Y15K8wR2Hj70Am+KpG9/gK9yZsAa3DLJOG/0ZeaGglF57/b87ecc83Vxj RrX+P69uU7VLWH3W1vURGOnGoTHHbejITZ5hctJpFseE2A06iqOUeucYR /o9NUGc7zOL3vhUc8O+w+/gRbPD5VebCcCwwX5dZxZgwt7FBXwN4r8dI3 bpchyZZJ+zRv+oKdJr5QFwUbfkD6T1g7ab6fzdZBRaY3cyim1tNVh+OJz A==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="366335265" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="366335265" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 03:51:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="808529347" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="808529347" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 03 Jul 2023 03:51:00 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qGH90-001qCc-2e; Mon, 03 Jul 2023 13:50:58 +0300 Date: Mon, 3 Jul 2023 13:50:58 +0300 From: Andy Shevchenko To: Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino Subject: Re: [PATCH v1 1/1] kasan: Replace strreplace() with strchrnul() Message-ID: References: <20230628153342.53406-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230628153342.53406-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: 0CE4914000C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: mia3555xc4b3de1spiakgpc615scgk45 X-HE-Tag: 1688381464-176470 X-HE-Meta: U2FsdGVkX1/YXoSYx+PLeUngBugXFnvvvHxtVU6XJ8kdxpF5sjgsWvqYJEIqqFjcfx2DT/2XgocXqLusf5UtOFum3it16U50+oA9cubR4zBcDVLaofz1+Lia4OB7OoQFvfpYNh1uwiCHEyhy5b2QXLawdvJ69YFcer/nBs1iIu85hqF5Tm0u+rcCj7C5jkVaYo/8TnCv84dWTKK5xXQUiPjDrfaT2+JjrbPJAsnRMwwPADJyeIZtK7pPTIKQW8NFXwIICIZZVpeoJae4Dv+KFx+sVpzjDQhJux0cfTtY6CYT4PEhpw8qbdyqCQaTIveL/B8VKUBUSsLGtcpzy5//hjvKQiHYk2UIPGwUYEfl3DZLMBAwxVK4xSF0WYtkYbYJHjZ6EwjRZVprYBg6gy/DCekOpkDQxt9HC4POgIbRfPxWEucUZ+vOeLPhQk/KZhUUIudQA282K1OD4hubAnXUyjvPVNuP8rdHkHv4bX+urGqaNLDpju6QHogHaPu2CLjfoiuaX33f0ray4l/2JzMoFfDrQAHno3bRSQJxR6aAPBV1lsoWbatSmplxT9l0c+aU4u3VUQZBA4AK05HdOSVfDGsyldXfGtM8aecoMosXQEaDig0allo9LOMCQ9NdDcDcaXtFFyyCcuLo1G5CeMyqDKc57wMLTPsb8aD8oZBq+uuDQghyK3bGE4j73iQSg4cu9lHIurzjba11NHiZDHqHSroGKzIRhf0tzCpP9m1cefVPHVfAVFet4FByVXdqCMX6i4ck/i68exmrKN8TI6Cy8DGidrrJYy/iZ9HdQD1KqyWrMgkOYuSqLsGBB4t2L5hVIjJp651nnMk16U6aOROjm7oLaeTpzku8bjKrXruZGBi6V22v6zetSaikv4Lfp9SY1r26aaU0KQeKoK6qCXHxf7ZkmpaNhcJpXqxlYsO/rRV8+rNVZX7zaf0AfAKmg4TAod09cH4HuxYLTucg2tu k454/lOB i+kTzmCM6jCV7h0aUz+ZBVz8rdTqVES9skZGbwrPNbFVfrovteu++LWhfRhAvEIxgLn4Fi20HuYqb3GszQ1xUhmhLrBtnIJenWKNa4vsqxiP+9h2NMYaZGiV8HcnIjUrBgGyy0XOSDbJobr3R3QL8m/IafDFOjIpVSeb8gMjRBzD/Fq4i5JQCWRh4pln7bOlPXm6xkpE6pIvJZfMk8dhkceWwvECD/tBGb49eQJ5HZsVjwtw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 28, 2023 at 06:33:42PM +0300, Andy Shevchenko wrote: > We don't need to traverse over the entire string and replace > occurrences of a character with '\0'. The first match will > suffice. Hence, replace strreplace() with strchrnul(). Not that it's a hot path, the bloat-o-meter shows +6 bytes on x86_64, the change seems has no added value, self-rejected. -- With Best Regards, Andy Shevchenko