From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 0/6] btrfs: preparation patches for the incoming metadata folio conversion
Date: Wed, 12 Jul 2023 09:41:38 -0700 [thread overview]
Message-ID: <ZK7XwgBJZDpWFuz6@infradead.org> (raw)
In-Reply-To: <cover.1689143654.git.wqu@suse.com>
On Wed, Jul 12, 2023 at 02:37:40PM +0800, Qu Wenruo wrote:
> One of the biggest problem for metadata folio conversion is, we still
> need the current page based solution (or folios with order 0) as a
> fallback solution when we can not get a high order folio.
Do we? btrfs by default uses a 16k nodesize (order 2 on x86), with
a maximum of 64k (order 4). IIRC we should be able to get them pretty
reliably.
If not the best thning is to just a virtually contigous allocation as
fallback, i.e. use vm_map_ram. That's what XFS uses in it's buffer
cache, and it already did so before it stopped to use page cache to
back it's buffer cache, something I plan to do for the btrfs buffer
cache as well, as the page cache algorithms tend to not work very
well for buffer based metadata, never mind that there is an incredible
amount of complex code just working around the interactions.
next parent reply other threads:[~2023-07-12 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1689143654.git.wqu@suse.com>
2023-07-12 16:41 ` Christoph Hellwig [this message]
2023-07-12 23:58 ` Qu Wenruo
2023-07-13 11:16 ` Christoph Hellwig
2023-07-13 11:26 ` David Sterba
2023-07-13 11:41 ` Qu Wenruo
2023-07-13 11:49 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK7XwgBJZDpWFuz6@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox