From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2232EB64DD for ; Tue, 11 Jul 2023 23:56:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3917B6B0071; Tue, 11 Jul 2023 19:56:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31A796B0072; Tue, 11 Jul 2023 19:56:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1944B6B0075; Tue, 11 Jul 2023 19:56:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0398E6B0071 for ; Tue, 11 Jul 2023 19:56:28 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C79BE4033E for ; Tue, 11 Jul 2023 23:56:27 +0000 (UTC) X-FDA: 81000992814.29.4EB263B Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) by imf05.hostedemail.com (Postfix) with ESMTP id DD9B610001B for ; Tue, 11 Jul 2023 23:56:25 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=YDA0+k4e; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf05.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.161.49 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689119785; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uaP4uEuwIxoNjbBFQL5oSKAu3BHI+fxYRkHyv6/2Bfo=; b=0uQjN1hsaddMAwEXw26gF/CnYUNwM0nqwYbu6FMeGyH1PM/xOvRG417hwUuOzPfADMZPyd s/SuT91O7RMgYpJjjSnbjQMbJqEB62NRPgGOEyywHGv5EL5SHt9LkaIWFQQA1RgxfSX4fX q3U1/t9RR88I1Zs6guxK3wtjNDwqysg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=YDA0+k4e; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf05.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.161.49 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689119785; a=rsa-sha256; cv=none; b=MiK9mmfFQ9pz6Iem4uuC2J4XbhJvvtYwZWhDgV2l3iMAhYbnyedcW7Cg7uDaFLQu5vDGqW WD/7rCmGmqw00TBollrCe/JacW6Gx/d5cts8dmxjyHmKikzOCr1J7G5utdElP5jH/2l3Rm EFQcVSSkQVDJ9RMK1v9NbKnAPhCrLB4= Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5634db21a58so4853339eaf.0 for ; Tue, 11 Jul 2023 16:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689119785; x=1691711785; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=uaP4uEuwIxoNjbBFQL5oSKAu3BHI+fxYRkHyv6/2Bfo=; b=YDA0+k4eS70pAdIupGhryy188baUtDth4M5FLJLK5eJySoAfVTAfRJbXAGYrjg5NnV jKgwHzJH15IDmnLqDng8r32eyOIkKRpKvX3NDTvqoBQfXiM0CpCmvHRFKyrY62znIfMW o/F3e1iaCLkkUgTFsbBuqNS1cIRPMYfE+dCALLrhR09HGQyo1M9w1Q9uFEKo12ci9ke+ 2dj4xCKLtrbRMZZlr7AzeFCinJHNuFHONNbU3qiasQuYPhqGSscnv+kf96wF9WwZvWz7 TiFfazl1YC70bDAbY6/+AQvL5NpjT0sBgLXB3hnPLwH/oc1B0M50wd4PTo22sDFgKQx0 HSOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689119785; x=1691711785; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uaP4uEuwIxoNjbBFQL5oSKAu3BHI+fxYRkHyv6/2Bfo=; b=WA6nzt3rj1hBYkVod7Taf90yEcd629viALMk21k20Wpubej+aKhRYpa1Nd+50iECEv PsCdOeI7A69ZUQPkXPVAd7rz8FQ60CbZxFwTsWksCn3EdqCgYYNfsjOUVPcYNGrD5ift 4TJmronSqCSgjFMqC6NqfO7Wtaz2P+y6hxTZ4IK8kCcnA/gXX89B3ut/Yc6C8PzKSFOe HlnVer5q1vEbJvc9ko9cC7gtf3ywQCS7FOoTGpz8BiMXbuXPl/KHPrywDEO4Zg2y15Rt q5Vrx/uHPAyStcZ/SX0H90gRwwkGoQE5ZSb/eObnkyatmDpdE3l6SGwvAeitjSGK8kQ/ FHSQ== X-Gm-Message-State: ABy/qLb09dJJaWmQBalEm4qnCNnyyucV8DnfPvBR/94EleIWXGlqDLe9 Sl66M8GLsxvan+IXybMC/xQ= X-Google-Smtp-Source: APBJJlGm7Bv13T78GdrZdhOtoXkTnwLArzpkNPqp34b6fKDij/c+AKrhGrCm9fti80rb6kzBOAxeWg== X-Received: by 2002:a05:6358:91a9:b0:135:499a:382b with SMTP id j41-20020a05635891a900b00135499a382bmr15338903rwa.7.1689119784840; Tue, 11 Jul 2023 16:56:24 -0700 (PDT) Received: from google.com ([2620:15c:211:201:97d7:e05c:68e1:2c6a]) by smtp.gmail.com with ESMTPSA id bc1-20020a170902930100b001b3fb2f0296sm2500442plb.120.2023.07.11.16.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 16:56:23 -0700 (PDT) Date: Tue, 11 Jul 2023 16:56:21 -0700 From: Minchan Kim To: Nhat Pham Cc: Christoph Hellwig , Andrew Morton , linux-mm , Jens Axboe , Konrad Rzeszutek Wilk , Seth Jennings , Sergey Senozhatsky Subject: Re: [PATCH 0/3] zram: use frontswap for zram swap usecase Message-ID: References: <20230710221659.2473460-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: DD9B610001B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: q9m1stjh117qtsoc8sn85fgb4geeuce1 X-HE-Tag: 1689119785-543963 X-HE-Meta: U2FsdGVkX1+uHd4sH/jG0eBD5lf95zt9yON9N+Zcg3ayR+5uwZingWUb+MIxViPQlTmqEsst9/8m/mdR/l2F02r8UwVYr0FDxAdyqpnru2Fbejf6rERUl5QygztxyPIF2gXpqiuZ+UF2WIVa/D70eO8tTBCHay+VzRbLroY0kRdkfszD0XWdAzv0yi+DIbwO0tQ0+3nFfHTQUWv/DkJeRmra4RiYhP18WJUK+DJ9daAOES9HISVqejjjEKY0QifE6bL+r+LzjkGVlG8dhN8F2qs6IXt7yWBIzL+xQXGbgcxIhg3lxsGyzh5Id8r1gWfuq8pt6rnynx+HbHBfrMfvnuzrDgTsLSERK5+aR1lDb49Ej4EQiQcuK8YKVT6GA5QnCuTzxEmhRCB5VYZy16JhU83faf/lhA8j/Irs3+ucMldwMDFSkBz1wHkDAHqhHO0Kzxsi4eTCaNPkY1jRupjDm54M0va/rWEUJCof5nRok2/Rkhqkgti22l0AfzRyP1KPyqsITlD4BJ++isoeliYgDjCj9XCHWOkKePaND4/EmJ0Yp8MJIlvUBMLjRl9HLe4J++oxEYVZPEyFVRm2D5t5Xif5alfSvUfjRAFxnj3kIQV5BreSYGYoNnpAqZKmUlXUmo/AmYXOjk1KMc4Hzkrw4uHWHrQ/Q3uD5RFAYgDzVxdpbzLIlwXcrRvZLlCildWu6KT3mLybM+9ASX4fBzof0LdU/OjHCjpCu+NJbTqBgoYkGRL/d3uk1xuwrarp/FeoVHaWGh9vgoXTxdUpRVfsqsyBLGNjTGh3c/asXpEDOE+D4B7rxILptNwQjwztdvEepu4gU4C2OLipaCOEo2cDMv5TbD+AYJnn3jWCTzhVZJdPIrGDLsy4RP+goQTwdPfKXc9N4ucDa8om5qKmRtktpyNMeOlxKdQ9oWP1tHXVo+V4gY9+DaMX5upzQUH+7+yiVCNmjeD3FARLzJGtZ1E DpAJlji3 3VA4K1BKCwml4SdgIVJs9FvWrbFzxgq6isg9WoN3WPFLg6JtgBOv5dioB6uLWc/Hbuwynmz3COO5yVVMlPj15r9m6G+6SChXblj6V35PfSLcF6+Oas5MJOHLZnhXAQjwCnpLt9mNbZS5ahkDFXMRSZImbpujGqpfuo1ycGxVzJvQmizqK+wgRusKSFdrjAeSWNE7KJITyJJpms8ESEjW1LM3wnXrmdDlxkizjPxUM56vkQdiy8azJrNv6FW/HxnN8B4K+j7CReeQJRZiPrBIMRQJCeQ3PtdOFLN5ezkKj2zWm+u0U8YEDg9eNbeI2d6Qhu9JMo54T9VbK6BdYxu9eOsJUZDwbdVBFRNuZqvFhTc31KQSD6JPUBufuPcoh9ges5Z6l3kPEEc7KbVFY+ZEJWXHRjnmRWHjNT76z/eFVPo7GW+2pVibM/LB3A0cKzlAw2JKNz0e9ZjNd2EjoOUXrh6ZXDrO6yLzFchmZWQgWwOZj61P0/DVPHf/Q9yt4E8IWtgDGjhDuzXv5w4LRIPaDPATJzpDQZWV5cGoAlAKmgpkMDsWd+Tx2TDrN27ph8jgwWUX1iPClkoCN79NJjHzZ2lq8v3uGMmW5ZLPy9UQjhvWuNN1SzoWgEyPWGbujNt4kIAEBtWMixAQlcbAESFySp4sxeVSKElim38zhlxYfjy9jBVyuVEkRxQy1BoiwBMIseJoG4T0B95wXzhZqMrNyX3gOztPI8V9mg6LjBUWx0UWmm6Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 11, 2023 at 10:52:02AM -0700, Nhat Pham wrote: > On Mon, Jul 10, 2023 at 10:18 PM Christoph Hellwig wrote: > > > > On Mon, Jul 10, 2023 at 03:16:56PM -0700, Minchan Kim wrote: > > > This patchset uses frontswap for zram swap usecase and remove > > > swap_slot_free_notify swap specific operation in block device. > > > It shows 13% swapout improvement for MADV_PAGEOUT. > > > > Err, no. frontswap needs to go away, and not be tried to a block > > driver. If you want compressed swap without a block driver please use > > zswap and help improvig it and the swap abstraction to not require > > a backing allocation for it. > > > > We need to fix swap and not pile hacks on top of hacks. > > > > +1. Based on earlier discussions, it seems like the agreed upon way forward > is to remove the frontswap interface: > > https://lore.kernel.org/linux-mm/20230530235447.GB102494@cmpxchg.org/ Thanks for feedback. Understood. I also agree frontswap is hack so let me this patchset. I hope swap abstraction goes to the way Chris Li suggested in the end.