From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E00DEB64DD for ; Thu, 13 Jul 2023 08:09:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 042FD8D0002; Thu, 13 Jul 2023 04:09:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0E918D0001; Thu, 13 Jul 2023 04:09:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB0D78D0002; Thu, 13 Jul 2023 04:09:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C81308D0001 for ; Thu, 13 Jul 2023 04:09:36 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8BC6E120151 for ; Thu, 13 Jul 2023 08:09:36 +0000 (UTC) X-FDA: 81005864352.16.BE28191 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf26.hostedemail.com (Postfix) with ESMTP id 76AE8140026 for ; Thu, 13 Jul 2023 08:09:34 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=gG9p7HtN; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf26.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689235774; a=rsa-sha256; cv=none; b=AvtNIhhKB8TP+lW056WHMEoQpk5N1dfyBWjDVFdlFsRzakp91aTt7zziOUvNNGQA0uCs1t u0g1+WN8EqfHkr5GfUC7O3ZQ6qYRJH14gHeivSqCLdf4OjAxzpz4cgIG1360JdGl7HWv5W qzVo99IYdIlzM63nqSRaPwH7GV40Vj8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=gG9p7HtN; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf26.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689235774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a4lzmGg5bFXSh1ovH2sAfn4p+vzl+/Qk0Uk/Y8saxFI=; b=x2pDlb06aYcPLXK9dl3mvvBRTzepU7+l3XuBt1K8kzHPYQvoKewSPWfQNYDqyHxVnrKqUc DIDNshYNEUFCQ1Is81Bb5zCc4bMlpO/nKw99BrdTptSxngozJfRNdquXE8NCpT55TReRmY WyOBWctn9jH6c1UkfpgHn1YdFGQ9CaE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D983A1F45E; Thu, 13 Jul 2023 08:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1689235772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a4lzmGg5bFXSh1ovH2sAfn4p+vzl+/Qk0Uk/Y8saxFI=; b=gG9p7HtN5tIubv2mnEEYqiqb65HTBQtoXZCxTlDSol3E4ZTp+eieRVtCBW254urji2Ww4J L8vQW6OqxtdlyA1g3AbUyQlqypsiX72Y07Pc4rNX4wHIpmuUbobzgiMkIR4jAL6MHm4VB5 dRCvu21WltflCHrFtapcdul0Yv0Eu8w= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B6E2C133D6; Thu, 13 Jul 2023 08:09:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id n05QKjyxr2SZJAAAMHmgww (envelope-from ); Thu, 13 Jul 2023 08:09:32 +0000 Date: Thu, 13 Jul 2023 10:09:31 +0200 From: Michal Hocko To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, Oscar Salvador , Jonathan Corbet , Andrew Morton Subject: Re: [PATCH v1] mm/memory_hotplug: document the signal_pending() check in offline_pages() Message-ID: References: <20230711174050.603820-1-david@redhat.com> <7449914a-1ae3-9ea8-b60b-f0314999b790@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7449914a-1ae3-9ea8-b60b-f0314999b790@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 76AE8140026 X-Stat-Signature: zh9ft4grjocupjab9qk5gkcuzzftsgxj X-HE-Tag: 1689235774-758313 X-HE-Meta: U2FsdGVkX185QlQyhyNEIkdx3a8Xt4Ckby/EW+LDw9VDISuzroYIHQWeihhHzwt7Ju5X0rf8wkyVAQWQXhW1PvnBGtTGEoL5g0VlmaThAUvMKVMoeBV7N6cJIXtNguzessiI24AjnHyKWlMfDuE/zOFEQJUcRUzZGQeP+FeQh8cIBywL3mKG/vhx3HptllOlegEkAY0SflryrLuIWW8/OqXshvGBULOP1T8RuFlAqXV0qr4dzVZs20Q44qOgqJ7/plFEv0+eSTHbOjHpux3fm6nRcXArslW0ho2lVopAoNbwiWF8svGsKMi8vxdbkVbQmSj3PJGgqpPLfJkrOSQMbAw742dMsc+m8BjXIQ50FBqxgWwHynqPIcBPx7lwdf7yAQm7y+EjCnFszzYvI8OeNmWoGfEwAbm7sP8fWhpf+aGfYTBYDudWe3vKZv94y0fSWo+5cJ0SI2Lhe/6KV8qDjJFyeFz4v/ulQEl9EM4eKFqWWkalkc/feyj3Gm3RL4cZRoz9UNHO5AA7nR+uzLTqeSIsW1ylyR1eozFDau3+DQcqPVNylPIEXw3kLmrRosKcRRrhHSBITquSO+ny1XYUuMWGq6utNj/8xnGUwUrExB/Stejdk8ZzIRXdONpGzB9OOHFmP8K05Y77SugdazVLRZDSZINF3Uwn67RysC5sDkgwcbxZRWAIzy6vnxD8zKxja02HZ8g6gVrQFaLpJvgMk9ZXsb7kP1V53eLw4kq5phhVlNz8YfJiPwLoaIP2yQ6RPcvUMW3PUZZFF3FFO3slrExQ+Z4cbA+9EHmtrsL8yGuLj01elxpnWsANNGv6rljBix04wjihsED6HN/pyfboKldI3Ykm93ICqPg2V5DMNE1ymYlCfBZgNXaP2qMRWK2gSXCVEl4zEPnEOYTUhe76O4v/3/yPM54gkycQ1Ml/tbd3H+X+bf43KtS6YfUabdiI/VO41UsPZlFqu02c4C7 CDvqy4BM 2YazxHQMJO6OEO9lp026ahTzVxKdIX/aBaChK3vc0lRSexdbCsCj4B3YqtEt1oEI256Gj+VB4j2+7VCnvVDI6IRl+pB0sZ3G/x1oTD1KcHFUPRBf6d3OcW4a8j1Q6T3VMPGCN+7YU3Ksp4bMxXz2w+KipIyv66Dqkme0KArvlf37QbmF3w2xY5BCOz8CO12D2hiCw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 12-07-23 21:09:25, David Hildenbrand wrote: > On 11.07.23 22:47, Michal Hocko wrote: > > On Tue 11-07-23 19:40:50, David Hildenbrand wrote: > > > Let's update the documentation that any signal is sufficient, and > > > add a comment that not only checking for fatal signals is historical > > > baggage: changing it now could break existing user space. although > > > unlikely. > > > > > > For example, when an app provides a custom SIGALRM handler and triggers > > > memory offlining, the timeout cmd would no longer stop memory offlining, > > > because SIGALRM would no longer be considered a fatal signal. > > > > Yes, and it is likely goot to mention here that this is an antipattern > > for many other kernel operations like IO (e.g. write) but it is a long > > term behavior that somebody might depend on and it is safer to reflect > > the documentation to the realitity rather than other way around (which > > would be imho better). > > > > You mean adding something like > > "Note that using signal_pending() instead of fatal_signal_pending() is an > anti-pattern, but slowly deprecating that behavior to eventually change it > in the far future is probably not worth the effort. If this ever becomes > relevant for user-space, we might want to rethink." Yes, something like that. Thanks! -- Michal Hocko SUSE Labs