From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77CA6EB64DD for ; Thu, 13 Jul 2023 12:32:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFC568E000C; Thu, 13 Jul 2023 08:32:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EACFF8E0001; Thu, 13 Jul 2023 08:32:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D76468E000C; Thu, 13 Jul 2023 08:32:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CA14F8E0001 for ; Thu, 13 Jul 2023 08:32:00 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 762C91A023A for ; Thu, 13 Jul 2023 12:32:00 +0000 (UTC) X-FDA: 81006525600.01.2D42D1C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 3E19740027 for ; Thu, 13 Jul 2023 12:31:57 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=g1BCpxrX; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689251518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HzjbEBiBfxFIYqWgScZMrkPWsocac35r5l3aCsEY5+U=; b=SccFGfBAighPUUiiaIgQPsEmqhakp19DDyRIMJdXW/ZH+Mj2O5e3abkm8HZBFNsQ7m6zgb 8fyCkvwBosDTEOAMK4n+RYc1dUNDhWJAJqJ7YcnmSkPVgBXAdgUgFOqgxAfl7x+YvwuMqw YF1m99aPaDLifFvhQVOJY63SH+RRCgM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=g1BCpxrX; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689251518; a=rsa-sha256; cv=none; b=e8t5KclawvuhOwHOxR0ZNkcou1Lb2HFpdHpYhcHuodSGjp1QgX0931UkXOrbTq4LAKZ1EH gTu82j14oqSKjK8ijfF8SpE7xvljOHDpQdHwAyKDBvGEhaLlBAlEtQhxTDb132Y5BxYwJO SLBEs3+q//r/gui5ee6PJbw3dv9XUp8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HzjbEBiBfxFIYqWgScZMrkPWsocac35r5l3aCsEY5+U=; b=g1BCpxrXAj7Q9uPY/O2RKOoZKQ KozhtvUI5hgmArBtce4PuKfrYUfmhvNN+vrbky4PNKALDTeW6sf73zZzt+tr2CgT/MNBOqQcs3E33 nU8FvIiCzQ30ms1KCYEd+T8JZPrdWK4kZ0FitnAwoZfUTz6P4fD/Pt6nZmYnCBHFRac8F84ZO1uv0 Fe8SI1AcnHYiE0stZXk3hmx6vZwoI3SeViFu5o8q5prmz9oLavgbU8tssHE4Sv8LC8eMWjWl7cRbQ wO23E4h/2lV8fuKeBtaSWt+pCFFR02QoiOi30Ccmy7Yr8ohVUWDNXZT0Lm7qguDEGU1qa532VkwG5 +069hkFA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qJvUA-0008V7-IL; Thu, 13 Jul 2023 12:31:54 +0000 Date: Thu, 13 Jul 2023 13:31:54 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: remove some useless comments of node_stat_item Message-ID: References: <20230713114915.74671-1-linmiaohe@huawei.com> <55c255df-9c7c-744f-e1a1-27602fcb5509@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55c255df-9c7c-744f-e1a1-27602fcb5509@huawei.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3E19740027 X-Stat-Signature: bkxncqn8t51yrgqchppppicu5re39odt X-Rspam-User: X-HE-Tag: 1689251517-35737 X-HE-Meta: U2FsdGVkX1/FRJBTIKiOZyENN7vhXdf8ToIh3HZLh41ntqQb+S5b7Ur12lL5B4esnkg8mry3ThZ0winMxch+4zcxAVuwa8NWDY68OphPXlYnkj56t0FNpdi889VbdPDlVEht2j3ohtyHkEBT+t1AxqDxgAUy9HXa82VJkNH7JVo2ml3btGIKBvcxkDnSqM2Q1zb9ovNwuuDF+RTP2audzuZOY8ReIFalUcI6OcdA9hCAwB2r8kaHqYeoLF5XOi/NjX6lDIuq6VPh8T9vqp/TkfREB7TplMCpp/KVy09s+1uxvXnpxaPoLI0ifB0GjbWaZGh/LlU55OnbbSGyt+5GjME9UjYbgF90qn94nNTTr4JR4xC+LUCOuNZyrjaRlQKuv8TQhMcgsGO0+fp5ouboWCLTTKFw4De0Vf+nkE/vB1ogq8q54Trg6vy3c5gPvVDT/m+1L9kW7NZIpa20/HzAuSWFW2hb7+KooZHWALkafAHZZmiKUO2h7v0IqBW+jfXZm22PfTHSnyGO1hbkpqJ0BG0mG+5IBmHiE4JdspkR4pEjLRHgunQntfWD5Z3vdnEdE12V2og0bHkNj8FQI64Lhcz3dXoBlpBfUOBW3cl+chkV+qjNWtCAl9Xyce/qx5K7h0KW8Tcay+Z01jpsUZEwJpcGIIud84txnd8iYjiC/5BDaSLJuGPTwBLgpUWiBXDd9sVEiH0FkefvHNA3Uin6ZXYeXmc6OcLYcbzgcsSGqhuSzn7ysu+mA5umFIswGeZjrI2xaKE2EUUPGRWZhcwhtzIsrK7CLefESY2FBFS7scD4irxUr2lG07xkLbh5CMlsG7KJClSQTWyLIJeWxpX3UJ6Hqlj9EkIseCl7IFYL1Ub0JfV+eNLsIIsdr1Q/ar6ki9i6JNr6sLFP/zSN+49IFQc60vxZDaKNr3Y+88BGpsaX+ScR4evOtzOyAUyFVaV3t3AjHTREWENIn49pNBV YdUyWKHf lQH59WnUmJ28QSxUFoGXcfzsSNs0YwJejhrjg8qqPl1qPMRP+ezfV2Ku/qyGjm+rI2p2Xe6TTosIplgenR0GrwC5ohPz+knvWBPsWHLxg3JRvMOCCLTPXCatVBhvSkIaFeXszjuYrlCPugmtJlzW7YKdN5HbLEdmRuK+HaH1JcAu5ebigssypJ3bHjA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 13, 2023 at 08:18:29PM +0800, Miaohe Lin wrote: > On 2023/7/13 20:10, Matthew Wilcox wrote: > > On Thu, Jul 13, 2023 at 07:49:15PM +0800, Miaohe Lin wrote: > >> Some comments of node_stat_item are not that helpful and even confusing, > >> so remove them. No functional change intended. > > > > No, that's very useful and important. Why does it confuse you? > > Thanks for your quick respond. > > I just can't figure out what these comments want to tell. Could you help explain these? Don't snip the thing you want explained to you! NR_INACTIVE_ANON = NR_LRU_BASE, /* must match order of LRU_[IN]ACTIVE */ - NR_ACTIVE_ANON, /* " " " " " */ - NR_INACTIVE_FILE, /* " " " " " */ - NR_ACTIVE_FILE, /* " " " " " */ - NR_UNEVICTABLE, /* " " " " " */ + NR_ACTIVE_ANON, + NR_INACTIVE_FILE, + NR_ACTIVE_FILE, + NR_UNEVICTABLE, What this is communicating to me is that these five items (NR_INACTIVE_ANON to NR_UNEVICTABLE) must stay in the same order with LRU_INACTIVE and LRU_ACTIVE. By removing the ditto-marks from the subsequent four lines, you've made the comment say that this one line must stay in the same order as LRU_INACTIVE and LRU_ACTIVE ... which makes no sense at all.