From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3A93EB64DD for ; Thu, 13 Jul 2023 12:10:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84EDA900002; Thu, 13 Jul 2023 08:10:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FE6D8E0001; Thu, 13 Jul 2023 08:10:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EF0E900002; Thu, 13 Jul 2023 08:10:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5F4438E0001 for ; Thu, 13 Jul 2023 08:10:23 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2AAC61C8006 for ; Thu, 13 Jul 2023 12:10:23 +0000 (UTC) X-FDA: 81006471126.21.7FD6CB4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 6D87914000F for ; Thu, 13 Jul 2023 12:10:19 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KQxyOus0; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689250220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rI0ROKoRaDCr2PMeq7/zhrDW372lSE1+sY8VEo3ciSc=; b=7TrRh7/XPwvkXWR4eJJOvJkwWKh7HWcLLhgJSJ8qE11TZPqOib7y1/xIib+Fr7671vkYAS EiwdYeMGdd+AWd23Iwcanc70cw9NSYZyVJFMa71doMkxMazO5SlsAJHnwY986uziRwhDwa y27JLSSoq0aHfSTNZJAoiJCNYf4JQ6k= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KQxyOus0; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689250220; a=rsa-sha256; cv=none; b=fAVL8R1H8UDEV9njO7Pfnk63JUh8Q1fGEAx3b/vXFDUKs3g/6+trsC4WWbJlXqX+7Ffh7p j88l+sYUYVQlckNMW9111wDl87X7xK5w7WfbNOZpCrWr0dYDwZVr/PLgz1pS/4xrCs3FWj FRMtmimS+Dx3LujXSDHDXHYBUWtNgVA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rI0ROKoRaDCr2PMeq7/zhrDW372lSE1+sY8VEo3ciSc=; b=KQxyOus0p2bqIL7F+tkZO74MoC ZdAg3Lyg0SHetpOyolSQHARHBd4iWZ01Xn5TH3Gcb6UFd+N9nxp36RYw2jMQ9lIztj2EO/wBuxGZT uzendNKIPkuLwdDxvDWVvYMXn99yskr7if6dACXoSk7DFVvelzpi71cE8afL7gM9PUjpLS3F/a/XX z2h7/MMtqGUH1luw2iIiBOSmY89fDdEh1bOSTy81fQvOtuucewNfiRn8dKH8vAFQ+XeyEEiQdKzF9 XjgoXUtejQR80U4cf1W+dpmb0Lh13F6NamcJ1O6014KNIwrijTZQjeWKUF1MWIg7l6HInGHFwtim9 w4Aa0rbA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qJv9C-0007Xt-AG; Thu, 13 Jul 2023 12:10:14 +0000 Date: Thu, 13 Jul 2023 13:10:14 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: remove some useless comments of node_stat_item Message-ID: References: <20230713114915.74671-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230713114915.74671-1-linmiaohe@huawei.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6D87914000F X-Stat-Signature: ki3u9unxnx5ec455p37wgkacj7gscg3n X-Rspam-User: X-HE-Tag: 1689250219-577048 X-HE-Meta: U2FsdGVkX19j+aAtg7e6E5/m0ODPnGilIQ512OMrSihPdVgRUuXfwCXV4ZitLN2fCtuz6e24t/4mrIwQct1dQ6/iaqpuG2mvHP5EoG10d/K/OqutN9pdbrHuQ8aR3kxl1VGJm9usLIvRUSvbsyb9ZUFN2oMOTR1fwNReAYZsfnUT5/aPbqn3KJPJgcWK2kz8fXDkH4kSaWBsxlfmmdBZJ3F/4XRzTaZIwtAv09mVOvrO3IFEfcBhMt8/QQWz5tRepR2SEIo3cgNXbgJL5cpIdYsgBo9nJllVfTkX1TJYdd5BrA8uL3panuwkkmGjA9CgUCp8voQ2cRE2bTVgAMjqcWAQx/JGSxihjvYd22RKLS8ocAyDZprd2xYZn2/zJwZxOkCJPsy8KIzfGxhaKIuAOSuRkJx0yaHfrDy6Woijpf3nnq+lyvM4ADHn9N87v13mavTymQJ1YtJpmbg2WxIm3nmiLhVobA26ySnKAtgJrQKnSCGIhgXd9Xxma7/NDroiPGQ9J9SpGmNIU4O6Mh3pknxb+xiPgwoR2l810ORk/CLyMCxPIKi/ToFsWcQ3k5WjT8fURxbobyIYhGFUOwfzfMS98aJPAOCrYkOmZmQf6U4sf2rAthwZzvJYiYA/jlPvinMcYFa2SK/7hriMopJ3NDQDf9UiWlyuSi7x/f8Qcg/5D4TY7HJwTCZazH6NAyXhDQuF03Z2B88XuNV6jzi+L20osOF3MmC/xi6q+yPL2camaW6SnTE9zpo2QqLtQAXxnHQrOCD1/o7aATF6gLz2xuzAmcX+KXi0AWa6rcbpk1Wxu6ae5wyodcK0PoB7nlSwedqtsYQXAxNZsPxV2/0wp4zp7V0Fg5jsr6t2/+GGx3R7OF3grnJQ5bxwNhkTfvOenObgF9ds3B3bJfyIEAqAZGo0I4vYjoodKBKiFAeXjPNeLqdkUPwgAsMlvslz8jp4zJC6rJdeZhu2yyWGOU5 wlpYz3JC ZyuKnUWaFZS+ozgPugSLnqNf8DFe5gbRsd47KXAh/zwl2WvHbPIHgsHcboF3WREKC3K0C6pIr3BTitBV8H6vKHyEgr6S31623RMp7NZMK1wxQvr+iFL6n669rtNAnQBBizioCFf9Q63wLxP1HYStI+Q+LZy9aDZcRDVCrR18/lOkToWZQsp6OhbcX9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 13, 2023 at 07:49:15PM +0800, Miaohe Lin wrote: > Some comments of node_stat_item are not that helpful and even confusing, > so remove them. No functional change intended. No, that's very useful and important. Why does it confuse you? > enum node_stat_item { > NR_LRU_BASE, > NR_INACTIVE_ANON = NR_LRU_BASE, /* must match order of LRU_[IN]ACTIVE */ > - NR_ACTIVE_ANON, /* " " " " " */ > - NR_INACTIVE_FILE, /* " " " " " */ > - NR_ACTIVE_FILE, /* " " " " " */ > - NR_UNEVICTABLE, /* " " " " " */ > + NR_ACTIVE_ANON, > + NR_INACTIVE_FILE, > + NR_ACTIVE_FILE, > + NR_UNEVICTABLE, > NR_SLAB_RECLAIMABLE_B, > NR_SLAB_UNRECLAIMABLE_B, > NR_ISOLATED_ANON, /* Temporary isolated pages from anon lru */ > -- > 2.33.0 > >