From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F5FEB64DD for ; Thu, 13 Jul 2023 11:16:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AAD018D0005; Thu, 13 Jul 2023 07:16:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A5D038D0001; Thu, 13 Jul 2023 07:16:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94B9E8D0005; Thu, 13 Jul 2023 07:16:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 862E68D0001 for ; Thu, 13 Jul 2023 07:16:42 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 58EACB00C7 for ; Thu, 13 Jul 2023 11:16:42 +0000 (UTC) X-FDA: 81006335844.27.8D2A79D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id EADA84000C for ; Thu, 13 Jul 2023 11:16:39 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=IJSgBUQc; spf=none (imf01.hostedemail.com: domain of BATV+919f44f13023665e7d97+7263+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+919f44f13023665e7d97+7263+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689247000; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hve6OzeHIkdD6xHt82S33eWJRp80zPJMC3v+8m4oMzU=; b=qRLdOzMQaAvNd9FXjCRH8wF5Wu8XiJ+uH4nV5MR4mnPArmi9fn93Lg968i+lCrsnYWM5Y6 dr/JDhdzG56CMEWdCcDapC5ACPSSwzo1BTdP0k5Uq63qbtH1RyM6M1gnp/mcNtz5DkZ5w5 4F3DntpUr2cc12djumYdE47BV7wYhzI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689247000; a=rsa-sha256; cv=none; b=Hdb7FVpOUl1t6gl1jlVNoZ+RuE6F755M9VdzfV9FWN835vqUGtQU5s9t9aYte8SMYekn7q /KWx4uUsw7S3YuLZl+ImPO5sF4lzbD050xqq1mJKKup8d5VHz//SXhldairBIcQvcpukK6 2R035k/GHgvf2QlZQMzC0cx5FoKMVc0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=IJSgBUQc; spf=none (imf01.hostedemail.com: domain of BATV+919f44f13023665e7d97+7263+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+919f44f13023665e7d97+7263+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hve6OzeHIkdD6xHt82S33eWJRp80zPJMC3v+8m4oMzU=; b=IJSgBUQcih5J9/NoVnDi/SLRKQ pEQBzUuM0/LjQsWqeYlpQHW0TKehFIUwYMoawsrzkcZgc3tGpUAWzgxasafhc8cYFikD6vIgO9jpm jQ+K0W9JOtzac9ZRRBqLVs2S7TJ1A0vaBWL/6l3UtABCl0zf93ZSjhZdpAwO6kuQmXfjgN6c28h2N Nus0X9NzFugACNIjaK2iSjRLb3dg3ncfIynmIWtsGndsHJBjRNa0VTOzCqx3XCEASGL5Gxuy/TLdR jZxHFgHHyUUFOJqWMMcs3oV1GGv0tyuaWj820R3GnYM8Cy64ZjPR33/2AwjDimfP71QLIq1YsKeLc VvCOv14Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qJuJH-0033at-3D; Thu, 13 Jul 2023 11:16:36 +0000 Date: Thu, 13 Jul 2023 04:16:35 -0700 From: Christoph Hellwig To: Qu Wenruo Cc: Christoph Hellwig , linux-btrfs@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v2 0/6] btrfs: preparation patches for the incoming metadata folio conversion Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: EADA84000C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: apx8qc1nf69834684ukiwwxdniyrejcg X-HE-Tag: 1689246999-307699 X-HE-Meta: U2FsdGVkX1+6cCD9sOPSfUI6UI4l+/ARQI+ClnHqJMYlAlHDzhbBBkgcU8yhrmuNRbTD0iQRKdOJ13sY2pvWZfyBkwwQW9um3Eb0FBZ61Ip3fxE8bnmbIemy0dWx0pVysozgx0FIeDE5N5XxT43bxwYMpoTX7o4jNzTrwkM0KRL0bz4w+3FR5mBdDhgcUJwnthD+EB/gvXA2sZaAxZnphmSQESyXCjt3+7T8tS98jjjzuIFyjm1zDhkEH1AXgBPle2WubCOCSEp4HwPUvXeTjBPOi9R73XbC/PmZCaPed9WTpit6hrjTXA2X74ilxOlJ9M1bzOKoudZZJGLK/qErp6Ku/vV744DS8nANwS/Fm7RHI2dKsxMAw6pJSne2AuKLf/aw49ufs5RcDPkYRSwwRfcx8ivTbtR1z5vtSM3Wm40eT2YBYak8WqFiCLQ0wlPd61z4V/Os0cbA1lPhktu43sOfCfnZnxoYOkWZ0kNZKSNy+4Y0NGOZsf/8A0gSWnQSQ8czagWLgJEr6Zh36YXSmMAdijd1Hknd1zqXtDbH88i9V3EuLCJQ8ZmsXA4OrN7C6qHP/eFzeagPFGOjHCW98QkEfHYSLUpy9cQI0fqIzA8Uw4W49+QOJlY2Cfx4Y1tum0OkrAMnKBpmbNQZJ5DvkLtfVE0tROhYsIDhjIdRlZuizMJoaqPYdOGHLw/EUViuZEF4/idwFBFDjXcL1nInUfvJ6XR7+fBelbNdFzpPcR8YOOqidmep36vPOXLJeY1pJa3LFSBpYDSgOpK6X4OuSgaLwNfT0fiExAOtjkgqSYaxANeLU/wTgJYqN6qCJSamYco+8pKie7NNhH+ZQVaTph5dAdkuroONee4Yoq8udaS/mt+bH/sqEuSFG1MyYTPH+zwM8z6CxYqLvil0CIG4ipKW/VWu0E/Tc6GEME4Us95wiN79v74TZcF3HwH7cgh7cOAR3HfpVLjjizNhNaH ahlY5rNJ /bpBa3vimSzw0pm2VKpJP/uSZeX6jH0v7VT/6ASHKTIDnTsl+WDKZ9SQ1lTOiH8bOzyzqmpiT4HmLh8zCGEFtzOiGK3g6HJXyjn7V8Gfjxycz5dbw2oLXLnEbUKhft6X701iUupsB4X/ATigHiwpxLDhQHapOJsUCTCQs/QBcxPWRrrqmkRUF87CY90p/8BbgpHJNYGy6t9PLMCneWQD7zBfH5Q6jmrG9dBogJyrKwRVfeBncxXCRPLtRwyDC1s83MLD4royD/YNdmYBkVZm6csbOVjnynhW988LTlqdKEDkpEeyMc+J+Jrf5zoT3WvmiIcNUEyA3mh7dty9PiblkOrdwNqdw+xqGQW0og0dgJO1g8Fkr3BiBzbqULtODsXEsi24H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 13, 2023 at 07:58:17AM +0800, Qu Wenruo wrote: > > Do we? btrfs by default uses a 16k nodesize (order 2 on x86), with > > a maximum of 64k (order 4). IIRC we should be able to get them pretty > > reliably. > > If it can be done as reliable as order 0 with NOFAIL, I'm totally fine with > that. I think that is the aim. I'm not entirely sure if we are entirely there yes, thus the Ccs. > > If not the best thning is to just a virtually contigous allocation as > > fallback, i.e. use vm_map_ram. > > That's also what Sweet Tea Dorminy mentioned, and I believe it's the correct > way to go (as the fallback) > > Although my concern is my lack of experience on MM code, and if those pages > can still be attached to address space (with PagePrivate set). At least they could back in the day when XFS did exactly that. In fact that was the use case why I added vmap originally back in 2002..