From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C5E9EB64DC for ; Thu, 29 Jun 2023 00:19:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F8848D0002; Wed, 28 Jun 2023 20:19:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A7E38D0001; Wed, 28 Jun 2023 20:19:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 097248D0002; Wed, 28 Jun 2023 20:19:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F00358D0001 for ; Wed, 28 Jun 2023 20:19:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C0320120356 for ; Thu, 29 Jun 2023 00:19:10 +0000 (UTC) X-FDA: 80953875660.30.5CDAD67 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 0140580011 for ; Thu, 29 Jun 2023 00:19:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=a9RTPe57; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf02.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687997948; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uV74I/9ieyeYsB9xVMBXSkK+tKHYnF1X91Ya1L16VGY=; b=QLyH3nYmAXjm93ji2Uj/3cCxN2XgbsBEI7YEl4+8iEyr6WJx2sv0qfoKJYlA1d1ATDQe02 9S52iaWJVUg/PtfkitV9f7Bqp7ffmKQX9303MCduUjzDw52E/8b8LQCKMT0q67Ayvq6FrN jN5JXAQhdJarSV9n6Zim47qM1S7wdF4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=a9RTPe57; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf02.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687997948; a=rsa-sha256; cv=none; b=qqu+C/e9kESDmo5vTdplP/rHgoHFbF+wnu5uUyuvq6qn6kIMXmkNU3k9G7dl2AZz8hPbXZ s2OhjR6fktzD5PrJif4pNfYoFnKZ/O7steijhlJcF3FaN9SpVUvvmcAdlbbDxTXlQhayqX JFGbzxX6M5S365tMsxYMnBxfq8Thnjg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uV74I/9ieyeYsB9xVMBXSkK+tKHYnF1X91Ya1L16VGY=; b=a9RTPe57R523L1tUVX9Dp64uoy pD2jJbsL3WlY1HiRHWFQgRtBnJMSlqT+Q2LAJfTLvjlWjmY6m38EuY8DsM04daB5hGfYyrj2lT5GI b96MEinePKNIq/CLTtV3fgCJ3yTxWBGG1vnOPonWtHJnj6Bbeg0qi1bfsuu8ukH9Okzye9aixAWSh O8YwwDPOkR9oD8iGZoNi5CWNwsjY+yKSV+4Zfufenn27yXT2H3QXRYtjZkiyXkKLK8NFzil15f1f/ shof7o1fSkA4VWH5uygOslGZKurJONkkKL6RO6WQBD4qRE59KxCuStFjdT6tl03p6Yqqc9OQzTayr 5+ohlDcg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qEfN3-00H7bf-0x; Thu, 29 Jun 2023 00:18:49 +0000 Date: Wed, 28 Jun 2023 17:18:49 -0700 From: Luis Chamberlain To: Linus Torvalds Cc: David Hildenbrand , song@kernel.org, Johan Hovold , Lucas De Marchi , Petr Pavlu , gregkh@linuxfoundation.org, rafael@kernel.org, lucas.de.marchi@gmail.com, christophe.leroy@csgroup.eu, peterz@infradead.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com, yujie.liu@intel.com, tglx@linutronix.de, hch@lst.de, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, prarit@redhat.com, lennart@poettering.net Subject: Re: [PATCH 2/2] module: add support to avoid duplicates early on load Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0140580011 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: nhdccte44ortkqpyqa786pqrepg7gd54 X-HE-Tag: 1687997947-67819 X-HE-Meta: U2FsdGVkX1+4ZJfvdE2YAhr4FU6agSnAZ7Fjo/F/S5o4Fq7VahwHo0EW3wa/SF7V+xfKXjMEjYmiR7lJbujmemVCJEx8tRAcMG5axuemVeUdaw8N7wNSmPAsCRqatRNRX4+j8SF2f3vlbf2KUzbbXILx54F+EMo0D1RXqSnLWZsh7EEciss6i9OeufhQKBO3DK9e11rAGw6wRrag2WThq9bWLN+IQCGmw+TifHtfqqBSPe0oSG7Lgrfo6MjYKEavDwayxrChYFZzE5+hZb8WYSs/76xTofS3toRAOlElHm4FVJLjvLueAEa8qr1+nrNz47vSgAXlvrouS5GJNW7myAEhfY+vdpjkpS3HbTvLzkssZc4hzJ9ekojvzfwd0LVdQ9g1S6pbYzJfEnCW1XUXS0v/y9QWaPvBmtlBkiwXxIi1mFtWD776/XmV0qVClB3xyPUmAd8INkI9sy1B7ufZ8u1sKbcNSrIZjo6YZk0MjouvcwS7kp4ceJo/WoyNHbXS6yeFtbQWPabz1FCXFk/1tf4sAPsECIcw516wOy3Xy3UjXxzHX0Rj0vkgixqzjSYrXAmaQ0PEgnL1FPomPPCzXMAYSIjO38SF6EOegrb00YcsZqXvXwjl4Ggf6YZx4vp00Lk4sKABQV6hV9ETdNuk4DSfJNP+HD035s7/AfLd7sn7k5U1nEssOM1wCC60f95ebXtlYZ0hQVl1zdYI71z0YIW4XtQoyqM89/Dn3UZsjWSIQH7r2XAt1MnBuzcci9JyRPOc5DbWrwY/lHfEoBvbVOKAyvKzqDHwXaJLJpS6eM8laSkHXyox7KQhjbs0xqtJ4YSsa8X7dvW7bowZ7wwKGrfeCjykl3UosVLGlghIKG74tnrKOPN435+OBrL/9AOei5OiLsu5zk43TqZyw1H3AuVfO5gdiLDAmGUG76O9JXKyxEqFcKB6X9yvdEJWya5ZfL7TgmVeuomjs3TFKPB XvPeE9Gt F5CKlX3Gsnx1xAvX5AhSSYs16FE+UcCFMXasMicO4X3bvwiDbNHrduXa8jVZwKZmA7+UQZlv+wxCyhjd8X3q0q7WjgMz4V8w+E4hKq+94kLgkLoiOld3mT4yC15fF7vENtohnlBQDDWrWKqxyN4Jk+IqIMK7XyGok6PIw4+LgkwV/h9BciDnc+NDcO9ZpbzVw/+OcyYnEMBAW+ougukQ6CZEGx5ADnZglEdZmTiH9SuHocOyDUCrFUsYZNthOXVME394UH26hWjsGwZjszaXMpkf/b+gd15ZE4u+1p5WXI6qysf0jyo1sxaSsOfnHh5SbYNhbRaJq45N69lXSizK5sjgWK7JnLlLkvZEOMoZ07baCtHeuLR5upMt6iEUwJvpbk8AMF+vhW0s10/8uozrY95B6iI5jvwKXIW0DPnfQuKhDGnfrLvrFAKby3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 28, 2023 at 04:17:10PM -0700, Linus Torvalds wrote: > On Wed, 28 Jun 2023 at 15:07, Linus Torvalds > wrote: > > > > Anyway, since I clearly didn't communicate clearly that I was throwing > > the patch over to you, let me go and find it and just apply it myself. > > Ok, I spent some time writing a better commit message for that change, > tried to make sure I got everybody's comments and Tested-by's sorted > out etc, and committed the end result. > > I also did the actual module pull and your sysctl pull. > > Can you please check that it all looks like you expected? Looks good to me, thanks for doing that. It certainly was not clear to me that you had expected me to merge your patch just because you had previously merged your own and later reverted it. But now I know in the future I may just pick up your patches, instead of expecting you to shortcut it, thanks! Luis