From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4EE7EB64DA for ; Wed, 28 Jun 2023 17:32:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DC868D0002; Wed, 28 Jun 2023 13:32:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48C098D0001; Wed, 28 Jun 2023 13:32:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32D178D0002; Wed, 28 Jun 2023 13:32:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1C27E8D0001 for ; Wed, 28 Jun 2023 13:32:12 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D54011A02CB for ; Wed, 28 Jun 2023 17:32:11 +0000 (UTC) X-FDA: 80952850062.16.CF62E6D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 8B4C420030 for ; Wed, 28 Jun 2023 17:32:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M57DPi4l; spf=pass (imf13.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687973529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J0S2qMu17h8mlXEB7YzGyxzD+O5lnlad32j3R4zdlCU=; b=LFIX7aff3Skn9V2+HVwed9wBPYxXVuAD3X0uLZDoOGAutYGkHKvyMESSt5y495CU5qEMLe nGQBnHy00fbZjh0q/g9v5KjvrfW1AetMUT6MNgNZWip4tBPnqKdP0ji4N9fRO5ftyfIkTL tvn3T2NWCjY3cweKgWNwDQhDbhoxylY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687973529; a=rsa-sha256; cv=none; b=ddgWWSjUFTqztQHV5QvQnV1fg5uZYIN3Zbr7x0yOGFneVExN4gkthulxvI9tGg1PCAZKrp sFjRZEG1l+J1xsH4qBxbRps4l89t13vg4Ta3WUKhPpjWkcOK5diTT46SD6fVtJWk8/8TgX TLbAX8xOggunQb/3dnrEUlYter4D1qw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M57DPi4l; spf=pass (imf13.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687973528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J0S2qMu17h8mlXEB7YzGyxzD+O5lnlad32j3R4zdlCU=; b=M57DPi4lfrv3l0ZnunEJ9yGziRjLEDYRFCokNiFagm2BJ7fu3ojN9StwZKoiSI0X9oHV5m RBgw1p6D8PPrHjioDtfKVUbZXIWeRVORgA8v01bsS6lggLlZfQkKGdgS4yFeQA5gzbAs0p uKWhpSQkTPeViRyQMts1e+o0puid3+g= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-391-Cw56o04VN2eRS5jNcyrbkw-1; Wed, 28 Jun 2023 13:32:07 -0400 X-MC-Unique: Cw56o04VN2eRS5jNcyrbkw-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4032a3ad8c0so296811cf.0 for ; Wed, 28 Jun 2023 10:32:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687973526; x=1690565526; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J0S2qMu17h8mlXEB7YzGyxzD+O5lnlad32j3R4zdlCU=; b=blikU6alfmRZfwQq0L/sC+IpUo0WgmUyo0C2HgjS23S/XYm5mLI5USqMy4SmIi5lPG YKpys+ExouoHM0ivGCb429niLeiYykoPmlFapmN9CcH6x7bDuxNlNQjifpC9Lki0lOs+ pYw5EQjXxhJjXCAHwmyxjxaT11BVom2l5GqRfJ7eUjgG3RawPWrkVb/o6VAYTXbT65iL 19EO1FiJkawmOcYQ49syI1eGFKXkOQYKPc12MGJVSU/0nMfkRWzRrgepAwfdWuUBNIhC xkT98nqIgd5AsTxXT2bIhtwq3A/mWQPV7nxA6wCZOgE4j/CnPCdPzW2tfC/JhACDKh8/ ivEQ== X-Gm-Message-State: AC+VfDwUTD7V/byBTe5YlsQYrHIYQpk/MB2B3emkP+NVYkYtXYXVIT5G VMa5XDKy+ridLY03tTALMMSQV9z6xbP6rix9e6vWQ7ipMT1GjV+b8im9zAc54yfdcDKiA4libzj 1lx3/o93oc74= X-Received: by 2002:a05:622a:1811:b0:3fd:eb2f:8627 with SMTP id t17-20020a05622a181100b003fdeb2f8627mr39939250qtc.6.1687973526692; Wed, 28 Jun 2023 10:32:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7zIbrpeVS1P//ROrLWn98rbJUqVC2cFPhvP6qO+5ZYOuBmYLSEJ8G5hmetYO7hG2lGw3zRQw== X-Received: by 2002:a05:622a:1811:b0:3fd:eb2f:8627 with SMTP id t17-20020a05622a181100b003fdeb2f8627mr39939221qtc.6.1687973526431; Wed, 28 Jun 2023 10:32:06 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id l25-20020ac848d9000000b003f7369c7302sm6095196qtr.89.2023.06.28.10.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 10:32:06 -0700 (PDT) Date: Wed, 28 Jun 2023 13:32:04 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v5 6/6] mm: handle userfaults under VMA lock Message-ID: References: <20230628172529.744839-1-surenb@google.com> <20230628172529.744839-7-surenb@google.com> MIME-Version: 1.0 In-Reply-To: <20230628172529.744839-7-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: f4wyi4pcby4pwsqehk1ecc7z88xjnm9i X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8B4C420030 X-Rspam-User: X-HE-Tag: 1687973529-945704 X-HE-Meta: U2FsdGVkX1/O0B6zKOwn5QCMPL4dXv27/RL/yiKJszViFu6GYDT2Sm0oBK2+L/vAsVuRNCTS/o5rGasuoq3GsuKMwz6lZ0ZjKiwRyRXgJz+LOiozjpy08JpGaZPs5G0PENJZmlEfkwPMz69BJNcNmMqWDElZ/h22rhkQJ1rdo8/kSHmfVoaK1at7Bfy+hxU6QHEaDQZqeMPxaHYmDbO4l2Y5A6Au48rCS7/uaT2ykLI1ZDJIbC+uRycZgIMWUVSfr6hrbDRKS5aWf+ThOB8bmW45O5JxvfxfyEWo9qME341n5V60nvCO40sG20jFC3Geqfp39ypQQvTiOHjGXGmK/d7IYuWxefLO6yISxpHuJjVXtMxzSzJHRQQhJgHkoCM1AS3K4W9FNrKe4Uq8LS/bP5EF486U0wAjFCh7wxwq7dY0O/Lg33MNb9p2MBaMHjB9U7k14qdMHXk6pVm4fcbAYJtrIDokqzyhaU+Ps1GR9k3fhJhI7gskfUmKn88eY2t0ODSeuMGZ5l4tTxw09nFc780jrmkliUxhrpRuqORrUC0eALldJyzDWApReRuME89JRqFweQ7lokJlp8NIvttoTaUA8cHu8GCySV1i0g9O8lwFWovg4pqfvMTCiqKL4E5/XVhXWZDFnPNi2FmYVFu7z9/qZ5ayuuhcYxpbJamWgnIWRoMBFCEA+NSRP4czPJC4iPX0ATYkZ6MSDXrVIuJGv1WD87H8bb5DsjqsRz35LUUdLfAtIffUgnJ+8gRAGVR467gaePbr6yzwDJ7+LjFmtuyIpAd79KFDHB013Vc0Taoz8Cp3hhnplVO7ZcyvtOSyDfoPFIKvrhrCclB4j8YP1lOA1m8d5mHuy5t/kobUV8EKBpo2gQ6J3gfwuHI3qzBVaXy7sFCVO6aNsV5JgAhrEDZ0CMSht2u4CD30bhfRpWHovfC8HEdArYXALkhn4yhMMHxjwExd2WmyHVrUmKq 7ElVPiON OQm7zstFJiEpi8KpkTBM6ibtN8/0XVdbuugmlAkPgzJndTVlRTAeoK8BSDlMnQZJEjk42bdF02FGHLeyx3iDMMzwWpTEKye6ElW7nGryZTwtoygnbU/78tEmAWHSGyrvAsF6UAXWLeVApS8xMm2ZEzjW2OOV2OgY/lFUvVZ+a+dCVRAOuhthEL05Accc+RoVfyoIsu3D4LOtXUaNxxdJ7RE4YPx5LpBEW8fJzNAQ2m7yErRelttFlq2AX45e3q5W0huujHWRva3cP5el4QiO7+nL0YlcuygmzWf2cDbILDmgMC7zMyEgNTWuu4TtHzkB/93fOGRmf2neNqAyrq8b11KEUKaiOBSFmkW7Lyx6vPKvmWdu6n73gvQdXQereQQOe7IhdxoXabDPYoDxyxN/748lVYV0OKjkn87GK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 28, 2023 at 10:25:29AM -0700, Suren Baghdasaryan wrote: > Enable handle_userfault to operate under VMA lock by releasing VMA lock > instead of mmap_lock and retrying. Note that FAULT_FLAG_RETRY_NOWAIT > should never be used when handling faults under per-VMA lock protection > because that would break the assumption that lock is dropped on retry. > > Signed-off-by: Suren Baghdasaryan Maybe the sanitize_fault_flags() changes suite more in patch 3, but not a big deal I guess. Acked-by: Peter Xu Thanks! -- Peter Xu