From: Roman Gushchin <roman.gushchin@linux.dev>
To: David Rientjes <rientjes@google.com>
Cc: Julian Pidancet <julian.pidancet@oracle.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
linux-mm@kvack.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Kees Cook <keescook@chromium.org>,
Rafael Aquini <aquini@redhat.com>
Subject: Re: [PATCH] mm/slub: disable slab merging in the default configuration
Date: Wed, 28 Jun 2023 09:44:51 -0700 [thread overview]
Message-ID: <ZJxjgy/Mkh20WpXv@P9FQF9L96D.corp.robot.car> (raw)
In-Reply-To: <48bd9819-3571-6b53-f1ad-ec013be742c0@google.com>
On Tue, Jun 27, 2023 at 12:32:15PM -0700, David Rientjes wrote:
> On Tue, 27 Jun 2023, Julian Pidancet wrote:
>
> > Make CONFIG_SLAB_MERGE_DEFAULT default to n unless CONFIG_SLUB_TINY is
> > enabled. Benefits of slab merging is limited on systems that are not
> > memory constrained: the overhead is negligible and evidence of its
> > effect on cache hotness is hard to come by.
> >
>
> I don't have an objection to this, I think it makes sense.
+1
I believe the overhead was much larger when we had per-memcg slab caches,
but now it should be fairly small on most systems.
But I wonder if we need a new flag (SLAB_MERGE?) to explicitly force merging
on per-slab cache basis. I believe there are some cases when slab caches can
be created in noticeable numbers and in those cases the memory footprint might
be noticeable.
Thanks!
next prev parent reply other threads:[~2023-06-28 16:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 13:21 Julian Pidancet
2023-06-27 19:32 ` David Rientjes
2023-06-28 15:05 ` Julian Pidancet
2023-06-28 16:44 ` Roman Gushchin [this message]
2023-06-28 18:50 ` Lameter, Christopher
2023-06-29 7:21 ` Vlastimil Babka
2023-10-12 16:43 ` Kees Cook
2023-06-28 20:59 ` Kees Cook
2023-07-06 14:06 ` Christoph Hellwig
2023-07-06 18:27 ` Lameter, Christopher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJxjgy/Mkh20WpXv@P9FQF9L96D.corp.robot.car \
--to=roman.gushchin@linux.dev \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=cl@linux.com \
--cc=corbet@lwn.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=julian.pidancet@oracle.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox