From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFEDEB64DC for ; Wed, 28 Jun 2023 13:42:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED0EB8D0003; Wed, 28 Jun 2023 09:42:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E59358D0001; Wed, 28 Jun 2023 09:42:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD2F18D0003; Wed, 28 Jun 2023 09:42:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BE7E68D0001 for ; Wed, 28 Jun 2023 09:42:20 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 88ADC1C8CE2 for ; Wed, 28 Jun 2023 13:42:20 +0000 (UTC) X-FDA: 80952270840.30.B69D100 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 2F56640017 for ; Wed, 28 Jun 2023 13:42:17 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qtu5NFGC; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687959738; a=rsa-sha256; cv=none; b=8qgYiCibkIOM4Ml3di4UWLXTeN6TWfRO/szQrzOfJff65rEjhIKAcQtU2oQch2tk8+fJmm V2zX43Umg4/aP4YM+/YffBmAdTRgsnrStbEjqZBR7lN+FQxR2MvYtaNODL0LC8uA2BtO/T a/XpJU+9/cd181L1djPesv0jJSoaRyE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qtu5NFGC; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687959738; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rndt2IvyzL1bpq00OdsHzX63mJ29mnBqUBKzgaUOisQ=; b=V879M3+5l1gVvJny74SLPB+NjTcs/7dJg52KsykeOdBOxNa+XG/uEMtfEKGXLzZwYHfsY8 o3LYb5OI+bmEXmoqy8sc/2lIrccESJJhc9yOUQqmhjckwQp0sMnrqaC1ZHAqEANugXsqYw aaLXOI1wikDqfXE3y/2qFzOrWd5DnxQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687959737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rndt2IvyzL1bpq00OdsHzX63mJ29mnBqUBKzgaUOisQ=; b=Qtu5NFGCLUAFUYNvp9ruL13XoOCVJBd7ErZoIdSlVSyufap/ZCEYMwSpdEYPlKOQpEDtHN Q5ilK0lHLVJMXyPsM7WOSmNRSgKf1T9dnSETINOPwTUhirvoXHBGcPTzEFGY8tESXDyDGn 0dgwBGu9Ilvqe0ig1hoDvClzWkur3lY= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-318-ODWww12YOGCL4leodF3nrg-1; Wed, 28 Jun 2023 09:42:15 -0400 X-MC-Unique: ODWww12YOGCL4leodF3nrg-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4032a3ad8c0so167651cf.0 for ; Wed, 28 Jun 2023 06:42:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687959734; x=1690551734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rndt2IvyzL1bpq00OdsHzX63mJ29mnBqUBKzgaUOisQ=; b=TFQ9WsPeFiPy9jbOXgzH68SKBjlNk4Cjyg692C2xrdMejEH9NoNOQgR9r3VuiBehtD B/ae972OQ3vIdYBu4nQ8T6XP0u9BqrQyHzzE0UOHoEDiiLu3kTxIAwV/tCRo7b4qQBK/ oaQA06XCNuMQZLHaPQUlw+pZTKueMuimflgtoTasC2mds9ekH02JuFmWAyVFsDehT3pz uVZyNK7j0ektUfJuFAzHMAToYC6DzT5Oix/PZtUwbjTAimX51oMbo78DIx+DCNs65KCh uJr0SJQcB9jzX0JKfhUWxnFVJOC5ppquZJwaQaxqImuGs3R7cpLV2JBhODvtS/hU4A1T xfLg== X-Gm-Message-State: AC+VfDwMtZHK76GrDy7QYoC4VuOphMF5k7ZbXg6SoagHQEPS3gLhB8Ms 44+RMjZt6m5uYU7415jAenceRwWUp1j39mUVgqEps/xGiSwm0QT2KVL+yetanArxnoyNiDjP4c6 kt701D6OtUn8= X-Received: by 2002:a05:622a:cd:b0:400:7965:cfe with SMTP id p13-20020a05622a00cd00b0040079650cfemr25071928qtw.4.1687959734534; Wed, 28 Jun 2023 06:42:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4LJyKRZ1t9xeZ7f1URuPPES1doCxywGeau5zExcrD1uMnZePa5MPysl7HJ8/dtiT97DYpdRw== X-Received: by 2002:a05:622a:cd:b0:400:7965:cfe with SMTP id p13-20020a05622a00cd00b0040079650cfemr25071899qtw.4.1687959734190; Wed, 28 Jun 2023 06:42:14 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id ge6-20020a05622a5c8600b004009320adb0sm5867387qtb.80.2023.06.28.06.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 06:42:13 -0700 (PDT) Date: Wed, 28 Jun 2023 09:42:11 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v4 4/6] mm: change folio_lock_or_retry to use vm_fault directly Message-ID: References: <20230628071800.544800-1-surenb@google.com> <20230628071800.544800-5-surenb@google.com> MIME-Version: 1.0 In-Reply-To: <20230628071800.544800-5-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2F56640017 X-Stat-Signature: cchyqf7b1dz6ye36tnu89dt93663tq6e X-Rspam-User: X-HE-Tag: 1687959737-823418 X-HE-Meta: U2FsdGVkX1/nM2ozAQu4kOCLbdzAuev7XoV8RQJaLj2TENfr/qslBPR7x9nsCI5HcINOiuvdKy4DPB5bj9eLQaj57u6XCT1V35S8uLMq1yFqF4hSK5VimEPVJ5ZeFihmedV8yNqf29mKcaFbwYgsM7pK8l3YWM8ORXQgpOL2k6cCPP6LEIFmzfm8hCcviKHTZdGK4jhcQ8+SHps1dZ61Ev54ucVqU4cc61TbDXh4+eMRpP3IbowfY68BhG2rnQ5c5ojLPmSGQRoFBxrZLSDFrk8PXsOWm/hVpLycMeiSx7Ta5QuZwuIgqiFNZOMb68i/HncE57esLYcNfqg56SFg52pxIgU+upM9cVa31kKr8xQGvNEoEICIHKkTVyVsHrKpkWpz7ICiLV4pajYibglpYWMRHfUcMq6q2LL/R01FVGoFmXqsN7Xr+yv+nf298VapExJ1Qu7OsE5uQ6Z0Gtk6O8LUigAJB/mq+ftMwASGj5AZch5w3m8bV//S11r/sM/3ugIcEbI3HcNRihAGEa0xQ8M5aM5HPH/xOQgcPHyfC5XzAuvBcZMGdbujhJ/lcyyLEHV0pR5gtLl0k2wV2GdcvRly6auuvdUeoWdJhb8WD5LrXfB4mM3RLoldLudPn+2/LRw3wM/cOqA8DYLmC6NKrEyD9ZlWU2t+JZ124zq++osQP6r+C0mc12Wd3prFDl3ESlnmx7bqWH0aX5qjGFdUj7ljmwT4ws7nmlXgIKev7EXBP4e49ptiVq1+IGth7osld4QiyHYov0oWVc/FyDqGj1zvqRUas+AKG+24SfJFwjxfF2QD0mdJXFgNdwkqbsijjoAaxI7QXc6iVEtWeFq4aC3cRju1ejuVbjeWxYzc/7znAwTPx/RiEP6FV2xYCawF9LH3bP+EnqouSi7c42KWR6YQBrofU5nbdXM6taOVPkW+tnEK5JVneH8wzZAbAJoASrpJOQpBslHNDD41vxy BITqlZN0 7pKRfymzfAVlOzvZnrbam/3zCkVPISeLC3qgnjdo8JWoyaR7qVyqzGL73f+OMsc+CWCxXB+yudHjDbDVg3M2X8kFQuwrdMs36hwwr+4YtZA1rmTVI8DsiRSQx6h3Fps/no/orUQ4ikA7WzCHdNDtaz+AirofO1ZM418FfkpG0/jUL+wmpSzqgmFEAz5ZLY3q8s6j/CnFPmyAOHibHDNcXiJT271DqLfpHtVPfwZ83SRIZJz4lYF0CqkFdKAMJoKC4AxOB9bxrOnrBoOYC/SZBdxPsiq1BJGyUAPPUeGkW7FRmLp6LLsMGBOO2Hcnst7AoQfQuIm1ATZf8bGtZ4rqw7yAgATirE6uich8yCUFGOBtZPmcn8R1PpOslx6+6wuDMMSEwtuND0UR9KmXJyC2AEDupGf5fSnfu2Wa2i3DK7Ul1e+c9WOqAWCQ0fQ+7DwCHIc6vIeyl22iM2tISSEWCZmXrLFawImhA+tAu3fmPeBrB7DHnR8GD+9hXFXx4ttkrLhIShpd+8t6FJNo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 28, 2023 at 12:17:58AM -0700, Suren Baghdasaryan wrote: > Change folio_lock_or_retry to accept vm_fault struct and return the > vm_fault_t directly. > > Suggested-by: Matthew Wilcox > Signed-off-by: Suren Baghdasaryan Acked-by: Peter Xu -- Peter Xu