From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADE8FEB64DC for ; Wed, 28 Jun 2023 13:41:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CADD78D0002; Wed, 28 Jun 2023 09:41:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5D1A8D0001; Wed, 28 Jun 2023 09:41:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B24B28D0002; Wed, 28 Jun 2023 09:41:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A5A038D0001 for ; Wed, 28 Jun 2023 09:41:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 68AE040268 for ; Wed, 28 Jun 2023 13:41:50 +0000 (UTC) X-FDA: 80952269580.03.B0746A1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 4E33F1C0021 for ; Wed, 28 Jun 2023 13:41:47 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QcskmUqJ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687959708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ILSaV7SEbZMYRZS2QLMojuBNjtkSUW+dMP8xI7bFpVE=; b=EhTzL8WFiPHnmMpur/oH3rlZQpVxxGargfwejqx6fm8w4VFw8B2q4Y4JGGD2FhMya5uU4b dtBxNbGs7lw9OoIt/QN2n9QowsFUOFyo8IzHsA65slg+w6IcsO+asfHNzNjoFL+fsh1A2P TF0gR4GPSF0b8clDgmAGQGjUoS9oSPY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QcskmUqJ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687959708; a=rsa-sha256; cv=none; b=xq63y01WRG2vNns6V9fL268g/EhlV7tgLvGEsnLTruZZjRyxZk5nc1WRSsDEwQYAhi+7WY 8En+QkqVvjCbylKGQcTti8Td6UasAgRv2IbNKTgcTROyogxAK4YjnQPJDJeb4HaBG1pDZI uBTrqbzYz/DqSAJNzy9cFuZO3pH3OK0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687959707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ILSaV7SEbZMYRZS2QLMojuBNjtkSUW+dMP8xI7bFpVE=; b=QcskmUqJ84D5t3vitQce1AtWH9dypLK+vA0wTe75sJ4VWYI4jF0R5/dbJHrq+wAEior8kW c6uBFoJfNfF80jnpSjE5040GCdPQLED+spJwSNktmJHJ2Q7GrF2Z0oLJe6xCqqfN/wMb0F pTnc8m7cAUI4SPkcbkwkZcAODmUZ18Q= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-qKexbvsYPRicYGDqLUwAaQ-1; Wed, 28 Jun 2023 09:41:41 -0400 X-MC-Unique: qKexbvsYPRicYGDqLUwAaQ-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7672918d8a4so6381185a.0 for ; Wed, 28 Jun 2023 06:41:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687959694; x=1690551694; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ILSaV7SEbZMYRZS2QLMojuBNjtkSUW+dMP8xI7bFpVE=; b=FZO7aQwIWQ55PbKZbJBdy62kO4HTXdy7vbWIjDEZGbTyAn/DZjD+3c/Yn0cf8iZnzo DbaDEbvZDlUHsZZNQrND3nvmJLmlxzG4XPvtPvbxTck2NkWT+XtnPL1J+kPKip3JMqQN NzvNUz4Q1pO7olgy9wcFYNALGK7KMSkDM2gYu4N+sjvv+v8VSKaKgWuGJAXm0DtODuyt dqEyOnAtNaBzhnbpfV5G2/2NWTXtDtth11JaZFpfMhdzZhu9ApUS4ik3PAwStEj8tKXs veHrB6cOq/m27/0pX5jKRoafMxqYRg7qPsiHoenMF+jwzJdZ7Kg+Ez66MILADkXCG0An 8/ug== X-Gm-Message-State: AC+VfDw9iuohlVYRkZ/OyjuEwYdnQbTm4wKb0ZRZ+Px7eSMG5jAz5zXi QBpIo77Dv4LFry1wDM0KXZ5SdF3zepA4AvQiVSEtJJozJph16m3Lnivu3bUHPCONgkjo7s6gRGp R6yeqpNIiq80= X-Received: by 2002:a05:620a:31a8:b0:767:1573:d36e with SMTP id bi40-20020a05620a31a800b007671573d36emr4488753qkb.3.1687959694173; Wed, 28 Jun 2023 06:41:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5EYwd3DwX2vFwTswXmip/cui/gItGng+GTU5PNz+TRsCiUUcV7PXYj6w3sA6knSn3LjwckQg== X-Received: by 2002:a05:620a:31a8:b0:767:1573:d36e with SMTP id bi40-20020a05620a31a800b007671573d36emr4488725qkb.3.1687959693901; Wed, 28 Jun 2023 06:41:33 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id w15-20020a05620a128f00b007594a7aedb2sm5045644qki.105.2023.06.28.06.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 06:41:33 -0700 (PDT) Date: Wed, 28 Jun 2023 09:41:31 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v4 3/6] mm: drop per-VMA lock when returning VM_FAULT_RETRY or VM_FAULT_COMPLETED Message-ID: References: <20230628071800.544800-1-surenb@google.com> <20230628071800.544800-4-surenb@google.com> MIME-Version: 1.0 In-Reply-To: <20230628071800.544800-4-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 4E33F1C0021 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8mnrhea1hjtqp967w48uqnzrhi6got9r X-HE-Tag: 1687959707-135616 X-HE-Meta: U2FsdGVkX1/kpL3EVmy667E6wuVz9BF3jyxlrI9kQs7zwH91Maj32ugBUcT1QBPbTE7kpvErCwWFSmg68RU0f7lEfXtUytSaqynoLHQDBgbbeCs0MTtME1QwN6oSyoOwCqv9fc967JuXeGCwAky23AoFc3zhkzxAAIDzLHj4rck6i6v83e66nBj8VJs0tj/T+dNavOpszZqKm/sO/ucvr97mD1mlSjs+pxo7Dk9fxhThLfteTgp5BUDJt8150ucXco1MZzeXCas+V+ARFbe83kgQLJzZmwWOw3srxuuIsxmsoFnnmhkbTp8eVBW3yCp4wtHqUWxj4xxWjOs5CgCYT2ORop9GuiEoFujZI46A5S9FjL4/b28VetNnwBbyvZt8AXAUZq3iJC57E7tQ3lA85wwLEXRH7DX76YilqVQgzsvgEUjuLpN9Nd7uYap22yAoMrtDXb5PGss1rTD0QQG3aMT3CXQ+JrZ1Mj1OS47kMWYmQDZ8wv+Owum9MD3ajjnSiM2GmpNvmUxaO952GZ0Wep0RJEw7Z8B/0IfLThCvkqCo6QYXDlw6YYHF3Eryp3tJfLr1Kx3va4b/sXaYeRA/eypt8bPKk6t/l2pQf09lc0R1JuPKeLQARA5c5Wiy9dtfJ/oianqsHtJ7l5uSygAXr3Q0triUtv9JJBm8d4Eb+woiDHfBe39wI13cl8/snXk0LsgfQgdHEomWq1lv3DULtNM+u5fs2nTXczMXi4MWUD4Q0CZ6hRaL9Lp/uyLN6sdDMRT2mHiOi7xYA8k5X7CLzqpZizIdJfH27aOkl0AOE5gyA/yaiQggf/csVM91BDw/ggJ7i8pAY38BfmeO/wgkvak2jHcyq8goa754t4fsjIYV7mhN2gnE2O7wCZFkzWEmaG2lE0wC+oU16dVmyrflnD7XVj/I44NJ3lfjBVUAqqHtfHV4JzyqYGMxa/SguEr/EPA7d5mvOAXgIpAOloO GAeDbZRy DSL2oV/dHOJ7Cg+xNl3CSynBpWkqlcb1HqtKnMpC2ksLhHg+rYnzCoNdAR4jGmBMD9oTU1V89mVBKcoFv6jxu1UDw34bIgojg9MA0BjNZJ69dxibqU5e9GwZoA3TPog/1GaiIQcctAGYN6wS5VW/7Ifygj+IRc8Ws0pD6N8CJCKgtBmQkwEBOyo/IuEcvS52atsXUXPdAy1rDJxnczyocK3beU0Pze2aJN+Tk5Lhg+LcR4dpcYtgg4+pSGQaCTA7VoPWTgYwQnERc/3jP3btsA+/dkUy6GEo6RSfbFGjDy+P6AUo5iTSpWDgHMqoA5YOcR5dQLMZkGjXvCFSTHcvkZhzt2Sqz9zuAjP1y0Y/9EqZqG6UZthNE5Fqv6YCI2dkh7vHwZOvTu3c5lwywW3Ne72SF4ZtmC7qpLUpfWiVTkOLvfx+eTKoCdljidRJJFDslw3AWXQU570hI3ow= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 28, 2023 at 12:17:57AM -0700, Suren Baghdasaryan wrote: > handle_mm_fault returning VM_FAULT_RETRY or VM_FAULT_COMPLETED means > mmap_lock has been released. However with per-VMA locks behavior is > different and the caller should still release it. To make the > rules consistent for the caller, drop the per-VMA lock when returning > VM_FAULT_RETRY or VM_FAULT_COMPLETED. Currently the only path returning > VM_FAULT_RETRY under per-VMA locks is do_swap_page and no path returns > VM_FAULT_COMPLETED for now. > > Signed-off-by: Suren Baghdasaryan Acked-by: Peter Xu -- Peter Xu