From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE33CEB64D7 for ; Wed, 28 Jun 2023 06:12:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38D928D0003; Wed, 28 Jun 2023 02:12:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33D2C8D0001; Wed, 28 Jun 2023 02:12:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22C338D0003; Wed, 28 Jun 2023 02:12:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0C3728D0001 for ; Wed, 28 Jun 2023 02:12:12 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CE4EE160BAD for ; Wed, 28 Jun 2023 06:12:11 +0000 (UTC) X-FDA: 80951136462.05.2F432DE Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 74E2920023 for ; Wed, 28 Jun 2023 06:12:08 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=PzravfTD; dmarc=none; spf=none (imf13.hostedemail.com: domain of BATV+f172fe0960e33263820b+7248+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f172fe0960e33263820b+7248+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687932729; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rs013m832eycdbI7wI/qncGLxYKg/qYM1dV7Gd0Gkgs=; b=HuCQpooB3gmCDOswopzESTWf6wlRMbWlCeTKKOJnVinGWiX1HJRPjHjoJRHvMl2SbiM3WF O+RtlA1dhSY/O2oPpH2lVXTfrCtP5wot8ZnwQzQWsagD6AL55PEFepUig2Qy3HSvYuusb+ YuwrWeZ7/4Z+Hr3rTbvF2wDFQwt4FGY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=PzravfTD; dmarc=none; spf=none (imf13.hostedemail.com: domain of BATV+f172fe0960e33263820b+7248+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f172fe0960e33263820b+7248+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687932729; a=rsa-sha256; cv=none; b=JL+Foqqfy1N2okee516srGp9q19NT2fQS5yz96ErIqIWCsej8/4NeCN+iFTTxI/LQmYK0x ky/8HW4TQMgCrH656W5nJfnfk2Cs8wpaqSI8fkTk06rq0U5k4J9pv3VwY9sKcK19gGsM2e 3x0QtDpJ4he77IhEjsNmaklAm12ffiA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rs013m832eycdbI7wI/qncGLxYKg/qYM1dV7Gd0Gkgs=; b=PzravfTDeMUsb+TMMGGGfXMNm0 /Z81cqwcqFlZ4wnimgB3S34jrQT7TtJDfeNsq0Rp9+51TvLQeQ5POCJ63GZ/JsrYDBF/FjJg24ZON +Y1FYmcuOWNYI6Fd9s+USoL1cvMYY/KCPFyQN8f+R7PvI5kHiCzoK5vYgDe+rwVf33838Ax7S0h9u j9LFUmpfLdCXULlE0/kBb/6VitpuGNSBFPrSz9JdbQpAWykCCuzGgfB1rsnSaRrFGLoCDs5SDYmSu LS4a38URAovV4wOLKbjiT9EQeptPqZvIcMJ/6JUG9cM6eEscXGPuj696IVXcaeus6KbfXR35xL+/Q TfGlmw1Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qEOPB-00EwSc-18; Wed, 28 Jun 2023 06:11:53 +0000 Date: Tue, 27 Jun 2023 23:11:53 -0700 From: Christoph Hellwig To: "zhaoyang.huang" Cc: Alexander Viro , Andrew Morton , Matthew Wilcox , Vlastimil Babka , Yang Shi , Suren Baghdasaryan , Yu Zhao , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com, Christian Brauner Subject: Re: [PATCH] mm: introduce statistic for inode's gen&tier Message-ID: References: <1687857438-29142-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1687857438-29142-1-git-send-email-zhaoyang.huang@unisoc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 74E2920023 X-Stat-Signature: whgay48he8swwniye9hkgndkub74do3g X-HE-Tag: 1687932728-278235 X-HE-Meta: U2FsdGVkX188LeuhgeDCkvr1xCglQb/xzhFdGG48PqlY5VLshI3oVsRQ6Vie1/oKNBwX+80ke1LFNT4pPifa12f/KcDqAU01wXKDhrjjqN7tFgpLxomBxhnLrFsLkZvv1ecf8zWspox9S51ndt8uwSUnW19tTXiHux+93CQFC1DgwWWJvnfXNgyq4A6xHS9n6q25Cn5iYS6T19h9HobPdv7WvJEvfNNiFvvJEsU95EiB095A8B7jo+UUyBZMlrVsx8HONPb3T0AuW1O6lxjbqXtVwoRpRAFqqmxu8DZduQHvEqUOExs1UJJPb08eD3iPcZqlEhN/8Xug/8jofEXFlgFRVAaKcpLIWlEw5JWehU6IZBq7eRenQy3HK0p4qyus8Rjezt6pCgVnRry+ROZfJFjhwWLTnnjhALJC7XW+ZgZsJbigS2nET+kiYsEzUCmfRx1QlqWCRJ4ln3PpFUG2Ejtq00CER3/ezZGbCnJ/Ej3IiKk0ZCg7xPnnPHkCfS6VtzNYKYyS/gOVguR96aiTnHNp6qgL0Z1OLiYIxqoruQtX4aiiY4mz9zJXt9g+zoiCApZ9BCuv4wbv4fKrvfxQcwugXJsUzvvX/cw03CHwqwX5oey3IJ/dR7WzcWs8uQPZtN04glEqZgV+ca+I3Ii77qrt6kEbmdDkoWF7Nokn4YBBje7odHTk5TbHIwdk8XAey5psvGrwzgFfRJvS6SuEOIgBUPSy5SxOSswRRy3f2Y4PZUVu8VawnUxqX1VGRKoD/e80atTKPc8gZaQyaMp6+aJ5uPqE/WrGgeBacutOhrbF5uD2KTAaLKxljX7Lm9Uie0B8Cur6BuKit2bgiREvMn80bvWz5axxUIerUdFJa1sbpkFyTrlD5Qj+7IZ4t+QW8Nv6KKw94JHB925QD6+WtqwwrzPucj0IVDUbJVnqv4aC7FKDCf/hW4Xemy4BjT963WNlF/WklvULdrxZf00 /t8uiAjb nQ1WZb0KuhWyTQFzqfOlHcfqaVRxT0rnPcfgpHf++Ld6z8VPhl6ZlMS+KB07i8DFa6THxYarpTZipdLNBViT8zG0d2BQdCvkopVw5hk4EaMvfsYo+DV9I81+2RyxwpRS2DlnXZHuc0j3/CfB+ypjx+unWZtiC4WBDZP6cPUzBeeei0lcQnTQG7mb7Awam0Hy1qLw+kj+6IEmn/Umyl6jfoCQyQu4E3/lW5Vi4Y7nM6TzAvY1IgDbtdsC+9DN2uievlFXA04GNcRZcTYYo1wJacKAm5w48lOOisNHB2VSNS07J1oWLXHKIpCZ0gQh21r5jjYBeH98iqcQ0KwWLEgqogmTBelii3fgdFOCmJsoGAgnrcGKDQNBGZmeEFbGDn4Wlf1unQmBig+kaxug= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 27, 2023 at 05:17:18PM +0800, zhaoyang.huang wrote: > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -434,6 +434,8 @@ struct address_space { > struct rb_root_cached i_mmap; > struct rw_semaphore i_mmap_rwsem; > unsigned long nrpages; > + atomic_long_t gen; > + atomic_long_t tier; This increases the size of the inode by 16 byes, and better have really good data supporting it, as increases of the inode size impact a lot of workloads.