From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2AF2EB64D9 for ; Wed, 28 Jun 2023 03:10:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 445EA8E0001; Tue, 27 Jun 2023 23:10:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F5978D0001; Tue, 27 Jun 2023 23:10:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26F978E0001; Tue, 27 Jun 2023 23:10:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 182B78D0001 for ; Tue, 27 Jun 2023 23:10:19 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CD59CC0B06 for ; Wed, 28 Jun 2023 03:10:18 +0000 (UTC) X-FDA: 80950678116.30.4770777 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf17.hostedemail.com (Postfix) with ESMTP id 3894E4000A for ; Wed, 28 Jun 2023 03:10:14 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZJ2q5ojH; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf17.hostedemail.com: domain of chao.gao@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=chao.gao@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687921815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S+2Dwrrz2js1G/DCiLjGb9k2QIN8W48NoC0axczt0Xs=; b=lletE2VdvJz9+jb5azgjtd8LcliAERJluP8pRy+jTVzvIC2RPgcR9sDb4Huja587rJGKnC L6txMaEOqNNvjfbUPhaiof/8rHuMBY7gpnmRBC55qqsZd6vIeaaB4V7Grq5OVxcKeeAix4 bIq9QhjByV8J50UOZv4090izceeTkj0= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZJ2q5ojH; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf17.hostedemail.com: domain of chao.gao@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=chao.gao@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1687921815; a=rsa-sha256; cv=fail; b=Vn90Ekthl0tGIUczjv/hx8JFsvjlgqyGc1vyRqH2wukkXzl7iIFYYCpDz5QISZL+4TzjMe jziKhIh66NgErfyzXi110ywdCWI7hsNYjG8jrEEWQ5EiWgykIKseJ+NE84AWf7hMaspQOA 3QvsdZNcpPV17soiEiUX0Ky87iSwYvM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687921815; x=1719457815; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=V8NkDnbHcB5+Iit+1VxkloAb/ilk+/XIbezfBZDs3Lo=; b=ZJ2q5ojHcg6cw5PYNsLRbHGuONvguMZ+f2lBQVOB54KiGUARPFJA6wwT VphieXIbxQnGtYvrJzLAB5KRZAJQapKM9FqkWj8OQ7Lhiu/yz7M0UeWxK eTjf26Juav8QPaZ/KtsBsMv6kQuAowQ9SekIW4kVy8yrO3dO14oclhlOw 0MyLSRZXVvjCUX7fGzJPKqbe2suWTjbOc78jJ1+GwgeqNRrNuY+To+z40 xZUHE1Zs2ocpKCsoXLr8P62qnZS9MDxLZaFt8hTY8guzBoP1/a7fViHZS b1jouRfGQoaWN8KckZQ+/Li93r1sPj6VxE17TyA3WyY4ch/RVLQZMx3cW Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="342074935" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="342074935" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 20:10:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="716767948" X-IronPort-AV: E=Sophos;i="6.01,164,1684825200"; d="scan'208";a="716767948" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 27 Jun 2023 20:10:11 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 27 Jun 2023 20:10:11 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 27 Jun 2023 20:10:10 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 27 Jun 2023 20:10:10 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 27 Jun 2023 20:10:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PNgZP4eoAn4bniWADLXegIKsdb/nFtfphCFnv2B+gl/KIAURHSOaSQtx2U+EkZc+66SBvfbs9oxppholjpfzG10apaIh2LwkAJFhzA2AvVyoTvEcQQoRP3nz0JtaA0SEiZY962atVF2SEDO+/QCtnC43pk3ptsZOHusw3DEa1GD+sn7mztMc6wHFwK1qKNpPEUTUD/X/kU8p0oZDf5md8vNQtHVTxod/T7Q3GA5kPu7a9YG7BVWuYcV86ItaaMG26j99TbSg3GflA4yOqHjEtaxmqLgklfuiJs6Qt9MeGV4DywfzOOjcnRRI8xS0N5tzEollzvyaRLQ/Yk7uct/FyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S+2Dwrrz2js1G/DCiLjGb9k2QIN8W48NoC0axczt0Xs=; b=ccLMehj1viHviqsnY2/lEqrCYocEBdvmwnkUW4GLmMAArtCwJFk0pzr1jEtrl8K9W6Lh3OJm+QBReda4BYpvMn1GSaU5Dar4znsNNpHyvOHC+8DnPCvQ8G0QauIcmA+qSxgCCL05wlAn2qyZ2y9f+8IlotQ5gW8+NRqWwXWUHfy7IjyQWAo7DhJDoueprz/f7jaINPKRM32OFYhn1qX0zhUwi2TvGH3d/u+Ha6pGx3lGyfb60xLZQg48Sa8IVsCGMbZLVOT/xOAiRkum46NpwYZZx8xF4KAoq3R15ItgRM265aZQ+K4SQftwgDV2jYQ8++UhudSJRcSXMYVHef+I2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB6780.namprd11.prod.outlook.com (2603:10b6:510:1cb::11) by MW3PR11MB4683.namprd11.prod.outlook.com (2603:10b6:303:5c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.15; Wed, 28 Jun 2023 03:10:01 +0000 Received: from PH8PR11MB6780.namprd11.prod.outlook.com ([fe80::5817:cb8f:c2b7:f1e5]) by PH8PR11MB6780.namprd11.prod.outlook.com ([fe80::5817:cb8f:c2b7:f1e5%4]) with mapi id 15.20.6455.028; Wed, 28 Jun 2023 03:10:01 +0000 Date: Wed, 28 Jun 2023 11:09:43 +0800 From: Chao Gao To: Kai Huang CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v12 05/22] x86/virt/tdx: Add SEAMCALL infrastructure Message-ID: References: Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SG2PR03CA0088.apcprd03.prod.outlook.com (2603:1096:4:7c::16) To PH8PR11MB6780.namprd11.prod.outlook.com (2603:10b6:510:1cb::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR11MB6780:EE_|MW3PR11MB4683:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ac695e0-a236-4a1c-2a39-08db778528c3 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2agx/sSPv6bXwUMUTagc8kReB8MueMczByr0eIV5GGcBWLYOyZL+z0YrUyEJdkc89jitlFvPOODtsTEXVJem1z+a9GS9T0DgkMqQbKzcKt+qtHuEy+J/6qc1yRmFIywY8caccfhSr24+geAAPC52xS14eMx7sey2jQQ+C5l3SgdSXIHbypn4hwfr1tJIHmat3gy71bCfQ0qACCL0aEjdevkdV7wwNyfN/lPo5s4fM9SiRzxc9c0gxx8inFDYO5weeojmbSoNgwTxWsg6vAxEf3HPf+x6ddYVrRU7Xs4yUHCUPjdK9Qk2FLAHXmMTgI3wa/skeyGQkqUQVr+iQH/u2pfzwLxeTItTcIfFGH2hkTonMHh4KYPC+KJy8xtWU1n/WY/bggYZzbipIkSCoa9g4tDmZ0xqenP6rwa4NRGmT6s5CBNLEtOiaEsZO/iwQA3D96t+T/IoXSTcl7+S++m+xS/1YYzbo+8VJft9oMHD/ZzBCooExAhdQdu13QTepcfisAn+siN5JsluiuUTZSerLsuLfcecjFQ949B4iIdvIM8m64LAEA52FHPsIq3HFIGj X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB6780.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(346002)(396003)(39860400002)(376002)(366004)(136003)(451199021)(316002)(38100700002)(82960400001)(6486002)(83380400001)(6666004)(66556008)(4326008)(6636002)(66476007)(66946007)(41300700001)(186003)(33716001)(8936002)(8676002)(6862004)(26005)(86362001)(6506007)(6512007)(5660300002)(7416002)(9686003)(2906002)(4744005)(478600001)(44832011);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D/C0Wa+JlNdG6T45xzj2uTpK+r55ppb/TOl209DeQPZLwKE91M8T9FmhfeT9?= =?us-ascii?Q?YzlAQuK7EmzwQR82WiAiRYT1BsPmNEpc1L4LfZFUZShlH4Kyidc0fVZkdARb?= =?us-ascii?Q?EQtRaGNR+1ZvUYfyN+T3GxHakfTVWludD8LkWZNYojh6WgZYJ9oQJi0+M4sP?= =?us-ascii?Q?qU5BA/YtfyGkyNCBcOLeIxK56qEeQ8qG9l8uzp8PO6foyDxd8Kys4A28FkNo?= =?us-ascii?Q?fGYnra6u5vMyn9wj9Zt19DedokJP5B8ok2FfJujbs/2JGp0G3+Vlbe9x1yvc?= =?us-ascii?Q?udMBEwidRyydYivzrhgtOSFDMJDs5Gw1RFSch0ysZSYeNEwjzRO5up0nke/v?= =?us-ascii?Q?Vp8YmZuvcyc6s/oukNHFfGZ0bPt1gmWhXBzrrMzUyyS0wb/UegL5SZxjv+Yw?= =?us-ascii?Q?uC9kaFXLRZBXelVMmoad8AAJgv4qcuLmY5yK6WYd56uWl/w+tZSlqnzhpDo5?= =?us-ascii?Q?rslcN2sfJR257Yux64uuQeAV38XaUWUbgqtzgz7b0PpsCvNJdkgIS3fByoJ9?= =?us-ascii?Q?Nhj8BZmwwyCcWBZxM/IDwuIpIXWS2JC73sbuoMS+lY87WaaZSutoWgflci3P?= =?us-ascii?Q?Gi0/RVGkcc2G/motvnPtpvfrHThG0R6d94TAg4VgguzbMTO0Bv65stNdUrsn?= =?us-ascii?Q?WFFD9ntrxHx2/ujsLZQMg2RjHW43KR/JdKodq87LhPUT7IuilrbyxxQJ9Kbi?= =?us-ascii?Q?ckUQJUKAFuNLcNcptvV3erP4heShZ3e2s7aw5RCZRmneoC1oUPQmgcaW8Zg7?= =?us-ascii?Q?qvtBrmks0IjKgwfMeuI5eu+8UWe1/BT6yEKoJXX9wO048AH1TZPSfDsD83TS?= =?us-ascii?Q?bLERd9hCBYwl/5J1CNHgGzojwDPXi1vsfJeDXYnsrYA2jAqkWsQkwdqjbSzt?= =?us-ascii?Q?nOvlbf4J+/6deAsqAQhpI42t5liKU74k96xw2z5gxxUirRpmDskwPpbIHVAd?= =?us-ascii?Q?W4zDKO3lUhznpK9LnPgO7OceKIjfqiPkKi/9QE5pd9W4RBSN/TcY8p2waU6C?= =?us-ascii?Q?B1VI/bKfp/njlv8C5iYWtnq70R6fJAHS/Wt/9QJykgPCxwbzl+/SuI4w6Afb?= =?us-ascii?Q?iEoaUiAsOrDNOT8Md2UQB7N/98y+uSupFM+62Ylg7DUwxgX8DWiAefTD4jMi?= =?us-ascii?Q?3hkgitOyUsGbsZwiFofl340XJ6wwby9YrMjJAW+h4JrIDfC1GgCOQ36ZkWbr?= =?us-ascii?Q?sMt4CDej2pzTLDJqUNAh9YMPRskSMj5MrEJnVtBzqOna9xm2+gb1nvz4GCwp?= =?us-ascii?Q?WM7ZcYjWMa1ZRxWk5T8vlE2C+hdcP4W8BZECmw9qwjUzSA1oUQQ74uEBaSfq?= =?us-ascii?Q?ngo6ZyMlvLM6tbE2stWECH5Hrat9tvXH/03gnI7G1mz4GVSVZksbEIp00VDT?= =?us-ascii?Q?FBDnlpK/D6RxW82mvxhDHs0bzq+KFiU5JdNs8hCVSbhOrcc1l4qZokypTCMV?= =?us-ascii?Q?JVQMnQOvPnk6PSMMFR2LzxpRxUM2KyijnGXHzZTu7BxwR82mpEeEBFo5ewIa?= =?us-ascii?Q?AY4iS3865+eynp6tve/ONAeAZwjfFxkXJkWygPsra1yEoq1PfIcxqrdZx6Vz?= =?us-ascii?Q?Ir/0YuAp5FS/TImNV8x0OYercqxVsTdlawL6fbRa?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8ac695e0-a236-4a1c-2a39-08db778528c3 X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 03:10:00.4318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x7vNoHPdtYhBn+M3t6NJh/yxX871Sec8rxqgwq17gZiZGuDpdkcS+1NWAgAA6ez3UWl6dMoKULFH697rpKI0Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4683 X-OriginatorOrg: intel.com X-Rspam-User: X-Stat-Signature: n798gaqwz1tsfmt9dkdozq5uh4jf7qz4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3894E4000A X-HE-Tag: 1687921814-478580 X-HE-Meta: U2FsdGVkX1+WERwiEuoW8Ya8RThDTRbRgrPD9q5O1ane9PdjbpIhkPZDKqvguY81GZ6DiB5dadZO9AFzLJ92zWpz4npWcX10qwPeKzrlxlug33OJLwmrH1zEKqfZ5EFx9CTnM+f6lpMLx3N3K+0YY57ut7KHECAdWFHqho6oPfUOlpE9tuaq84q6xpfhBKCUjnr38rPFdKVPL/PP4aMZPg40GWmf+8DqpN32UXHF8Ll1Ekx6lwa/94s6ww/9l5hDXnTf4T/xNQLkjucJaI4l5FgDHnq6On1k5lh5LaFEeq7G6Y1CAU4T4MCDmZ0GJu0U0DF5etLeGsX2+qb7yKAP0OPWe2zdRjUspdwI2y88AgFklTV0sDGu8MSqDZhx/cBIH71RS05oqnKezoGFE/ITTW5WmaylLzC1TykZeXhlmhzkzPIvAbbWALUlAWXhvg0NcZgsP2BHiH9uSAzrOCnZLqEsXR8sDS1Sir/yXFtWs+h4muaK1+olQ3Oc8nxzcePHOOKY0BaY0G6PI+LdrycueYDmT1UDbHVVWFRVeyVoZR7MeG2wOXjMl8lSuAa8eW9GhiHalrTHL0CSH3YP5zg4hu+ReMM+wYCleyfsVnm5QvhMVyxPxOQZY86BgW78LUaKi5BTl7WQs7GmFq1lu79cH+l2SthxF7t1JT3hNgeBb478LffdiL1FqVI928ysERVkYK48Q+oJXUxzTFXiQQLMSBqnhIAsmPPdDX496ikrN9IW+8hKf7MWgWRWJksRT/Zu/JbCtMmtpkbwfEBErOKNquIwlioCv9xvRUY0MKRPxSNE2sHEa6jYuf7FEYAmpA2iUULcZtrW8WA389j0m+PwucrDQkeo67rpocJctMER0oRFSChafV/9rAodUB7sEWuNT97FlJcTNwHJ95iz4gsKlhBAC6xLcKaxteS2Y/YFW6LH5VRtSMjcH9kBTkmL5SYj/hlM4HuvVUVJdjEu1P/ 2nyNq+LY Jh8miZejsB1X/hK0QyadjlvVHnNDx2Vekgj6UxMfsl1RbTJajEddR/x7KCUtb5CecytadsmpgbByIKlQ+nS1cnNb3qlCrcOQnV/eVO0SNQ0EiKv9sClofTniqT1FohPZyNtA2axy/I0JK5RZD1z7eOVmEGrb46ZKGxGpzwq2deIOuQZ4ntT4KT5gtwC/AbtZDXIRujVaNqiXAhWst2Ym36VWbo0jXO3CAjG5wSUIb+c+GebiOAx+oGsstTb5R43/NlC2MpyN26K8O7rOyvt8bn0YZZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004660, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >+/* >+ * Wrapper of __seamcall() to convert SEAMCALL leaf function error code >+ * to kernel error code. @seamcall_ret and @out contain the SEAMCALL >+ * leaf function return code and the additional output respectively if >+ * not NULL. >+ */ >+static int __always_unused seamcall(u64 fn, u64 rcx, u64 rdx, u64 r8, u64 r9, >+ u64 *seamcall_ret, >+ struct tdx_module_output *out) >+{ >+ u64 sret; >+ int cpu; >+ >+ /* Need a stable CPU id for printing error message */ >+ cpu = get_cpu(); >+ sret = __seamcall(fn, rcx, rdx, r8, r9, out); >+ put_cpu(); >+ >+ /* Save SEAMCALL return code if the caller wants it */ >+ if (seamcall_ret) >+ *seamcall_ret = sret; Hi Kai, All callers in this series pass NULL for seamcall_ret. I am no sure if you keep it intentionally. >+ >+ switch (sret) { >+ case 0: >+ /* SEAMCALL was successful */ Nit: if you add #define TDX_SUCCESS 0 and do case TDX_SUCCESS: return 0; then the code becomes self-explanatory. i.e., you can drop the comment. >+ return 0;