From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3561DEB64DC for ; Tue, 27 Jun 2023 16:41:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B8D58D0002; Tue, 27 Jun 2023 12:41:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 868C18D0001; Tue, 27 Jun 2023 12:41:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 708958D0002; Tue, 27 Jun 2023 12:41:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 61DAA8D0001 for ; Tue, 27 Jun 2023 12:41:08 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3649680129 for ; Tue, 27 Jun 2023 16:41:08 +0000 (UTC) X-FDA: 80949092616.04.CA866DB Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by imf21.hostedemail.com (Postfix) with ESMTP id 44BBC1C0004 for ; Tue, 27 Jun 2023 16:41:06 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=inHfmnWw; spf=pass (imf21.hostedemail.com: domain of shorne@gmail.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=shorne@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687884066; a=rsa-sha256; cv=none; b=8JIA33x8CVx7RHtpabigdKJZQo8YPLhKodmKXSafaeGQpbE5w184hwkyLR0pUPUUlZLA8i P/zK9kYeyLe2OwEcMjyvS3R7wHig4Nc9nvHrAJrqwo5hI1xi3uY48GYdcNARST0lpP1rfU 19zFlX2EXaC2P0PLwg/mrnOUfLeSbCI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=inHfmnWw; spf=pass (imf21.hostedemail.com: domain of shorne@gmail.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=shorne@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687884066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tPqwuMIYF4VZddyTRxVW9wCbFz3nD1brpxZ4QBpbzrc=; b=tR23xXY2OX4XMHjDT7Bk0EBAUh6bnKRkNc1/D2XW9ghjmS0jtNd3Iqhl685KozRHuWnpXy lPAXE0TyH01y8ag14YzTegKwa0djL1zNDWPIiSHCUJ8krK40xmdIwOswXd+Xi1/NX0pLYR EF3Nbz/3I51pmzClJpZfO82nMr0PF18= Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-311367a3e12so6094931f8f.2 for ; Tue, 27 Jun 2023 09:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687884065; x=1690476065; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tPqwuMIYF4VZddyTRxVW9wCbFz3nD1brpxZ4QBpbzrc=; b=inHfmnWw4N5iMaE9pnKNs1SF/HQUZ4fMgt1Q0BJ4t2tE5ZNuRArKjepLCFgCDY0msK sUE5w/K5mwMRxDZimmJfnAg4gu5Uiv5ao5xkbgiT+ZOE2p+sn6KqvU7oWm/PfYExTRZA Kx5LPGjb5OorMDQE3n41+aRrVUbflFRdBjNvAkmTSIgOyosN5j3kU815skkp/4AQYjDA yHJrpLkEVTPmFxeYZsSmNKXDmSac8dShO/zmhT/iyHiVG5U1ssIWxoAXhReYJAZe32wb IJnupcTmGVo86npaNAlgfdOuhW5pyVlBgPb38MS1YETO34Pr+Nk6aBh1Rw8PFzmhutj5 h4Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687884065; x=1690476065; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tPqwuMIYF4VZddyTRxVW9wCbFz3nD1brpxZ4QBpbzrc=; b=NRLEjvMAMAb6ptQeh+3gq8i/Q+327TDSh7ooDcNyvkBAzsS0I5nfpeky2ZAXcKvrAC ED5B+WBEtbETZa2MilvXSnrFH2O+AXWgLCNQovO9kL8tyUE0c3Qlz+hjG4ImnFuHcHzj PqjQDt35/ZBqYShSVYZYtJ8VEta2DLYVHA7PHzes50kCypEpcW8SUqzIl113sy6+oiVO h3VtC6GF0e9lrUR/SIaKc8yeeJo1vZk8xKB4nqp9edNBKHKPqBISoPQ9xizbsJmlroMW EMUZnc2MqssAGS/Cc2yCaSju40N4Ud7EHsjut3ELVqqUaMgczv0RiuEKzkURfZoW5+Qp /d9g== X-Gm-Message-State: AC+VfDygi0IE1SBqylAf/LyNRTcL7v5FsUlW/aBIkrNW1r1RjVitiLgr aZdZGIAnnfCD2IOkgo0JgDM= X-Google-Smtp-Source: ACHHUZ6TUmmGbdfad1tP5CR0ZLqVj9ctsqGWz0wY0SC29ZsDHa930uyPrMN7LDJw0IVHNzz8FmHKvg== X-Received: by 2002:adf:fe09:0:b0:313:e6f3:d05a with SMTP id n9-20020adffe09000000b00313e6f3d05amr7993378wrr.16.1687884064353; Tue, 27 Jun 2023 09:41:04 -0700 (PDT) Received: from localhost (cpc1-brnt4-2-0-cust862.4-2.cable.virginm.net. [86.9.131.95]) by smtp.gmail.com with ESMTPSA id f18-20020adff452000000b003113b3bc9d7sm10876009wrp.32.2023.06.27.09.41.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 09:41:03 -0700 (PDT) Date: Tue, 27 Jun 2023 17:41:03 +0100 From: Stafford Horne To: Szabolcs Nagy Cc: LKML , Linux OpenRISC , Jonas Bonn , Stefan Kristiansson , Eric Biederman , Kees Cook , "Jason A. Donenfeld" , Dominik Brodowski , linux-mm@kvack.org Subject: Re: [PATCH 3/4] openrisc: Support floating point user api Message-ID: References: <20230418165813.1900991-1-shorne@gmail.com> <20230418165813.1900991-4-shorne@gmail.com> <20230626213840.GA1236108@port70.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626213840.GA1236108@port70.net> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 44BBC1C0004 X-Stat-Signature: o7odgenk8x4cprf33esjdgxwckzmtwzf X-Rspam-User: X-HE-Tag: 1687884065-560866 X-HE-Meta: U2FsdGVkX1/Mk7oa8qFH2rAKmriloaXa3J2hkWhywpIkA0peht1KxeBBuxtYSUkVtP19l2U12gKTF/+VrgEtKnZBjyy9mRkORHmIphCcqSUeNLftYKwgFhMo9cmVCgl0G9dCTQiuTH73mIzW1geACYRhAMCM9u6L4qlXPmg/blW8opIlQigPMOym6PieZQJOM9ZPKqRg7qvFXFCBeeMYWY2iXG2oQKj+6kW8sitQgdsPoFsSpgapO3TPhXa3xVwHKPl3b/K8x+jqn4hEd+h8dLbKo9anOy2ffr/lv46agVb6ycrtwhKZGBezk2/hQLI5rZhRbppxNy1tQ2yboNihXdTU5hStCY0WSg5g6g0PV4nPNszSIZOh2jakRK+MC2SKyKKo+kwLTLU/vd/DQGXZjlqi3UJyePa1iuqySt2uWy5gL9As1lgIt90M6gGhds/Yt+2TBzaPy2ORfsH0DP/ezQx/yj0vrlCaCok16DuoISke1X3vHA07kExWyhQQ8adct9JBB2wrCezAmBF0KVuhuUtAE7jEmC+kMQGhciPqeWRfFgo8VUuaBv/ajhwFYk4m3lQgIvM8xNXwZFbND6V0EUG6eg5XPDpzHXnDhSA6STVzjKsKcqpAJrZRCQBVqd01iHcxQPSAe9MUj8Jqj/I0dsc2/oFzOzzYsNivmN7HlyDiFpPCYpjFuON3Qjl8biHdrvgaLBiI3RxK+VMcpsaTds6ycCYMg8Cmg8/hvKhj2gnZ+X/xrGXjS4YSvHS9TCCBMzW3NqqFWHLcHLc1S05oIE0FB7yLBp4GEvKIsV/Y2ftHiFVDysLM5F+U7NuRmJ3MuVv8CEWaPgXvoMlbTOHlTzYsEFayUcC7VUvYzJ28PaNXXvqs80Ni8/TRFIWlbS1hOe8Mw8jbu0atG4x/0l1dXJ7ChLgaZPHrJbOeBZ9v6V+dHPT1mLQZvttpMRjlBnHotLgIuEoU+PEhNoBOZtx JevCDodU 1VjQHVWjMfiY2kq0LN2uZs0Z72CLJuyNwbLgQQOrJg64Pzp4THJhthg7mE75j+Z6eiz/hfOKWq8JmgJBv2M9aAL0uM7eFzrkF3WQv1y2cJQaXgGn9MFA2ft9MxlglQ920p6lIo+sK9GBdWFCaf5wZ6/dbF0WF6Nwqg+W4TaQ8QIftDEVKueDFaZysnpNCvgmDzhHtq8tuqNkbHB4wWZ+oEfPOboSUe9p9dVO0ygCROXipRz/ll1Zhdepuv0zIhWrqztIGiDsDNN+IIxMPYrvZ5yypxzGoBdxFLiSFmr5HF/ORR4EY5dLweu1pf+dFYoRqFopqHVxLkn+OorcwV866HoYZgWRawoNsq3ug7NMbopjrPOX8aTgGulNyK+QSxAUcrCm9CKRm5iXMDJNuwku5H+f8D4uiN/KQRJkBA/kgiEktOHlFHCk8da3PSE9+Q9dCNKN4me5nHC3N0w4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.012886, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 11:38:40PM +0200, Szabolcs Nagy wrote: > * Stafford Horne [2023-04-18 17:58:12 +0100]: > > Add support for handling floating point exceptions and forwarding the > > SIGFPE signal to processes. Also, add fpu state to sigcontext. > > > > Signed-off-by: Stafford Horne > > --- > ... > > --- a/arch/openrisc/include/uapi/asm/sigcontext.h > > +++ b/arch/openrisc/include/uapi/asm/sigcontext.h > > @@ -28,6 +28,7 @@ > > > > struct sigcontext { > > struct user_regs_struct regs; /* needs to be first */ > > + struct __or1k_fpu_state fpu; > > unsigned long oldmask; > > }; > > this seems to break userspace abi. > glibc and musl have or1k abi without this field. > > either this is a new abi where binaries opt-in with some marking > and then the base sigcontext should be unmodified, > > or the fp state needs to be added to the signal frame in a way that > does not break existing abi (e.g. end of the struct ?) and also > advertise the new thing via a hwcap, otherwise userspace cannot > make use of it. > > unless i'm missing something. I think you are right, I meant to look into this but it must have slipped though. Is this something causing you issues or did you just notice it? I didn't run into issues when running the glibc test suite, but I may have missed it. Just moving this to the end of the sigcontext may be all that is needed. -Stafford