From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4FBDEB64DC for ; Tue, 27 Jun 2023 16:09:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36D908D0002; Tue, 27 Jun 2023 12:09:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31CFE8D0001; Tue, 27 Jun 2023 12:09:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 196B28D0002; Tue, 27 Jun 2023 12:09:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 06E908D0001 for ; Tue, 27 Jun 2023 12:09:02 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C1C4C140A60 for ; Tue, 27 Jun 2023 16:09:01 +0000 (UTC) X-FDA: 80949011682.13.212AEB7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id DC5AE14004C for ; Tue, 27 Jun 2023 16:07:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SjfRakTt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687882069; a=rsa-sha256; cv=none; b=uB4cTI8G1ahlpcvAwFN3u3CgFLGUWWPoBwXxsX5EuGbWMNprVWxA1E1yP7NBTeZxI3YNZL Ag6GqjpamZLEjDo4VMqq2OapFNUDPUJ+D0+apVKm7DJe0O709BhA7xWgSDgP99TUX0vQpM X6jvhoo9C+Gg9Gm8X0FzXRyeo/rg20U= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SjfRakTt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687882069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hJDOCrbidQ6SQFQe4MgEFJjZ7UTNPrXFah4ZUMjVF/Y=; b=2mnMmnMp1uKVeB/flQEu6jINBG+xL7zDFeeJcZesX5xUOdnZUVrNBnw6Lr2ZvxuOjlN2ve /B+F9kJXst1ttl2M8ivoK/pyAbN5BSdoVTz6pIeHCWt7v6rXQUjsawnNZEcWeLfgxqF8TU HHh5s3QeExRVPl9kEuXJidMR0E8R//k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687882069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hJDOCrbidQ6SQFQe4MgEFJjZ7UTNPrXFah4ZUMjVF/Y=; b=SjfRakTtO/braA2aucjSiF1hSCR1w2x6dKgamdtleFVbmPKZFYfGvPux1Du1GHCdOSZ9nt eVloyBpUG2e5GWkH1a14Sc2FWS7gDFDC9ZRA6pnBwXooZmWVGNEGULTx7/DYDf4bPCE0rC NpLibRDkK85OVxQdtxnA4W1iSw2CN/Y= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-513-CVn2lZjON-6YB3VGcoIUXA-1; Tue, 27 Jun 2023 12:07:46 -0400 X-MC-Unique: CVn2lZjON-6YB3VGcoIUXA-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-765ad67e690so36465085a.1 for ; Tue, 27 Jun 2023 09:07:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687882066; x=1690474066; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hJDOCrbidQ6SQFQe4MgEFJjZ7UTNPrXFah4ZUMjVF/Y=; b=Pm5AhxZ4aFjfF3/aksae7SAw4s8HvpzEp9bJGpr7tV+glZl16uE6Ii7Xj5xY3iJvCx q8OiLnezmWmyY0vKi2keCOOnqriDiQzB0A+ptBHGKLy6BYxLTkYuFDGjfg/n/hLYDI1x ykiPrb8FOCfYB2MYeqGmAjYnkSQ+7j0q5zcHAMFUPPOtW2hLhIxzSUvErQ6ZdacUu4nt TIHwGrKedsI/vUgIHe+etiDUrFFMLCPJdNXPoDyFXnc7Yg22gNngGUdQ6BPet4g6b/0a h3Vfgq5jMXd0YFjoOGXc0ocs2YLct+l/cI1neOUyY6CQrOE1tb4mPApzknnqauhMvYZd /Arw== X-Gm-Message-State: AC+VfDxhF+547msxLHA3fFfMnA/KVmO0pjXEugPJA06S336OOubsS9W9 sHz3Fvb/7iS8UmEThztwHSnDWrx+6gXcUYjWtD98AA/dKScwv2YtMdngo4Y9wfFIGc2N7/GyKxM BaC5CnVVhsL0= X-Received: by 2002:a05:620a:4007:b0:765:7b61:46fc with SMTP id h7-20020a05620a400700b007657b6146fcmr12614176qko.7.1687882066185; Tue, 27 Jun 2023 09:07:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7UY1eApNq4tXkhQSQVDzyCNrRRXMA0KLJ6oWun1WyljocOJD3jbWnq1iikbRngPAZ/IFjT9Q== X-Received: by 2002:a05:620a:4007:b0:765:7b61:46fc with SMTP id h7-20020a05620a400700b007657b6146fcmr12614153qko.7.1687882065917; Tue, 27 Jun 2023 09:07:45 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id m21-20020a05620a13b500b0075ecdc937ffsm1342302qki.41.2023.06.27.09.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 09:07:45 -0700 (PDT) Date: Tue, 27 Jun 2023 12:07:43 -0400 From: Peter Xu To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , Mike Rapoport Subject: Re: [PATCH v6 03/33] pgtable: Create struct ptdesc Message-ID: References: <20230627031431.29653-1-vishal.moola@gmail.com> <20230627031431.29653-4-vishal.moola@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230627031431.29653-4-vishal.moola@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DC5AE14004C X-Stat-Signature: pchomtj7odhx4bcsi83fwrpgaypo7ttn X-HE-Tag: 1687882069-253371 X-HE-Meta: U2FsdGVkX19bnTs8nHpzvxi2IuGpLfcBNrlDZJu1x1fnwBCg7pg7qqo/tPheHgJU3uYVF6rJikNmpV8hLzstecpPglvBcPENNIb8jWgez4YLe4Ghug/toVyqVvAKQ+YqjstY1ym/uCrmQ9E642iQe4/3DAnrsrxjurnAjxmyhqqbh7twjZW8lX+x0xnvEHlfhl+xMG99AnlN5leE9/V6dPYQ8vENuhlgQVsNjFJi1VDJ4wrEUFKEveD64k9tH7GI9nY6hgWcURzAhs6lyIKdlokx9XW/fT+Z7NxBBgDzosVhLnUK+amHLX/qW2QZTh6CQlyFDN4ozKAYkRborhvjgpDgitsWMjnDKp4BU0hgs7637GA1HQ/K5dgUD5Th0tS59Y0Lt3dJ8ly2a6inDEIxBRW/aiNw9edHQevfk67onAI+0G4T16bMx7bgTmBml1xfyGGGh0ctyg+gXK3WcFr3UuEy5A80oDNFfWkLJSwUx48ALbNsiIxH5sRiIqt7EyV+3xqTKqBseDJ5o6fFFsucsOg4jdXNXyG/j3yLxV/0jGYOSVLwkw+QwxNRp7HQPUyooxagoHMpnN+QfVxHDsVXIt4aY+hVjsjqKqmqi0hOeSNn65a+Fzh9ciCOTRXt8pdtfqkJV8xyQkiATxFr50Ln21svRFjd1Y74ZzJ1latsFIDx5AXoeK4h8stcuHFXXoECZmAvE0K2ieGkeZCzLu82PLFKq2mPvt6XBG4BldgPWgICM41LciT6TlP2wpII7c2fFdz+exGC6/K085ztITS46jQL0Cvk1y0Z+8dh7Pn/Rq61of/RaesxKEKItICtW/ah0KhHDbBv5ITUGWf+q7DzSba5JyV53V408ycj/fvZoGZWFTSkzuA4ryKOn6kofyk/yHYa04hvWfj/Gn3kUzxkcqj2NbTHrjMBrXfLERN3bCmbQZkgBUnaBZLQSVkwrCQ6WpwfQpsY+cteKMvBBAn xQrXm/R2 ZwcMMCTAlW2OpwN295jEXp1KhVVDPtEqksMMLGVhnup4LT0c0euf0tDTnu/4pK04Difp+zXqew16DaFnK8pF7PB2EcQLRl0aDK1/29FsW8W3VKK+gOxh3C2FlNe2SJ2nuCspl+HW2tNPpymSe2Og0ZTgER2mo0OmqhZ60c8s2xZEwS5bqFcvQ8IjzxWjiPeYNFRcEKkVOdcV6mgYhDIbHbLpMG8GgHXMuHlLd4NJYRC/A5Q/384P/FfBLa+4nk4FljNxyoglhCfO1tWWbnT3zVzI6WLf79OVelSAXrtMinWHHQNbaQmSJCwqmfm5g6hVVlGhQrW41gf/Jq8Kuzm1p6Tv1l4YNgGFJDpxcbQAnxGoTKtKvoPpgcOJqWzJNH+cZse0mpUHWATV+QE/lS9kC3h5cfKnq5nu+OV1TtrtuwO08dOlp7vxUCzlx821WJro47+RLac3N5G+K6Tt9Nbw6dL3UQ6paMMCzrTV202EyKvKOmZU5snt4a8HhK3IukVYWcs3S2U6bnKxRHBw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 08:14:01PM -0700, Vishal Moola (Oracle) wrote: > Currently, page table information is stored within struct page. As part > of simplifying struct page, create struct ptdesc for page table > information. > > Signed-off-by: Vishal Moola (Oracle) > Acked-by: Mike Rapoport (IBM) > --- > include/linux/pgtable.h | 68 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 5063b482e34f..d46cb709ce08 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -987,6 +987,74 @@ static inline void ptep_modify_prot_commit(struct vm_area_struct *vma, > #endif /* __HAVE_ARCH_PTEP_MODIFY_PROT_TRANSACTION */ > #endif /* CONFIG_MMU */ > > + > +/** > + * struct ptdesc - Memory descriptor for page tables. > + * @__page_flags: Same as page flags. Unused for page tables. > + * @pt_rcu_head: For freeing page table pages. > + * @pt_list: List of used page tables. Used for s390 and x86. > + * @_pt_pad_1: Padding that aliases with page's compound head. > + * @pmd_huge_pte: Protected by ptdesc->ptl, used for THPs. > + * @_pt_s390_gaddr: Aliases with page's mapping. Used for s390 gmap only. Should some arch-specific bits (and a few others) always under some #ifdefs, so it shouldn't appear on other archs? > + * @pt_mm: Used for x86 pgds. > + * @pt_frag_refcount: For fragmented page table tracking. Powerpc and s390 only. > + * @ptl: Lock for the page table. > + * @__page_type: Same as page->page_type. Unused for page tables. > + * @_refcount: Same as page refcount. Used for s390 page tables. > + * @pt_memcg_data: Memcg data. Tracked for page tables here. > + * > + * This struct overlays struct page for now. Do not modify without a good > + * understanding of the issues. > + */ > +struct ptdesc { > + unsigned long __page_flags; > + > + union { > + struct rcu_head pt_rcu_head; > + struct list_head pt_list; > + struct { > + unsigned long _pt_pad_1; > + pgtable_t pmd_huge_pte; > + }; > + }; > + unsigned long _pt_s390_gaddr; > + > + union { > + struct mm_struct *pt_mm; > + atomic_t pt_frag_refcount; > + }; > + > + union { > + unsigned long _pt_pad_2; > +#if ALLOC_SPLIT_PTLOCKS > + spinlock_t *ptl; > +#else > + spinlock_t ptl; > +#endif > + }; > + unsigned int __page_type; > + atomic_t _refcount; > +#ifdef CONFIG_MEMCG > + unsigned long pt_memcg_data; > +#endif > +}; -- Peter Xu