From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17ADEEB64D9 for ; Tue, 27 Jun 2023 15:49:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71D6E8D0002; Tue, 27 Jun 2023 11:49:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CD6C8D0001; Tue, 27 Jun 2023 11:49:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56E218D0002; Tue, 27 Jun 2023 11:49:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 42C268D0001 for ; Tue, 27 Jun 2023 11:49:58 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 07468A09FA for ; Tue, 27 Jun 2023 15:49:57 +0000 (UTC) X-FDA: 80948963676.08.64BE3DD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 2DEF84001F for ; Tue, 27 Jun 2023 15:49:54 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Y6EoOj4T; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687880995; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WWk97apVhyJHDonX03+ZEK7CdXKLu5yLLv7Ry7RwGo0=; b=rf/+1ELikbD35Yv3qwzQo4ZFt1fq/OnLMmxZUiIXRkCfq+e/zUVf3dpQR59lRaF9vA8HKF ow5hrjAyjqfiGs1ttj2anK/b52K9JsMEDy6bdJyUHuezW1YAKUrZtHePtzMkSf0BXMHCBE NAqIFfdUe2GBneJH8mI+7qXowu9/TSA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687880995; a=rsa-sha256; cv=none; b=jp52Z4sfHWPD+gkXPh5rnbhsSJPyi5F8N1w2CalDQeaytufS/wl5tb0KZ2xgtRYsTto8VD bHXt0lnEzs7nwoJVHVnT5I57lci5q0sqjmlCi/Q1bpH/wC9N0r0jqFZcYLjbjenONv4ZNy zf4J2z4eM/VhiJYpetaNXN65J177Tws= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Y6EoOj4T; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687880994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WWk97apVhyJHDonX03+ZEK7CdXKLu5yLLv7Ry7RwGo0=; b=Y6EoOj4T+9RPl6cYvl0mhOUzuZ9wdbysh/GQLiLAL02Z18qHsdAk3lFw1YzvxKsoorMy/8 GCxZADiJbh1xuJCGOnpXMOn/I18gZsCK/4/7XijUewA9QI42e8LS8TjEcOgL4MC+fnymVy UFXGIc7H0Wt6f3mE4vBuBhy2X61vtLs= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-G_o-mGjLOnW2V7dhLeE5-w-1; Tue, 27 Jun 2023 11:49:52 -0400 X-MC-Unique: G_o-mGjLOnW2V7dhLeE5-w-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-635eb5b04e1so2596786d6.1 for ; Tue, 27 Jun 2023 08:49:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687880992; x=1690472992; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WWk97apVhyJHDonX03+ZEK7CdXKLu5yLLv7Ry7RwGo0=; b=RyIvCWorg1hP26EopjhQlU7NF3ua+bYv5ma8dO3ULd3XFLkpm//xlD5f+GD/+qt3KC bfthQNrg6Z+Dw9gQJMQ1E4hWstoOSQRrDgrf53MJVp7hdadVgAlfG4u6NvNIuyTGUZgW K+3rddVwMQxQ3L0+xNeiVGAZ4EEvyyu7yVPNOUfvXbuf2HCDezFaMumuJ5FUKPGR7Zt5 sXcE56S7uuwGmFtGfmlLqtcFFgF+qiexbkAesI3O8fLVQKYEWN8XIDPQNir2dR1GyamP /cRW4x6nwcNme89OjFFHZtCdnFlKzZXy2icCAC7GivHqYQhXJDAf3pwsfSBrCdnxZF9y bkFA== X-Gm-Message-State: AC+VfDyEOGCBf26zs16uTEZmFC5AW+V/vpeLAsRgu6b10ZI64XHTNDi/ L1yevdDQGiz3O1DqsxywZgVD7ki9ELFNrWYHf5fUA3Prjdmre17m63gmSoolUcTMG0Oe5iErp7r x1AOPrX2pJHQ= X-Received: by 2002:a05:6214:5186:b0:62d:eceb:f7ce with SMTP id kl6-20020a056214518600b0062decebf7cemr22553579qvb.1.1687880991693; Tue, 27 Jun 2023 08:49:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6CRo+5Jo3T9LBKx4Xlv3zmaVI3QEZGMWrv6tzFG6sXb500w5+qcA4m6HHVWBCmVoQxsCYlOA== X-Received: by 2002:a05:6214:5186:b0:62d:eceb:f7ce with SMTP id kl6-20020a056214518600b0062decebf7cemr22553552qvb.1.1687880991370; Tue, 27 Jun 2023 08:49:51 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id g25-20020a37e219000000b0076224a4884asm4086568qki.35.2023.06.27.08.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 08:49:51 -0700 (PDT) Date: Tue, 27 Jun 2023 11:49:43 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 7/8] mm: drop VMA lock before waiting for migration Message-ID: References: <20230627042321.1763765-1-surenb@google.com> <20230627042321.1763765-8-surenb@google.com> MIME-Version: 1.0 In-Reply-To: <20230627042321.1763765-8-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 2DEF84001F X-Rspam-User: X-Stat-Signature: whig6zyiqortsxxpq4azjjm5wrpqxyuy X-Rspamd-Server: rspam03 X-HE-Tag: 1687880994-14141 X-HE-Meta: U2FsdGVkX19+O/embXHawDtYclxgVVb5t+G/IPcdCYD20EbmVAnIIyYNXlNg+BPn7/gutyPRtZuDY/szNpknc4OVCKu3VZofX6fn9aak8vB5/lfts5jWYrVYPXi4T4Cm0ZO3Rmmbu+eO782ewb+hMcay/IQko4l/W+WkEyMo1QulzSqa1Wbr5qTkXEa/uYMRxPh8na+7Eqw7utrEo7Tpm5YvO27LLZWdhNBtEIbD7o8qF1iPmzbWbBYvYDhdNjUc4XayAfQqDe+UUksMictsvGzr8iwzHtR9K9tu/NCwT/i+G6Mmyncb8p0fyOitfdYVRMyXTmYUIRAgX1Sqt4EXD0/NaSDKryTzj9tOHTJvgQnRePfgUM9XWylbMZzKYPegdjfCU3fxmS1PRGtvuzELoU046Ue4hQ8XmpUi/ZZjGFAz0hvyagnDX19nFUdCQjni8ylDkotx3tUjQ984ASh3itYK90HuyAai6QsnLzKt91tmUgE37xpLboHmfjZUAi2YOrbBb7z/7nNz/yOcYI1gOmPEg4+4bF28gyvZFCrGDfhqYOo3BYYbzkExwbxRy3UXceUZ4Og1Z4gcfjdUQjrxZOo9PirDb5vpckg5zXZWs16CoxKKVBP17YrVTxksssuIzCX59kTcdAFVymCHcjm2nm7aFtmmPjXJhAYaAzmO37o3wbrgk0WzCnu0XML3KqZt8sAso7iqOfVnolpyKZd7VLZPHoo9iYJ2MdXT5ZhXbypo4V7H8VeunlQM84OsVI7AWxiCU4/b+dHqwrmcYmemGn9lpEaNyuVYkJ60adra/EtELfYKeDm7W6WkkkPizJMBPdsgLtCsGhBwoxTXMEdOPp4E7SIrA/Qp5+RDB2RoBUcsBffCPyxOzlvD51wXXUDwTK8FnUIYchSBwPZCylgOMOFtLDZapWH5bJ3im0UfDtFaWhJ73PXtlhTb1DBGmx5wOaC0CzI3bJDJl7Bh2to 3IlheT2F 5SobpcPxkqRmXV6fYw8kepm9pHYADOmCAEyKMbrkxunhwMMC+v3kqVWiBiXTS7Od9cutgkTTiy/FJDFApanpmc+X9POdkvklN9nBNRzXHwNnP5egy1uCdQryjbfBU9Zggo8vdR4N+FpdVmjdf1PvzC5lKZssAJ1KHFXhv8zlheHogyMokB4uECKBXS08nJJQltBM03PjCvlEA04waG5tXuvrRA30cnaL2PBox62DpCdBEu8/B+5JkMh6zIbTfxxQnaHFe1rFeluj2hk0F+Q7gZIRNRwmGRKdLappHupFKtA4evoIIg/+e07iiwbheBCuFnIVVXIkwBr4Gau9RehPT/LGVuu7x6PG2Vc0sxcMIPFsFu8cyLn5Qm+51aCqwv5W1OUZd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 09:23:20PM -0700, Suren Baghdasaryan wrote: > migration_entry_wait does not need VMA lock, therefore it can be > dropped before waiting. Hmm, I'm not sure.. Note that we're still dereferencing *vmf->pmd when waiting, while *pmd is on the page table and IIUC only be guaranteed if the vma is still there. If without both mmap / vma lock I don't see what makes sure the pgtable is always there. E.g. IIUC a race can happen where unmap() runs right after vma_end_read() below but before pmdp_get_lockless() (inside migration_entry_wait()), then pmdp_get_lockless() can read some random things if the pgtable is freed. > > Signed-off-by: Suren Baghdasaryan > --- > mm/memory.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 5caaa4c66ea2..bdf46fdc58d6 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3715,8 +3715,18 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > entry = pte_to_swp_entry(vmf->orig_pte); > if (unlikely(non_swap_entry(entry))) { > if (is_migration_entry(entry)) { > - migration_entry_wait(vma->vm_mm, vmf->pmd, > - vmf->address); > + /* Save mm in case VMA lock is dropped */ > + struct mm_struct *mm = vma->vm_mm; > + > + if (vmf->flags & FAULT_FLAG_VMA_LOCK) { > + /* > + * No need to hold VMA lock for migration. > + * WARNING: vma can't be used after this! > + */ > + vma_end_read(vma); > + ret |= VM_FAULT_COMPLETED; > + } > + migration_entry_wait(mm, vmf->pmd, vmf->address); > } else if (is_device_exclusive_entry(entry)) { > vmf->page = pfn_swap_entry_to_page(entry); > ret = remove_device_exclusive_entry(vmf); > -- > 2.41.0.178.g377b9f9a00-goog > -- Peter Xu