From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69250EB64D9 for ; Tue, 27 Jun 2023 12:35:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0FF38D0002; Tue, 27 Jun 2023 08:35:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABFCD8D0001; Tue, 27 Jun 2023 08:35:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 987F68D0002; Tue, 27 Jun 2023 08:35:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8A39A8D0001 for ; Tue, 27 Jun 2023 08:35:03 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5301E80517 for ; Tue, 27 Jun 2023 12:35:03 +0000 (UTC) X-FDA: 80948472486.17.67E71DC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf08.hostedemail.com (Postfix) with ESMTP id 6491816001E for ; Tue, 27 Jun 2023 12:35:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=SdD1LqmG; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687869300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bLHM6V+tLDCMAr7fezZKJxujMeIsDp2nC0aWxIi/UN0=; b=cTzspthDs7wi9zisabY2zvvBlp5aq6ArPShxliGc9cOPJAMmIWnUjOd+3HvVWWH12wfSFg F8R9pWBm6MJxcwI+hWKC7LKaCagS8ho7sjn5FN+j6VIgBBiHXuOFMKzpLlB5/VioTLKWM7 /pmb+Mgm6uslthH6I5tFNyrUag5o/IE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=SdD1LqmG; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687869300; a=rsa-sha256; cv=none; b=0zB3x6WYnAPWnepfv+2cPW7+ZZcx2Q/xoUEEpsRZm9psYkl+ML5ag/aXQEX2QJUvJg8mHm +kIhn3nlRP6mxq4wQWLgbWQ0kNvbZYkrJh3I8O7PniR9Dy2WUsFN1mWaYq2TZH/IeB/hoI MbA95arNI6lJl8Klzbi914wMPeOZ1O8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9E6CB218B1; Tue, 27 Jun 2023 12:34:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1687869298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bLHM6V+tLDCMAr7fezZKJxujMeIsDp2nC0aWxIi/UN0=; b=SdD1LqmG7UCtzfPfjuKZH9l1tURYMo2FK5WDMGMap5Y4YvMKQRoQSvuJ2C9gLqrjZw4U5X ZZCH9MuKt2/yQMYC5KJ151+Dk2OYTYltPTmvh9Eq31au80+upsb8AhPW0LSQk9WyETR4cJ S5TLPXu4gO2EFzgv+BV3iedKQOJc4KM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 798D013462; Tue, 27 Jun 2023 12:34:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id I7hnG3LXmmRiTAAAMHmgww (envelope-from ); Tue, 27 Jun 2023 12:34:58 +0000 Date: Tue, 27 Jun 2023 14:34:57 +0200 From: Michal Hocko To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org, Andrew Morton , "Michael S. Tsirkin" , John Hubbard , Oscar Salvador , Jason Wang , Xuan Zhuo Subject: Re: [PATCH v1 1/5] mm/memory_hotplug: check for fatal signals only in offline_pages() Message-ID: References: <20230627112220.229240-1-david@redhat.com> <20230627112220.229240-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230627112220.229240-2-david@redhat.com> X-Rspam-User: X-Stat-Signature: qzi1cphddfyr6zqzdokwsjeuepbkzzi9 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6491816001E X-HE-Tag: 1687869300-179037 X-HE-Meta: U2FsdGVkX19/LqOn68fNtIyD4Afo7Zp1TozP6rBRZMUwSvpokFP/sx8eS7WfEkFnXT3+uaTacTHBsPon9+1hqWze75RuQAWsPM3rhC4XC0o3pzfddCnybqFIguBVRWXN/y9vb4gaXAbyW3EZ4/UfOagAGYfcKtY5Ergef6nHLIHKUYATPR6B2xrBPFzRO9/G1IQ+RRzS4xeRdHQ2/GZiblOK1FUKSHjYGvDsrBRpakdFfCfeMe+cdrbc17aDHrKp0rDQ/MNEZcfnmzWP4Zo+5FFM7xSfk6C74gzkR+rOl1Y1Har3PmSKCmhCQFJZDr36kCSVSvvwbEmsmpmR7V3gxK2SuzWXlIY6qe2DLhXezC6hQConrUc+OR/2OdlXMdgroGvTNiNUYgM1MIzotNr+4cqXn6FEqolpKdmDZWnn4A4Cr5aRe99CZwDCueW+k/A9YweKrmO7fwVdyYMpd5EtBNOaEDBLhlCgwnDN+TYOQFpp7Lr8wcW/ze2kElvZ3P27kWcpUqFsKx4+8KkH3oGh4XEAh7BQYNSFgzqCi+ZKGoxZPokx1ezqKKpcXXFzTJAO6nkvv11YcseS0Vgo6kA/HrgOkcz5BwnBALHNhNKaTDW5zSq73TaJVRCen/l7Wl4YgusikGXN7N0rK37v6KIG4SQg/qpND/ifQH3s0ARqyoJmApGDALEKDhvq2xEJaTaQYBBgdIHZoC4YZknA9v4xQXhjAKUfWh54Fx/thnyDRbc4vHzO51QQKPNDBUxCvvB2MQ4NUZ8wXS7wJkmaE0XR9NmmDXpOBzdS8TCFHczKlroNO4n+IcEWgH416leD2nhLir4oXYB6xrdbt+GALltssQqVjKjPwozTJ1fLHFtsOYIuxkpRWXbARMzQdFbMlUcE/3cSbogOL5mgQmjgohyh4uhdEMGxEgYHL/sHPpPzadiWJVyUq80pZxkzFbaSzvJn91LEbB6maPR8cXU7WDm GXJMnlBF OPvp91ZOCQHQkpXF1OEZZ6X8dj1kwBo8S7tdVmO2Rur+pgDewm+zkcM4/v7eo3iqO5LI0Eck+PH13/TeEtX443wnZ0d3e0UAsWHp3ls36EsYqrf9jJ5o2lHcKIQCIZPsY+1Iq/5qOfBRbMuuIrE8isv87Mxd6q4fOe6VN1k0Abm6lgjc+njQX/7b5qjeIClLYYFeude/+53gTUlxLN8syyV8+kg4BAbnIbCTB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 27-06-23 13:22:16, David Hildenbrand wrote: > Let's check for fatal signals only. That looks cleaner and still keeps > the documented use case for manual user-space triggered memory offlining > working. From Documentation/admin-guide/mm/memory-hotplug.rst: > > % timeout $TIMEOUT offline_block | failure_handling > > In fact, we even document there: "the offlining context can be terminated > by sending a fatal signal". We should be fixing documentation instead. This could break users who do have a SIGALRM signal hander installed. > Signed-off-by: David Hildenbrand > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8e0fa209d533..0d2151df4ee1 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1879,7 +1879,7 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages, > do { > pfn = start_pfn; > do { > - if (signal_pending(current)) { > + if (fatal_signal_pending(current)) { > ret = -EINTR; > reason = "signal backoff"; > goto failed_removal_isolated; > -- > 2.40.1 -- Michal Hocko SUSE Labs