From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07717EB64D9 for ; Tue, 27 Jun 2023 11:08:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 674D78D0002; Tue, 27 Jun 2023 07:08:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62CD98D0001; Tue, 27 Jun 2023 07:08:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5135B8D0002; Tue, 27 Jun 2023 07:08:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 401518D0001 for ; Tue, 27 Jun 2023 07:08:38 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EC3AE40953 for ; Tue, 27 Jun 2023 11:08:37 +0000 (UTC) X-FDA: 80948254674.11.BDBD9E8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id C2BAE8000D for ; Tue, 27 Jun 2023 11:08:34 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=e1JCm0AV; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687864116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aiHsdcFdbTne0FqDQT/At35HF+CebE5/fvRBdL3jClE=; b=aM3+ofkPWiG/zTl/6xByyTWCibkyBk814gSWyf3xGZKP6r3ea7VTvnH3uAq5S2CN+1oEbA KNzrtCLR+BzGVkmNu4b7CWyPWtOFRGP6LPR+WrqVR7a5wTcBjKkIuYK4EAac1FqYhHd+Nz 6xdjz6s3sigCKRaHuTbYex7yA53H4XI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=e1JCm0AV; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687864116; a=rsa-sha256; cv=none; b=xLflGAox0obRIglO2c1ub1z+rYrJ1rA3OwQ6wcj1J6DF6wkL29v0hLJ6eXZ7Xl0MMyYxZ/ 8CSuwDIaY+BmOfJ6UvfSDv1b0EFMq+wYZW2wMPx5PEonrlj7618iLLqZfonHqClz9S5B8t ocAdf8kflWJ3G1+t2HNrvTWwsblDEm4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aiHsdcFdbTne0FqDQT/At35HF+CebE5/fvRBdL3jClE=; b=e1JCm0AVlzhQRuuH7L20hP1en/ mmmXaECSpteaMbbsjANEEOmcPHi7jaWDKqXSoBko4ELgk5SjkY0k/Dm/tpvZ7xFqJlv0DVN3HOxSm EdK7jGPSMQV0ikV5BZZUQ7aU7glxBrMqX/itX1usITYtxc78qpuGlqRw8jVrJFb8/pBJfinfIyA8d fQgmib4k2bgEMIDOmp7Cxb4noKr76/9CzA/oDJekzBQWF62f7y2uePqVi5CBVBsGufdRLW5XieA5p +UDJnjCpzHbRWILEhJPwP6Xju8HkfNqymNy4sklauET7ON/xQ+1iVQyj/862p8g5jaeh1KEj/33/P 5DaKqISQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qE6Yg-002eID-H1; Tue, 27 Jun 2023 11:08:30 +0000 Date: Tue, 27 Jun 2023 12:08:30 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 07/12] writeback: Factor writeback_iter_init() out of write_cache_pages() Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <20230626173521.459345-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C2BAE8000D X-Stat-Signature: dz894gnmagf8yr51u7u733iu89hm8wb3 X-Rspam-User: X-HE-Tag: 1687864114-283766 X-HE-Meta: U2FsdGVkX18NiARxDxIj9NCGhVzg36RRzy9fvr1DHdVsxfa+0XRk1QjcU11CEKYg/am5nsipsUDkTla1HXO35vpizPIlPYDeCxdLF90N41LXOVk6B8PYcxMvOrQTZdw3RUzhGaa336BdvoMu8q9kVECjREfjFcLXOuan8+S+oko6QFMfeFKrOBZ2fBOTUyd2dn0L8ZqkCxnYIJBL4/k3WzSkMv9iQ78de90nDLvqG1ScljZdzl2L3mun5A7nF95Y/z1exWmRY/Iq1Z7lprPl3AsIeXHTN1HryBaWTk84vYHjXSzFDjpoKJ1qhZ2kwQWyn0cF9LrYYVwuHtn/bGPl/E2AIF+fGG33Qd/TcXbyjthqoXlGL+lSOohoeQ3LBWuW4nCX90AnE/OA9D1S0pT13iMf7bqKZ4rutbn118bKs99hdAocFAjFYL31HXAYYMWlUpmQxOazKhlQXuw9SwV2vLxOQBe81XWJ6kAT2e5s+5H9I8pnWBiBLNwKPq1tN10WlBvxZ2D05wf4YHvW95e5O8AKW6pF7L6hOYdYMm6OtePjPNIpxT59sh5fXs+A1zmaxhpLvyhwu6BwyGLikEhu2GdKnLXDVAfjk+r6P6UAoGbJ5eShL127gRIsYOPCXtl1BZS7owmzzx8w4UWc5t/9eU135XIlgWlMMhNTT41+ILvbT8p4yEi50/stxiDCjOYlrSEBVBew+cFwMylYzigSVRqlEhr17r1A6nvm7fUBwLPAo9ZsGvnx54/9eAc4nX4A8M3RJtir3i9nUdDXYKwfJNQ6YAJE1uBFYQqhjw3OD2W9yBBMEWTS0N37rssLzsS9p+EWhEuBy6b6C1LanCsvTfNhK70ljDOLP/26Lb17ijwyAtYLymj5n5ElWpQx7bmZA6j6t4BsQoUOcwV71//1e77jGVTVMuBtqSwjPNpvn9vvqlu2wBmekwpgDaDROQXRugY7YdFLRMqjPoHI689 uoBpeGJw p1PFqY5KmVg5CEREmBNkcWT169IsEl9jN5ieCdaD5cTGHHMwg2BIvyR1ytlL08d38SA9njIgUwilxruIrvzqa/HEq1DTdEj0o2tkiHRIJpt4LYGk5iHUdF337FAC2ct9JFX/DvXf9wevvhyR7yxySgHb1hsJ/rkCjWU5inVIyUHJgygO2S9GGy2Zd6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 09:31:56PM -0700, Christoph Hellwig wrote: > On Mon, Jun 26, 2023 at 09:30:07PM -0700, Christoph Hellwig wrote: > > On Mon, Jun 26, 2023 at 06:35:16PM +0100, Matthew Wilcox (Oracle) wrote: > > > + for (folio = writeback_iter_init(mapping, wbc); > > > + folio; > > > + folio = writeback_get_next(mapping, wbc)) { > > > > Ok that's another way to structure it. Guess I should look over the > > whole series first.. Perhaps ... it's a little hard to decide which of your comments are worth replying to, and which are obviated by later realisations. > That beeing said. Given that writeback_iter_init calls > writeback_get_next anyway, > > writeback_iter_init(mapping, wbc); > while ((folio = writeback_get_next(mapping, wbc))) > > still feels a little easier to follow to be. No hard feelings either > way, just an observation. I had it structured that way originally, but we need to pass in 'error' to the get_next, and it's better if we also pass in 'folio', which means that the user then needs to initialise error to 0 and folio to NULL before using the macro, and that all felt a bit "You're holding it wrong".