From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CDB2EB64D9 for ; Tue, 27 Jun 2023 15:24:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 887D98D0003; Tue, 27 Jun 2023 11:24:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 837B58D0001; Tue, 27 Jun 2023 11:24:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D8058D0003; Tue, 27 Jun 2023 11:24:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5D1508D0001 for ; Tue, 27 Jun 2023 11:24:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 28E25B0308 for ; Tue, 27 Jun 2023 15:24:07 +0000 (UTC) X-FDA: 80948898534.20.66F52B8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id B5EC41A001A for ; Tue, 27 Jun 2023 15:24:01 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S3Urf7Pa; spf=pass (imf19.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687879444; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mpxx00XoyC132Mr6RO3yKQstSVhf2gcfuBHHVEFTNh0=; b=bH30RlxxjtlsZ/ja307iLlu9ph7hieQs6ZfC7Sx7a5JNJdg3cdbSFYB5dRjlWP7Y5dEB8J 6PXUynjvXxV+Rsq0nej5hotSLbyNMBaUNmmOtN7UZTzVyDNA9x4TpeLk6iwOf0HvfVjNQ/ 9ruNMxBHmm3xVbYd6XjaO2vfqNCbnjo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687879444; a=rsa-sha256; cv=none; b=VVWa/BGlcQRweH5dpm1+84Lxv3ZFnkxcf9Q7QQsaFQ+zFys/Mq1IRNIuzv6RKJGwKhntDx XhKcjwtLQyczISJwOgC1IFsHUNxD3fFPfzwO0CPba2buM1/nNqkoZ9Ge32aqldhpOrPwoi L4hSK3jTcYwiKOEsRoK7jDytGI5U2LE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S3Urf7Pa; spf=pass (imf19.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687879439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mpxx00XoyC132Mr6RO3yKQstSVhf2gcfuBHHVEFTNh0=; b=S3Urf7PapVL3OU2zCwUX/SFHYErNSUW7GplGlXb3NqVIbvcHz0sQpnqQhs4/jrgYswRX3I /4WRiO1ec9ewTD46NDAuZAVf6mnyw/tBJiXd026BumjQ+ZoDMCvzKDC9wVDLEuIrxKa/2G IEmTF5vrJfQ2RkqqpfAFbDHh+IyC7sg= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-bf2qiYOqM3m3WSexh-T1Cw-1; Tue, 27 Jun 2023 11:22:57 -0400 X-MC-Unique: bf2qiYOqM3m3WSexh-T1Cw-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-62dd79f63e0so7955706d6.0 for ; Tue, 27 Jun 2023 08:22:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687879361; x=1690471361; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mpxx00XoyC132Mr6RO3yKQstSVhf2gcfuBHHVEFTNh0=; b=GSxrLhljLfhklGYOhqPOBu773QDc+U+T6i664+79r5kfaKv61YqIi9lMNsp3uH3Q4o eSo05ZZRRADOAavs+KGmVM5w3a76L50S4INVAe+O4aPomQcoOsvri6P/QDT4aGxxwZUY Xy2CwPYDA1USrVv6wHLLaS7r8QolL6EBfkYUEPOE/0yc9eMh/RbQX7/WYUBtyq90rQki 8YNn90ncD7tcyO9pHuiGYBx9bwOew6Pduw4F6tqhrivIIkKhbwWinPt/2Bb+mgQeXjsh Xj5SKAPdG2ajvgxTqeqW5DBZw0BYKyyFh6J+FAEjb9JAwfkDDGBPVbxngrVW32tvmPYo ZlQA== X-Gm-Message-State: AC+VfDwGz8qMhjg8DcorHOt5B7ZDA75gz7g/qpR8Qrh8Z5sBbo99vRQX zDtKTM2D69NHcYOMGh8W/yOrsUBn5vLXXF+syAlf6hZ8wqxFOApYwGSW8/3+IsWZbocA3tR2DWY R3KX/X6GW3lE= X-Received: by 2002:a05:6214:c22:b0:625:77a1:2a5f with SMTP id a2-20020a0562140c2200b0062577a12a5fmr40561824qvd.5.1687879361513; Tue, 27 Jun 2023 08:22:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7k+Rvj2HAGIGv/kROiZog/CMhixAGLi2szEMwd9ZGPIqaz7MS5XLwAM8b1ix+sT9QAUyZ4HA== X-Received: by 2002:a05:6214:c22:b0:625:77a1:2a5f with SMTP id a2-20020a0562140c2200b0062577a12a5fmr40561789qvd.5.1687879361249; Tue, 27 Jun 2023 08:22:41 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id ej8-20020ad45a48000000b0063003786840sm4661038qvb.99.2023.06.27.08.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 08:22:40 -0700 (PDT) Date: Tue, 27 Jun 2023 11:22:38 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 4/8] mm: replace folio_lock_or_retry with folio_lock_fault Message-ID: References: <20230627042321.1763765-1-surenb@google.com> <20230627042321.1763765-5-surenb@google.com> MIME-Version: 1.0 In-Reply-To: <20230627042321.1763765-5-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: yoxmopkan5777s1ygthsjocyx3yhy4fs X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B5EC41A001A X-Rspam-User: X-HE-Tag: 1687879441-108527 X-HE-Meta: U2FsdGVkX1/D7BIHXtbuWF4bmKfL9miN3sP/A/2aqNw7U+RmSt4/tC6A0g1QxoUuxloVduZH1Ocsv7HeI1N8ZxZPTpu8F327Vpta0HJYk3OA72lhA6fYUrFY4Ix8HJqkYmNyG575DHE7YA5TkcgoqD64aMAsUDW1hnp7fjsA5SuhbHoM53BS6wz8IhGvEjx0t6mp2SdrUlaewLxhzJa5O8w5SN6+LXQ0XLNst4GXHJGvvb80ye/DFVBCwX+nTLYp6oQ7kB0YpJpxCUz40rZ/0P/2e4Y2/1eHjer8AG93X84R/Qvov2g8EO8IwpIFmn8BRNnjcRQrXxwNdlqwc4iP/OAFNWhMFAYmAcgnq5TjuJ0seL07M8yXy0DC1NCmvK3bhAHi+Itvza24h2Dwwy/alCn2E2jy8n3r1oMuH/wBqVY4itYEGwYbST7czHzP3s5PbO6qWKiA2C8T1UXeZomGh+8T+29sHpB6SB1S8/4n8THTrsarN9WCFq5NZb0Xg2raiNwJ4bLWiL9KQLULUbS5rI89VpIzSbDIjYDc/Y5YMI5eq4s9J/5nMtEYNIB1MVhJcEbf8ttESSQ3QdiD3PtXbrKEubSvtIcVmTri9fPSsKRdZewbSAn3q03yhAYLZS+EMnyV6bczxLs2TQTLsxBEhrVn54wrhXt6hZAkjO4Oe6SlRR9byjjMRbqDxcsR83eC/YKoocWkUYlFkybM0pYPZFJIQnkFNlVsyEkO4CcBdKSk977lo35Um+dcYXQgg5fwhqUwk3cu1VOSsIF41+m8XEoVCOG3wTJNFsFkih/ZIW10SqCNJpJiT4qEq8tNG3VylTFFmeP/pzwneXCJma/ZqiHNYCgEjjEbuRgsf2YS3hgbv1ijlcbrWuoQoxupmboNewwYK8hrO2NQi3JBMsduf0CGBuwlg+6JB3rRoNPDfN0mTeoB5s69Ikvo6A4spbrh0DBA8XF9a4FsNQEaXJi Ph0VuE9W 9F8KVksWYhP9zWZsCb/BzA7vp01jO5mlIuqbSaNijWX+EZzK8uP8XazfP2vFdQdOuoy6ziWADo9r7C3m884shY+BbmmycyUx3NXXAICreVqfnRF43K/t5mfPQcsO96mwg/AEhk+njYEQBrtn7MYfcv/fyqGJ7nBLAUlAAI5EwC0VJ/AGm0ztMtj0lpqTAxZkk8teZxdUZkA424vOOoaNoywnhqAnw89Hsu0P6GD/LUHFstWlBarmGvusB1RB7jkrbybRfVm3lp86UYmCDdXKHapSDsI8Nf1ibxiO3FJUA7hTm5TlchW11Y/ScdplEouegebLRODjOlM/RyeU+lz+alvWFBfDKXDc4ymMqEMtS9X31SpgvjOJZNkxKGyc6rf9s3Hzpf4X2BQA0IoBHqmET4vsPreWj1lnQ0CumAajbN/iG+xEsrLUkRPa3FGc40dHYwrIxaT6gdqW9kuKUiTSJSnD1/0+Gyi4Go++vjzW/kTK86Mc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 09:23:17PM -0700, Suren Baghdasaryan wrote: > Change folio_lock_or_retry to accept vm_fault struct and return the > vm_fault_t directly. This will be used later to return additional > information about the state of the mmap_lock upon return from this > function. > > Suggested-by: Matthew Wilcox > Signed-off-by: Suren Baghdasaryan The patch looks all fine to me except on the renaming.. *_fault() makes me think of a fault handler, while *_lock_or_retry() was there for years and it still sounds better than the new one to me. Can we still come up with a better renaming, or just keep the name? Thanks, -- Peter Xu