From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A2A0EB64D9 for ; Tue, 27 Jun 2023 04:34:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD9168D0005; Tue, 27 Jun 2023 00:34:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A88478D0001; Tue, 27 Jun 2023 00:34:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9779E8D0005; Tue, 27 Jun 2023 00:34:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 795B38D0001 for ; Tue, 27 Jun 2023 00:34:21 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 41CC714035F for ; Tue, 27 Jun 2023 04:34:21 +0000 (UTC) X-FDA: 80947261122.19.AE7B56F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id 946FC1C0005 for ; Tue, 27 Jun 2023 04:34:18 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sPT0T5ng; dmarc=none; spf=none (imf18.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687840458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OPyvNcbViu0Zlus2gx2uWO9nU0QCMLp8MGnwfJjfufs=; b=EFsel4FV6TWoAcSwJD2uZOYoAUMrH5kFL4Vkc8elRaOQL18IEfCV5ynSqLVYQVT2duwLb+ wSGCxI4BLsEmosadcPtQH5L0YF/59ku/ceKAfgxKJhxExXRNy/8T9W6quSIrU/EcvT2+2w +1+kvwhOnjhVDw2vYB7Q1P5he0GuF0I= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sPT0T5ng; dmarc=none; spf=none (imf18.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687840458; a=rsa-sha256; cv=none; b=hFTY9X3SXQkPt1QIwKxz7ZF8b3scr9zCAdCAMPEwEZh7aaRJSGU9tddZDm2g/bpwdMIm/R FiNxDe6x44VwaEb1oHKnYx/yxNfkLnxbZLUJ3dM4UQ5E5NtcGboQSYXjBbCV7nIYUUaSOq naak5MfeLwoYAXJHnjC+RIyA2F+ZJ4A= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OPyvNcbViu0Zlus2gx2uWO9nU0QCMLp8MGnwfJjfufs=; b=sPT0T5ng1PrkKAcoSvEjnolUFa S2r+CVP7sb0O3sLUzDg04yBIb6xSFyQnoQ8jUR2bIVivXsgzhIS7lbbZPF7jIZ0EhMDwjpLFN7pDF O8u8uAV9zPQnBTCzK1a3ISTbrYC2TvYC+HMpUmEuKepypA+Uk9Up7eC2u6MFYgBJKBXLWq0XvNnBJ jATozQTsgwi+oKlcCQGoro/1cfVy0Q6FitbUuhPWypnaOTPvBJIH8pvBTFi/IIufwP1GsSCffPFLO jWPJ+JyVaEVOVEYjC+e/56f/YIavqD7wuIanhpIi6WqvdgBJKV3GLYWdA/13I/sq7XnfF2dZj6SeN 3oDuhwMw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qE0PB-00BhMI-1G; Tue, 27 Jun 2023 04:34:17 +0000 Date: Mon, 26 Jun 2023 21:34:17 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 08/12] writeback: Factor writeback_get_folio() out of write_cache_pages() Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <20230626173521.459345-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626173521.459345-9-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 946FC1C0005 X-Stat-Signature: dqhewkfwsd84co7h5p99uziit74jczwf X-HE-Tag: 1687840458-728133 X-HE-Meta: U2FsdGVkX1/9gE9HMtODSvO1PYDTndcx0r++a86tZZa2T6trWVkQCa23HLW51Kmp1M6BoRMW1Dhr7UD+tYWzACbFXRO8XSd7kOzGDEYIxhFqsM4JWdEDWix5s4fWX/2Z1DRP4eOKNNDLKtUzH3c1w9a0wqZMWhTenXaxmzqhVtohOjW9ydSzr+pwKCOOCMInieNcUaHFuX0aMe7VK1JkwHLQAiAqd2Z++PyGPN8uaJ+I5O6BEH4eCiQI0v93mQENeTG/feDqQc8IwhyUQPVrZvFEuPL5mrHWNflpcUX5swn+y1V3wTfE+xQEcguCMrxCy5CbUvt0UNaSBMkSBTh9pcmE5K4eNuCw89wma4VhHIc1L2XTvrCLzwIaCr+tFEPHDBZkj0AaSLatd6Irk8bdUREBUwPLj4qAMzCw1tv2a05A38Q+kw52Kvh6ncG9vpj25AwTklIG6kLGpyRa6Cju0zicERQn0/hIVsj//AcJaQIdTaiJDz6cPp+yS84oJ6gt7tUG+FXdBmyjeko5gh3xmORkD5ord6l9HU2HQqAEajyjabrHZ3ifg/eLhtvmA1n1T2MrpMixIZtCgjintPvc93Flc4FloZE5/0qpxgNR+xT5ZGwLiOJQVFNM36IqL2sa7BUzYKwRJ/IhU92LqnbJzKjRXF9sglVg4qyA26iiPE5l9RN8TdGY0tCJAN/eXIHx5bXUZigTEixqcFNCbNKgors4jXiZi5+1w6RB24f7SMrWotvgM60n14Z90BrqY+7luux2tXNnWgT0TT2ZGK3tgDCQIBTClzy5M8GJIESz4oZjOvOsglnB7x2tEUOEjguo+36AGKNRPUpBs76D1Sk2MHsq7QkN23nnO8ByFnd+JllAAahEHsC1x7V/3JrnWc4hPQ1N/3TZz9upvIkpx0gkZo6Jmng+ksTZMCat0cVY2VMRAxm2CzT8RWTMZn/VFisfeIreqKuFdzSyHlu54Rc E+yN1iYC ePJVk+w4OILafg4pFBPXFzUNgLKdDKT6L1iPUJ2RhcHovC2463Noo8QPBx932VRH0Z+6PkIUbPlVLMNiQZsH1LtLyJQihSpRd1NCM2+9YgUCQ6O2x8Pc8Wq8NvkVEWdia3NwKr7VjR4cRxcbFrpvBOkmuREf1TwBXf/7wbRBY3MXwQiGnSuLm3VH6Kn0yTla/9axq/3kQr4zdUlyll9Wo1rUam+estfFKzUxT8xdj0x9FgEkIzutvOeBaG1YJ21gdYhafOtScpkHGn8mQdshrUHMLqQgT7VjcNFznnurFeW67P9lWnMHG+5kBOGx9IrDvW1vV0a1O+KeSWZyIf+wj5z2Iris8PKlqycIKxvvx4lJlVu/A3CFdoiQLdOP0aBmypFpHJkamlUUf3fLndpxBRDWU6gp//0kfo335mmiUnVzzJyMNDk3qCpg4Vg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + for (;;) { > + folio = writeback_get_next(mapping, wbc); > + if (!folio) > + return NULL; > + wbc->done_index = folio->index; > + > + folio_lock(folio); > + if (likely(should_writeback_folio(mapping, wbc, folio))) > + break; > + folio_unlock(folio); > + } > + > + trace_wbc_writepage(wbc, inode_to_bdi(mapping->host)); > + return folio; Same minor nitpick, why not: while ((folio = writeback_get_next(mapping, wbc)) { wbc->done_index = folio->index; folio_lock(folio); if (likely(should_writeback_folio(mapping, wbc, folio))) { trace_wbc_writepage(wbc, inode_to_bdi(mapping->host)); break; } folio_unlock(folio); } return folio; ?