From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D45C0EB64D9 for ; Tue, 27 Jun 2023 04:32:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 709038D0003; Tue, 27 Jun 2023 00:32:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C45A8D0001; Tue, 27 Jun 2023 00:32:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5803A8D0003; Tue, 27 Jun 2023 00:32:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4459C8D0001 for ; Tue, 27 Jun 2023 00:32:00 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 14204C07AC for ; Tue, 27 Jun 2023 04:32:00 +0000 (UTC) X-FDA: 80947255200.19.C73FE04 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id 594C280004 for ; Tue, 27 Jun 2023 04:31:58 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NAnu0sEL; dmarc=none; spf=none (imf30.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687840318; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a2dR7xpPIXwa7mgxrA3ZYrC24teMCgTKOM+0t+zuPts=; b=eOzn/osi4ZVtIAO6LWnrLI85ZQCjl4iVyQVrWaKGzaqef+3QXX67PbNWonsALkgXAVBP9k Wu4Ov+Xao8nx8JLEOzE21AF6zOL6kAn9moOR277Qb+TdJlO8ODs62pVr5OUFPoO/45iocm x2TVoEw6hNwHx8nMCxt9ZloKUVVtprk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NAnu0sEL; dmarc=none; spf=none (imf30.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687840318; a=rsa-sha256; cv=none; b=nwIIzkWf+urujijt7JB60Q4SW2CeswNv14m+eewr6516Gl8hi/meCeIf0n3u7aQK8B4FEq GqjgBkTLGJt/U+l9ImDYoS6LeKgJNR/81TKto0zjmXJ5kYzCAa5TTsECdVVpLjdUapFEt+ Q4MyCIKAsUDmW9/VLZvRVgFxFH6Cx6U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=a2dR7xpPIXwa7mgxrA3ZYrC24teMCgTKOM+0t+zuPts=; b=NAnu0sELXqjPhTmBs+owObHvJ1 Y8QXdx/O0B8x9h7c8zwr9S/aT3AzDtTSi6yj9ZU5tvT4HjQcFd/ZPyuif5a7LIMPkrQVOaCS80w2C /fVxFqPBAy371n2w84c/K69IY3QaDcrZtVPJfatNWhQDEjFM1oConavbkIJjsZsQXOZeo2jYLOD+9 BbJB/NpLw22IILLQHoKBoyTsDMrVaN1s65BkvkB17qym3YNhoAEZYP1Eczk6KHeAUAdVAJducqCzd fzs7eGHb+dD64gL6Was8/8odNLBv4ySJlu0W2RqmgyTFXCfe1nb0ZsRdf0MMzWHhJ92ZcdRQccpcO YhDDW2/w==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qE0Mu-00BhBJ-31; Tue, 27 Jun 2023 04:31:56 +0000 Date: Mon, 26 Jun 2023 21:31:56 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 07/12] writeback: Factor writeback_iter_init() out of write_cache_pages() Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <20230626173521.459345-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: xsqaywdxr9c9d97g6hsw191nwtj8gqf9 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 594C280004 X-HE-Tag: 1687840318-393281 X-HE-Meta: U2FsdGVkX1++rdlHl2+IZSD97XuPnNyMLz66tNzwbPb1zs1t4OKPB0JJxqu9ngEpDilI6OUMbXRKhzJs6R/Ih57bXp/YNMRPIMbORBZDqBLfAEoBQBFKNw3EmXQj+Fj7xbd1iKFHZW/xJuuEPf0OVfbHtKD6gQk3OQjtGSu4pQHK83GUmPOa7e4FyjSPixCUbrZ2KCH6zjjJQUo2T6l8p2UONWhk+ZDm1bg0PTv0xDSS6uRmesa/+vufqPTsKWbaro30ubyxpDmyT6Vm735x4bx4ZzW8Xm09hJHqBp92HcWJcy9dYErBmoXyQAUD/YsoNkY+/weOtGQGyIkXp+E8IPp8HzcyJto79LgZiZFGg0UgdpKwE/HYQzSqEHOyC/IZmEeeTwP5+5lq7qOJo/N3KxNnezSQPPzkOTFDz911jknE5xJz6BCdo7un8/7RnDN5zrZLvOlnaKtNd0PCGj4SklXTzr4sQI16xHZ1uxEMZugabUl1iovFkW5BhI8F+TCVeKivq9St7SnVtiwNA1FkbFaAMV5s/W5cF9cPtG6XyCB22g9Qbcdm37vsHxCnD/vQVOUlYXgGSz1C2Kk3W9eUAR1dwW9vkbY1j+VT471S69xosr+6Uy9pHCo4t9V4zvgzM3d2Tb8oWUY5nhjdfWQfUBLDaqb5YPNcqk1DRu48k7XltxW4xwaB6Dphg2Jo/8o2IA1C9QVvltvzazopz5YgKHv9fAmpe9BX1XRJA5iVMsCMbOUuJfHLhwwTfGZznwMcBZAa4sdzPuA2pnrZ3VroM7fThgo+HT04NXr/fNEI3YJ5wpFi1zu1rbiTwq2SDDEsmuRvLweGg3olZLzAN2SOl9lwu0nXqxj7hyt+z0TjQxLmYkNlGSFzYv9RMSSl+5OHpgee6qx6zHCkvaq4E+T31LZ5fY7azbraKotwhJIsnn2eqBMelKNh1jaLhjaQlSDgqBYO1FY5gflzNlP960g qxZSk0/L QzcSBNw/5nyFEF7ruwlvyQHfXkfTPLXvchStpH80nW+g3JLj2EsxNCKv04MnCzBwjZh4uLUYx9OY2Pns2n3c/8ALg7M8fTedG+1MquXEy1YyUYLLFbmp6j0rUku3BEerPARrn4iCr5tQLxe8IJDjzp5biNmOHFoDkxZTTEYehNdJhfgECX/snaPVor7qf6BDTBJM0nwqDrAbz7WOex3YrAchDZK1ngIJCoYImNjzzUHhzz5bxilINOxaIczsYn56MNMTAGzRbu2dBlkkOXUuQvtqRBXSjMg9ckbco0gHSpVSzeIMDMVDbq1CgH7SWzo0u6VXadVFE37GvcY+jYmc/fTlK7lzpY+R2exoOY9iNAc2WMpFMrEPCn3VD+BL9rOOVNsE27P+1Nws0mE36u9GQUR8rGCZoJ412YYB6mZ8sGHVDlhMOSlnJj4+1HA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 09:30:07PM -0700, Christoph Hellwig wrote: > On Mon, Jun 26, 2023 at 06:35:16PM +0100, Matthew Wilcox (Oracle) wrote: > > + for (folio = writeback_iter_init(mapping, wbc); > > + folio; > > + folio = writeback_get_next(mapping, wbc)) { > > Ok that's another way to structure it. Guess I should look over the > whole series first.. That beeing said. Given that writeback_iter_init calls writeback_get_next anyway, writeback_iter_init(mapping, wbc); while ((folio = writeback_get_next(mapping, wbc))) still feels a little easier to follow to be. No hard feelings either way, just an observation.