From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADE33EB64D9 for ; Tue, 27 Jun 2023 04:30:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 498F28D0003; Tue, 27 Jun 2023 00:30:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4481D8D0001; Tue, 27 Jun 2023 00:30:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 336E98D0003; Tue, 27 Jun 2023 00:30:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 254C08D0001 for ; Tue, 27 Jun 2023 00:30:11 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EC6E440879 for ; Tue, 27 Jun 2023 04:30:10 +0000 (UTC) X-FDA: 80947250580.16.70BCCA0 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 3DEA8C0012 for ; Tue, 27 Jun 2023 04:30:09 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=mC8i7Dn8; spf=none (imf22.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687840209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+r8p/v5s7wbLIPfSeJmQ/Jnc8OoL0+y1yUUWCSbGtuo=; b=l0wVb/yF3h3w+3AYprtNhlNHxU23xfsSWezN8CzF2Xhx8k0roRzL/Xohv1eFvaL81Q7GEd YOYpaeP0mtZyMZhRa7x4MlvVXNoL4DbBbqcs6Q17vMqKRyjRC1TEdJufFbGls15R4Omy6F 6CSjbh51Ej5afx2YbuW259J85rgPqi4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687840209; a=rsa-sha256; cv=none; b=7frrnDeNibktg5enkphqmZqmPKzxs1Ynsxx7bYG6YcuLG8PZmYIPxk39z6+4g4gg5AGrnh U1V5r5NSkdQC2K/Cur7AguQ8ovijm8zFL+1kHUkExDToit/e0SOrBc8ckIn+kT9GjW7Ob0 ZP98umyRnuS6DVaxPkoPHgOdg37kMdc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=mC8i7Dn8; spf=none (imf22.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+r8p/v5s7wbLIPfSeJmQ/Jnc8OoL0+y1yUUWCSbGtuo=; b=mC8i7Dn84t1nQu2SXZOo0VXBPi 6GNIEqUOKZCP4LQWlB/pldb33gsvunRvnV6Ukm9rE4T4N7kH00nBcG53PLhHmcWdplIzyAUkSunGW Ovhky/bUBuI0LV5kB4QKOOFCWm2IYpOwskAcyfGSoCRwi/InTaYQQoi78xUahRsiX/QTLbhBkDWRD +iFriABvNMURanj7kUTHF7+7OCKBK45EgNAwvYnUW8S7X/O7huGFuwDjQHHw1X/QuSkqyX7FGRn3G CjI8LYX/W/t+F0d3qEELi/fOl9CMfnIb/32IbsqyZbxNI/KNTLFhaT/kqA+1S6EUmutxvxhHNZbLj 5FgZJSrQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qE0L9-00Bh4b-08; Tue, 27 Jun 2023 04:30:07 +0000 Date: Mon, 26 Jun 2023 21:30:07 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 07/12] writeback: Factor writeback_iter_init() out of write_cache_pages() Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <20230626173521.459345-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626173521.459345-8-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: yfqo9fz4936ostood7nktxq3jicm1fgz X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3DEA8C0012 X-Rspam-User: X-HE-Tag: 1687840209-488951 X-HE-Meta: U2FsdGVkX18kvITIAkRLlYXXZ5XRDuADimQHuxzuZ/CcWiIsNF5nhoTMyNv7rxP3QZYuPLdZMFqjOBzLJpnEUc1q1kz/XYfh2jyPorwjNLhbN0qvY2bJHnqurinxWDJIES8/1NRC06JTzNZ7dj9qpH5l+T+5k/YLUv40ixzmkDmvDWsCFGDMWagt0HMpciYXD5/4awxG/oIO7sOoPm2xv+13An6VH/0wS8dkt4qaRUmhgihJwsiMwu0dqwyWMdD8LzcjMoEOdgCkeO1NGCzdNyHrhWqp2U0+u9el82YdHD1j9ue1coMvekevs5nP/Rx0oaq+AEssFA0uXOpy9XTBN87jo+0KtuL+9vADcAiuEHrGr4v3k20KrS8aRn7NE3Bo3uLXnBHdtEKgWjUDB0vF5x1egFt9KuGNQOLmors46il8NnUB8zofKj+14HR4JAxVcUspb0cKgZolsYxofYzyrmcRU4pWSiWxW2LtPEipupmEOHVbYAjvyJuhGLrdmdy+7pb0LJHNqKQpU4LN1/3TRwcuRhH2M6sjbDRR4E4nUuy9K4XPr3jo1TGE6TGWtBjC6dPfD5uel77c/A7u0vujg26nsdr1Dvh31Wo3t5opoqIu+4mdBE9pFyVMv/cb8scV2soF6lAg+NCgCGIzc5lrPpX4rSdIHXkFOfwRFzTe6/19G7qT9Ep7SkMlSkOtBFT78izKUjwFLauBiq/53XkMkvqNTlK9DvxQwVFsH8a/wTcE86gJGaB7BL+NeImY43Jwl7AfIjrQ/F23/I4cmz6V2yJeNm1W3jefD8Mg9s+JPFdviWV1B6UDXi2obIPO4eRKVGmGBzTn36eW2qGVot4ZkNA8H92bxoH1Ceu0ClRsz5cQA3VDTFKowQm93ZjK7bT+c0/xpL57pDXa8n3ashymlfSwvhuZsm/jdtE9C40eu/617qyimDG4zBe0I1SDx7V5mGZV4IEiJcXD+hrnuHo keDxfL82 d5SsPBF2hGO/HEe82WMHRXdSGagISynfM4uBa941uJlhhVlW3lAHgtUVTetJMPN7maavbgwNEQD1Hpgu1VC7TDaLrNCpnlviopBwD50pYy5Ygn4HzBcZ5pdwezG8TSR70Xq63sonJLbS76DiABKSfEx1PdfEMVmsN7ueGLPNoiv3L4qRnIIaAJQs4YpfZU3Ul2SpSEaEz1vkc8LphCCy3USDHWZOSQ4+6baroa6qJJMgmOYloEt6zd7NZawfOLdRZAFVmQLSFp+kBZ2Yo6lwMNW6HfjxqEeo6Xpi5mvfzYuNYJTr8JiQtuSITq46OXNRwsdPPPOUvzH0FhBd8QeC0AhSOHGq1BXPgAb5TTTfSFXQBs1Fc0+gu+hoimHFr0lpTg6l49wWkxKkYPwEx+76A6xcGoTIBrlCaIxW6q6F6NiGELmFHAroLzNH14g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 06:35:16PM +0100, Matthew Wilcox (Oracle) wrote: > + for (folio = writeback_iter_init(mapping, wbc); > + folio; > + folio = writeback_get_next(mapping, wbc)) { Ok that's another way to structure it. Guess I should look over the whole series first..