From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB2BAEB64DC for ; Tue, 27 Jun 2023 04:25:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86AC98D0003; Tue, 27 Jun 2023 00:25:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81B808D0001; Tue, 27 Jun 2023 00:25:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70B0C8D0003; Tue, 27 Jun 2023 00:25:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5F7E98D0001 for ; Tue, 27 Jun 2023 00:25:05 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 27D611608B4 for ; Tue, 27 Jun 2023 04:25:05 +0000 (UTC) X-FDA: 80947237770.30.854CC4B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf14.hostedemail.com (Postfix) with ESMTP id 7E4A7100003 for ; Tue, 27 Jun 2023 04:25:02 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=o9VxntFV; spf=none (imf14.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687839902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X0O5D4A4BzDv3g6F+hWrfTtn7WMWd5+asdpXbkJ+CvU=; b=IsQePNr8GTCl0la2Eq1gZQ0CH5DnzMsJ41I137QotcF14KwvEba8Gdzb4XSvbxsGriAGGK U/Pzegpagt7Fd0j6J9TZTH9OrXfH3tM0l68U7U4s9olRw5nJCpEDOFP+gZOzEcjn9DITrj m3ebiK7YC6lBcy2ToWcryFIUq8My4aQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687839902; a=rsa-sha256; cv=none; b=MbJ8ItNjQXSi/AWNX+QQYLn2mHC03ceeNuaM5IArABmKFtkKi6t9dgeOwE+4BdffsUbZp/ nTXCNmpQSikEYRYTdy1nIl23qspdjcQ1frDc5q9bB0AdXl5WsFFTawL0kjo8Z2a1OD05Vk lisQwshqD8iXh7veduQb5oY/DG9povM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=o9VxntFV; spf=none (imf14.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=X0O5D4A4BzDv3g6F+hWrfTtn7WMWd5+asdpXbkJ+CvU=; b=o9VxntFVUrtjl9KyiH5GLIK63h M4ugJRCobRFr7lzpbASn1T7e3WySQofX+YWms0U5z08zQNlL1npMhtv/0yJDDYlxyAjF+1F7F7GcY ZCouKPEE8WXQgs6G1pYTN6dYcnm05xBXnkjTJ4VQ0zBuVFE2aSi4dGA2Zy3ZCrfTKP7iiWI8aRxXy QxfGPusR+9kNm7+YkRn/n4Nq9TNn76FhWRhiiidhU0vU3WqrQWP+NDXeQzDE6lQitim+d94grbjNF VPw/gPz9cQkAgtBfFWK8KhAwQwVXXtOgiOTt2et2IgXUjUHC+08a0t+d+N3umJtARvrtmQrIcLH5P U9Vj9E2Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qE0GD-00BghN-0h; Tue, 27 Jun 2023 04:25:01 +0000 Date: Mon, 26 Jun 2023 21:25:01 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 06/12] writeback: Use the folio_batch queue iterator Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <20230626173521.459345-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626173521.459345-7-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 7E4A7100003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: tnrfm3sy6yxajp6ud86yegxg351h5wi3 X-HE-Tag: 1687839902-570181 X-HE-Meta: U2FsdGVkX18Ttwv3Wk1AcptF8Ajhja5Lc/EuTy1aenjC3NCT4gvoqo9ocwSAmZ9BC0CQqtbbYtGVfb2iKuxHyslLyKpgLVb4z71V2qFWHyxdiw8T/ruv5VlXp9R2OM+THLlyHkgCtEXDaEaWvBXBszLv48JSsOQQbFX1APaLY0R7siVMMLr1Gl4//u0XqBkWYlbEe34AjOyIGo573EjXMiBXiVLu2paebL0BnRtw/W3JHdhJUTZk8za8Z6WaYpzZ4K48gTPI0mfTXsMqnJ9nx2hPcgGVatpAZQBoPFfMzcZ1l19wnLZeCW1jrfUSFM1ZmafRNbdFstWyoNz3dmS+HtMVdjIdVzXgoXJj2jPh+YQ0YkamQ6eGGgcwrszLGd7dpMfj+Ru8xUcvph9lLUdgrY1H4CaCPvRMNEiATjsL/mf5HreohFjSn4MCKR7k3UvbQveKWpnVMfZrQDiLx7SqrUhDXXqJbX4ppJesQIfKeI9JXRN3DAxD6LbYAl0os7volFqg08NUln32/puAp8QVuMH6AEZ09vwFWWu2jfiydxeXWrqm1Gae3XY+U/0bw1wz95+gc2FsSfqWHvLaBoznBpbojGFiRQocpmBhnzIDsHGcLPpm+SwoRRF1j1EYmbH2vO+1yvFqdgdi1HizzZLgMr9W5uD4rrYS26FyPQNA6B5vHsuVVo3dtH3QSpY0lB2zWas1yKJQxRWC5I/nF8a9CklMWydlAO922GArmZ5lyHoICutXlFHX3RqGZHxDsEjR6LPQuM+idvKzQUROeJ8Bl0TyCQC5zudWmlezMd9+xFadY1zOboMC3+5av3hvrMiQNE9WA1b8TMBo0dXkZ0Tuci2y/rw6KxuC+8aX5dOphLzG9lVYLwD43EARKAkCj3x3HmTi6lcTCm0cnj14BHwKpjo4ALJZBLh59S31hRy+2Yne/wxAqN1jq8pBNXJCr6sNcmTTJEImLIhYb7UFlLl XeGIS+3g 1c/a2usmo5/XaY3urpmp8lWauHtUMxJzfcOLPqb4BR0cs5V47A+iJ8yRdpMBQuoQ+X+mtTP/kzL5GW7Q2BuYn0JEGbjHugyPqahjD7wvC73ULxMvpNFUiENrwer0zKVAl+Y1jiwlABTD1TF/5uF1ZOEWCOXzfyBu/HPdprBEPIzrPNJ3dC/wX7A5zfyQ8ZcB+Ayo5o6ZK11IcgfQhRn56D10wDQ0LtFxrUgUhfNycEYKPZ57VHSuDT48kdeSyHloJuRCW19p0n3kIqjnjVfORozKPVdU0fMNcqPRMk/R+fXUm0OKjg8vHsNMjVu2Xa0bvu70zsIbOmnWpCNevRWYQnJ67Cf5SiRWgU31ShYw8ctwHU3lBlyWmkY1h1g+bKz0Y8m+vgLu19EeYrw5fKPOX3pP8r4usAc28bFhlmrITym4qQdSRUhrYFIHQaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 06:35:15PM +0100, Matthew Wilcox (Oracle) wrote: > Instead of keeping our own local iterator variable, use the one just > added to folio_batch. Ok, that's a slightly different twist to what I just suggested. > for (;;) { > - struct folio *folio; > + struct folio *folio = writeback_get_next(mapping, wbc); > > + if (!folio) > break; But as a purely cosmetic nit I still think this would read nicer as: while ((folio = writeback_get_next(mapping, wbc))) {