From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2A26EB64D9 for ; Tue, 27 Jun 2023 04:12:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64DC78D0002; Tue, 27 Jun 2023 00:12:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FD338D0001; Tue, 27 Jun 2023 00:12:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EC3A8D0002; Tue, 27 Jun 2023 00:12:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4044E8D0001 for ; Tue, 27 Jun 2023 00:12:11 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 00FBC160677 for ; Tue, 27 Jun 2023 04:12:10 +0000 (UTC) X-FDA: 80947205262.02.E486E84 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 57557120006 for ; Tue, 27 Jun 2023 04:12:09 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1DFDuaCt; spf=none (imf29.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687839129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BLmHsyqPufGEDqWhK4TW18ghrPJRAcuDI9St068tosg=; b=ZD0VrgP9oZFY0RoNBcafqaxBzSUN3CSPjr3XfDWHon83VFzg+DH8e/tI4zyyHsE71No9pH YSS+NZyRafW6ImuQKo8JUSAX9/SldXpneZrL8lYL5mmeivBknfd0SKh8FtJfLNVtkJD5Yw KI2tZPPomFxlLGN4INncRl2kJfPGU0w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687839129; a=rsa-sha256; cv=none; b=YqfaDEHBousTBGNRMhlLOIIEPEQlgJp+N/hjQx9RcT9QyrViMH/2km8HkUE+MMFsNUEog6 cpUdAliMmuyg1Aeyj8nd2Okts+vFQr+8SjH+yzk/7zN0BS3YpcZ9Gpb/CIb5AMoM28L5bZ BDVSNgrz733mP44+VKUE09BD6XxlWRA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1DFDuaCt; spf=none (imf29.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BLmHsyqPufGEDqWhK4TW18ghrPJRAcuDI9St068tosg=; b=1DFDuaCtDRl1uZpfCO7uKXpBIV VDMYxiOdi74H4VKK0YxlX2JekqT4HUmiYgQPXywh0R+d45YLFWDNUWk0mQ50cgiq+BhpjeAWJjb8e 6ispYPCbW3c/ywQj5scvFylnY4HlmWrzQjfmuKmz3whr32i11q69fE/KGMIMkcKIxDi+LR1kCtYkj 43K2Nu0OrWxrLsmg4dK1XhD5UypUcCAZLftXfQXNA6o7CsUiaj4gabHIFX1GdHPK1FoBCy2QcNLfn hdEcMx7gK6McDE2GiEjX6drIj4rAcEyw/TgBHKZK6AUPLp0JSeR6+t/3gg3HCyw9uMzC3MfunDvkI 26BF9OoQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qE03j-00Bf19-36; Tue, 27 Jun 2023 04:12:07 +0000 Date: Mon, 26 Jun 2023 21:12:07 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 03/12] writeback: Factor should_writeback_folio() out of write_cache_pages() Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <20230626173521.459345-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626173521.459345-4-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 57557120006 X-Rspam-User: X-Stat-Signature: f7pc5hb3ew6djy3dq5aih1fbq811j1yg X-Rspamd-Server: rspam03 X-HE-Tag: 1687839129-96904 X-HE-Meta: U2FsdGVkX19/HSXpfPHsx7icaluf7mLSosl7Ue5xdyeHzkF0Zr1hcs/knkTpgvkb+wMWktZcaeBotUOA7r5OLM7VmjuG2hbXXqmNa6HlnFMP1bb3q0mjQddxMZTPg70DZpitfYhNS1D1GlCBRJdTUCHqMCIaBrUqzmRokPqD06W4euSW/46bcAezJFNLR26HKb1qo8dDxpT7R0JbxPM7ppYSanq4N4wb0OE8fYJBv5FTyftAj7dz00tw2sZNnUSDqLAFmNc7dZJ736anLYv+cNPxKsvxCt3lDMFF94h07qOBBSkjF/PEy60C9Kj0FJVPZqqx/Ek1m7R9MWZIiw+4L0CGVFRqbDQoKPygre1OsH9LHuszGMJnwhc/+C/06OVSz38MIqr+1K8GvXeJd+zLp8bgGqB+fVgQWO8LMjFbvm7J6ZWUF8iLlOUM1JOHbIqn5LxOIpURFfkfWQgoMdhJeg/c+3fAqZtb5UFGQPk7UBEa2/gn2rDIN5MOnZCEiWB82KrXayExYdJnXPmxvPOWAlDoZssX73sOsDysITvqPr9ex51dCs7RYlBgdjVKUc46o0BpI3lYyjgIwWRfRh95M7jWxsRTJAXKloUnahiC7bbZfRGlAcgSdgrSTaA04EAZwylU7f0M3q7S/yzEvyk5QEw6HFmRL54+tnrN5rRW1zRPyw2ZfBQL/Mk7xsYgqZtMWOhRajwgAbDwD2REHheNkGZcBUeQZiF2HLNBqGfSoLEwTgHIGbMFd0sx80j+RRuwZoNemwsODL4B05j7RdX7jdQL0ddzIplB5CTTgxGSW1VZf2KWS7Z54FnpPJFwMPovBJN3eBGaHkY5ZOdquRYOmzrOMT7Awm/fp0S4YrO4eTiYx1o4FQCySAWzR87wdv6ou8tEnYNTHEolPgFIRP9vyA5GvmmXOd964geSmtONWERIvEredNJm2uLGzs9axbj0Hifq23yKPxmrqc8m3Ke 6SyW3mu+ 6lDV+d6Qev37yZlRV3nQ7cOqLg25qp7Nl/W0mlGgLlw+G6kk0reHE82BndwuKZ9VrS5J6hCgi50N6+TtXCeuzCQe2cAToUgQ6jfOhGfh3p/EXn419xCOWsCS/wXUZm8Cs6yWlnTps4/SinHlwEStsVwqDx2sCW/XP9gYMQzGn2GjCgZJOOzXeaQ6fXncbAt8ASxC5lCEzM2t4Q6g12Pgx3KmX9ZakVSao7FXK3iXrLV8Tjh/AolDhsUQ60AwNL+z3o8UXBQCAfHo14QOlMBFEYGvw//dxV19w7odKfViK0Hn/oq+WO3wYNT7WFKMmD353T+RCNZvqR2iQHMausUglIPd9V0mguxBGdIFQOPRZ1izvLXVFz8vCrJLnVflnALDB1eccF4SULQwW2hT6QHDLBxSuF2SeSEh2mDZiK15wHC1oz7J3/nTe4fRvIDEp9/yliTC4oS/YUpoTcS1uNecYA9JzAI+nlFEBWkX/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + if (folio_test_writeback(folio)) { > + if (wbc->sync_mode != WB_SYNC_NONE) > + folio_wait_writeback(folio); > + else > + return false; > + } Please reorder this to avoid the else and return earlier while you're at it: if (folio_test_writeback(folio)) { if (wbc->sync_mode == WB_SYNC_NONE) return false; folio_wait_writeback(folio); } (that's what actually got me started on my little cleanup spree while checking some details of the writeback waiting..) > + BUG_ON(folio_test_writeback(folio)); > + if (!folio_clear_dirty_for_io(folio)) > + return false; > + > + return true; .. return folio_clear_dirty_for_io(folio); ?