From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE4DFEB64DD for ; Tue, 27 Jun 2023 04:03:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDC5D8D0002; Tue, 27 Jun 2023 00:03:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E65978D0001; Tue, 27 Jun 2023 00:03:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D05C48D0002; Tue, 27 Jun 2023 00:03:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BD6898D0001 for ; Tue, 27 Jun 2023 00:03:41 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 879BFA01FC for ; Tue, 27 Jun 2023 04:03:41 +0000 (UTC) X-FDA: 80947183842.03.372EED2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id 1BDA880004 for ; Tue, 27 Jun 2023 04:03:38 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=T3rmNnOp; dmarc=none; spf=none (imf30.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687838619; a=rsa-sha256; cv=none; b=y+BAPoWWKFgh0x/svrT5UXpysH6k/e/FlkkMdCBDe7W/0jBzxyBT7oE21LcU9g4uZ4/hj/ Od97WWg+8DwwT8DR0BZ5+25KLqwJbNcUv37WnpuTAVcIiz4iwB0Ty4ttIj61NEf/NLXwxQ Yq9yctjTcAIPtEwQW7w+yGOImj4o+HE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=T3rmNnOp; dmarc=none; spf=none (imf30.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687838619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FNs3BplCPpnzdNu8i3c1Y/TSPIbiewFjVDwcw/mDzZw=; b=Je9OYFCWXd8U9NA42XEyCajPP4vwvuFF4GVQ1AkHxpuerGXUyx42FNXfyjRFvdRjp2H8TL cUhBjajbJFeaLzMeih/037VzzzGn8y5Km8/y0LLmpWaZe00o/pZW0ynqI2zQQ6W6ySkGfa QIbmaOIkrYemg2SD4PhnDWKvFi1xSQw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FNs3BplCPpnzdNu8i3c1Y/TSPIbiewFjVDwcw/mDzZw=; b=T3rmNnOpj5XKSDGjcuQrs5ZBg4 /nn2S/AteGGEHrBO0qfJU9TMNv/g38NgqwqQVavNNc+NpqIIwd6FzbE26Exa85Mm2izeWaL/tyEsI DkN1FWnNdsllVxQk6aDksH2AhMpr11JogGhCkxunKv8ogiz5ioqkZVckNXYXLxf+e6G4T09nNnjxw fAilwjhW+nZaA0yebzTpMEnq5sWsW1jHQdS8sT6BWvsXh7BQm/0nMBhJMA1kxDBW210uHZ73fl4Ap dlnfsMnCt66iTPaV02aFdD7iXITrxYxh/NVgV7sCE1Xzcm+FR5aaqvWER8ayQxn/z/yn36TAmJUG4 iGOcf6rw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qDzvU-00Be61-1r; Tue, 27 Jun 2023 04:03:36 +0000 Date: Mon, 26 Jun 2023 21:03:36 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 00/12] Convert write_cache_pages() to an iterator Message-ID: References: <20230626173521.459345-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626173521.459345-1-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1BDA880004 X-Stat-Signature: 3hy7kurt88433ipoa4mnp9hgntzm9ad3 X-HE-Tag: 1687838618-399138 X-HE-Meta: U2FsdGVkX18Bp3PB1I8/JJODhtIfI6YTYI4SgwRmnjx2s+MEmgt9m0Ts8s2m6Fh8XeOsJNJTLmo2vzT3hRirVcTWWRNaOMa8Ni+zNULNaM/7FSdHvjYybxE1e9n7lONX4FI9tT4SE2ndwFBo8RM7ZVDK09/vpvvcGlnF15iSilEiesvD6HH6l6YGAf8cY2+lueu2IcQjwc5NgceVBYHNuxleZfPVQ6MSs5fBLSSCiMT8pyUMeLwi1/fszUAXu3QrPXk28ouQvribzsnDQGcmi7kbDhDqWXr/fgLktKtSM6Qgb2ZkVwLadN+z9SxJC46tOOQK+hKpaZ6csfJJC2YLxMQ9PTW0pXYcYRD6xVa8Fs8QJJ2s6IDoKgm6QPlh3NGDrOz8odA2xIAAr+2Xyng3Ur6mXbeJNbZpDNcwkg2fLPCyllPVLyxdkQPZW6AHFDOsULrfUZwWcIR3ocCzFXTeE9amyQwlNsimW9bxsyfPL4lflmR+3NkEKkT50mxEZ5OQaEvAtZ/81Zm83oHnP18NFy2uxebGgMH9//RW5mdOv0r27i7+TbMsSZb7+01VFUO3//xKw0IZ3/Eaoe0OshlpWPk5Lo11AjI9Kp+w0YQ2RRk31wzL/LkKnteBXPM/9orfFL7WQRXzg+//3qBBnjykGuU9ukHo+w+Zu2tItykIBjt7w2CHZfVKoDwPX4jXvNmQQHqr61RrSkHL/DSYfbOIIU+KZ5LbYoTokXyXWCDdnXtJC7PG83Ay2bn4wudP9aOWOxokoy4qMyJn3otGLiEAbX32mPwoy8FDKC2YM9CyAdnNCBwG4xA9YEqAAcgAehXBXvRb22Ckoh9y+eR8eIodUjF0Xas0Tj8dUHmw2uMKpqqwNLwMy5K7zcGwWbSdlL1pkI167c3Gm+6cKji1aRaV7BbdzCjV2FgbRum7tMJuxK6SxxJhmxw+hYDSuTEcQIAehPiDhYY3kd29wab06in Mn/o4af0 r0BTT8gMYceikViAYVCeQX10Ejee7tR0MFamNXWoAGMSdUIzW8qXNHryF3TabfrxMZJbAn7O9Fbv2hjxpi2TJ60spl7exQGvSmAODIcH1BHiMzHLfx4Pwsb+ugggxBgINH/3NVRBqjnCWjRbivhUxBuEZkbP7oLY9DGoJfn5mpJI2u1mMqgC6pF4t26lq1c3PNAMTcQQIHJD8j+CC/d94ClxpQMollmuqoeUiAjIqNiYQ9OSKum9sxk9jfgbx4Gc+kUC1YmCN84/A5y32QFuUCiMpuM7xnArEZ7XrxOT4t2SgR4LXw383QXLtokpaSD6xhawgx7cZikP2Lw3hVoKtoEL613C1NlFeGHl7TxT3t8B5quuuSrc6Qfo0ztYWfAwRGm1Z9ZgQx1SmobP2yEeuWD8/MZ08BRPpt5kUcDZwP9EOA7Qdt4asncGmPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 06:35:09PM +0100, Matthew Wilcox (Oracle) wrote: > Dave Howells doesn't like the indirect function call imposed by > write_cache_pages(), so refactor it into an iterator. I took the > opportunity to add the ability to iterate a folio_batch without having > an external variable. > > This is against next-20230623. If you try to apply it on top of a tree > which doesn't include the pagevec removal series, IT WILL CRASH because > it won't reinitialise folio_batch->i and the iteration will index out > of bounds. > > I have a feeling the 'done' parameter could have a better name, but I > can't think what it might be. Heh, I actually have a local series with a minor subset of some of the cleanups, but without the iterator conversion.