From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0853EEB64D9 for ; Tue, 27 Jun 2023 04:05:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95D308D0002; Tue, 27 Jun 2023 00:05:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90D8C8D0001; Tue, 27 Jun 2023 00:05:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FCAB8D0002; Tue, 27 Jun 2023 00:05:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 719D08D0001 for ; Tue, 27 Jun 2023 00:05:21 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3F98B1A061B for ; Tue, 27 Jun 2023 04:05:21 +0000 (UTC) X-FDA: 80947188042.22.D9633E1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 994C520018 for ; Tue, 27 Jun 2023 04:05:19 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Zb4bAeY+; spf=none (imf03.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687838719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RsyF4h6uoThSvw3Iku4RrSPBs0D/JAtSb0sn0qxxh20=; b=GGe/2gp1ejuMGscXk3hyUGU4mLyMS0BtUpQiaj6jaE2m4B+tF4ewi0tfH8btCNT3mURyLO d5I7ZAdbCxhTyMRj8JCQeLPOPbxMyJmS//Ab/8qm0+pyr0YDqYMz5YUTPXUcO/NmbOjhrr atezft8e+tZq/wgJxM7pKTeVb3wWKqY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Zb4bAeY+; spf=none (imf03.hostedemail.com: domain of BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+9ff1e1c791a3eaa24235+7247+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687838719; a=rsa-sha256; cv=none; b=8G70RpEOvI6EcwtRDHEnR8eXOutwcHrfZ9MeXwos6Nby/it2ELuEFm/1icxfgb+mligoE4 RHRFHzx8dXNZ7sL66F3ef95AcYIcfnCgCBYu6GoW+XM3dSx/IH2HOroskpimi3fjOBqkVj E+eE27AVPJK5a3o/eJHz0UNN7AHo/pU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RsyF4h6uoThSvw3Iku4RrSPBs0D/JAtSb0sn0qxxh20=; b=Zb4bAeY+ZUGIlTx6WZmKQEwcds pkXLg56Ft7TV3uU3ZBjuckl/fvKej5gLQkonpvu37uVL3mtmYulH9uNbOBPHu8YPDi5U+g2S+osAN 7Lb8NdhZwhFZc1gA9uEBqWbraiK9LVwW+C0lDbkigoi9ZMcH1ow/wmaXGBhm3JgC3LRszv00fK+82 b4pwUH5W74zAX9Snl/D/7HWNtjPJW9sN9kkWwsumzjyd5iVYRi4GmH1IEJ/iXreNjgB06usomOOiS VSc9rDRIdBmEW6DN0ouQWqIJ2Y+dR22mdHVixj5DqY5/cmZwtVTtWy/pgrIkNihtrF7XMC8K2MBPo kk/ojpKg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qDzx8-00BeBk-2A; Tue, 27 Jun 2023 04:05:18 +0000 Date: Mon, 26 Jun 2023 21:05:18 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 01/12] writeback: Factor out writeback_finish() Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <20230626173521.459345-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626173521.459345-2-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 994C520018 X-Rspam-User: X-Stat-Signature: nm76ga5pn6ka8qsxm4kwxtaadb3rc17a X-Rspamd-Server: rspam01 X-HE-Tag: 1687838719-62937 X-HE-Meta: U2FsdGVkX1+LZOvzHUXU7x+Y37KfezPLHHiWnk/Pw2kN2W22gJBqitmS7EH1PzA3HirLKqvaQUkfR0cD7bFhAa9p58vQTU0FfFNnV8PZ7exgaqyzp8NSSPZbOZQ7a2FXslxlMYB2iwUtHAEkp1T0lENqonci4y71HZG2U9cZ2O9REp32fNZHUUY3RHBx921WNOgZ4M57u2F6rhHJL9sU5VspyzBMSJArdYi3HtZ0UHOeocEgjvc8BJkK+DgAa+zqctF4rkoqwnbqPApiGorhwZYLYu9BVA7bK0f6ZoXQWWWHVTGv4uUDQlGcCHE2EDaPVFiB3ejmEJg3LGaobMtQ2rZ2qTcC89SL8PD+0ZDWGEyl8VoymIBMYwphlPZ1TBhCK7cHZLOVWp/7K7p06Vdes4ji4sepblQvJpVVLFEwyyklmrrRz0Te5kJqfwL253daanU8C3UIyLeUTvgDbdA8U2hXXLNq98QxJTlUaQ/mQxKWFHXG5RX1CGnqtdYgpwbYW/e3AP4PN0dOe72sKgyTTQ1I6dtnSeGhX73rYvbbYh+gDf+HVpFQifPybWO4D+FCFh6Q4asppH3feby2/mFZB8P2ibP3i3ObpXruTFWU0VDjO8oa6KADy/Bqs6eb8RNpsbOOHaSTInOIAhGJ89EfRaQtIJ+kjYhbcsskEMyAKpzT0inp2qpKsuaDeSxMoH9QlJtg7Lh3K38BOIEkMTIxB81SX7xln+eEjzAb9jU6H970iSOJMsqH1dXGkON2/kkvgvwKAXQXVc1Y0QppqgBXzckuASXS5lXs/3JJ9xZ0VVbPY7b6+0Hiaszcxo6IlWdNWgylP7sTWJArROrGWLbblRMJejluMxoPbosvjVoAbhHwL5Hjr2VUmuZIMmPnnkmzT1R8x1MbayR5iF+1n+3cImK7exq+5t9oxKb0sdWmd1oA2O6vL/4kaoVloz/K3gTdlJwe18XgRFmhkp8/BrV n4vA1zxa BNGeqKvKqKZRDZywAWfgU+HjcCmIqh9715t1bgp4Vbq6oyiFMmj7xfTdS4WKHul0Rya2fJ6ARvvtjib2Ic5zBEJfkiRS8ISwPSbLxTbwYNPgjrjBT6DkVgLl//1vuA3QKIHGYVbUroN6ZT0ffAh8itiMObAu2r9G6h52qgHa7CYvv3yvK3b6/ABdcSpvMYUKUFw6Htq/V9lkJzuVpmM+kydsGWtm7i28bfWUpAqM6QykahhTdINRl1v/jKxyuE6Hm7z4yVGbrVfNS5pqt/jAl9aTw5I5Tix5ML1pdSyBHa2qWAbFDcx7EKyIAVG/ebbDVE/bR2cU47ns3g4lWt0aF/LOUg44MOmrhcZpAcfVMm99v3JBVEWLeuFkyqKsDdoT+gV0EyTE1fUmCrR1JOkkduHHTe8O2pTbb4hm4gHTJQB66r2cByno3mFYaPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 06:35:10PM +0100, Matthew Wilcox (Oracle) wrote: > + struct folio_batch fbatch; > + pgoff_t done_index; > + int err; > + I think this really needs a comment that it should only be used for the writeback iterator. In fact this whole structure could use a lot more comments on what should / can be set by the caller, and what is internal. > + unsigned range_whole:1; /* entire file */ Same here.