From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C778DEB64D7 for ; Mon, 26 Jun 2023 17:14:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2644E8D0003; Mon, 26 Jun 2023 13:14:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 214688D0001; Mon, 26 Jun 2023 13:14:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DC5D8D0003; Mon, 26 Jun 2023 13:14:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F24918D0001 for ; Mon, 26 Jun 2023 13:14:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8837DC07E7 for ; Mon, 26 Jun 2023 17:14:02 +0000 (UTC) X-FDA: 80945546724.12.2122442 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf23.hostedemail.com (Postfix) with ESMTP id 744F7140018 for ; Mon, 26 Jun 2023 17:14:00 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=aI8AZTzd; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf23.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687799640; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rm5U58cD44+DDKBRtN3VxAo0yyecspa336dzUa4UwTo=; b=gyVlF7tUPOmhTi82F+yLv6EmtF3Qg15HQWGj1CVslkfZj2n4Xe2KyrJYhjcSqCECfKu/NM uSig8Zsj3rUvRUqNCizc18PhWXwcDfJWNxPYEy6ACJ8dY/93r0qMJL8ufXckItNYb8cFUh YJ9WSbVVlEpoOFqt/Hw9L4vE6qvUfIY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=aI8AZTzd; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf23.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687799640; a=rsa-sha256; cv=none; b=hRnMES+geVBo2i1Uod7Sz7CuLQSL9vFy25eFNuAEEwkH9FgPgECnIIOc8Hqrv+XcokA0iv CX/uUV1Rp2XcWA58/QQjcLTeHIKG60jjwYAtQ1lZI1pUL4rQcGiaNdEfetUizTkUsCcs+p F4FAGiy2eTD2NoV2QjtKYzxs+Zqtf+0= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1b7ffab7ff1so7803615ad.2 for ; Mon, 26 Jun 2023 10:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687799639; x=1690391639; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=rm5U58cD44+DDKBRtN3VxAo0yyecspa336dzUa4UwTo=; b=aI8AZTzdbTFTc9aZaQ69mXSrqJz8ntv6XBHtRuJ+ekDoeQx/KVIMC6vB47neSkI5oF dnjgxnIQvm1XAu5iMJYOq4IBHYDm6PUjtT7dMy4lUFvJ/g7rChURMmyy6RV5nNAP5H4S rDSeobE634bpdDnWPO3ofSQWJG+28O5xExYDD364r07q/d3osWRT1DYZ5++e1Jqks7Cd dxG8tPBivYmGQJJRG8sqwqr4FbLOHUEot8ByO4WZ+VYRMVk+9GuiTesNnYm0X2nj+n9l WHVYv7n+n/Z4HuJI5Bea2OLg71/lT8AGCQgllAlaQcWQFcgWzIcJdkXX3XXnV1LTf1iz TK5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687799639; x=1690391639; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rm5U58cD44+DDKBRtN3VxAo0yyecspa336dzUa4UwTo=; b=fe0hlKXWmt9XeGHJ20JiSqGj6ZYmjqt4JUm0QqFFN89qhKfQA4ctZfduaoSQOONWp9 gXTbNuDqFWdochcfnPT8y+rT8DynDZyA4cFVrAly+ShbA5i3tXbW7FX7ctfnLY//OlMZ HSiXEpelvRZZ8zAOlanTGbOmd3EcTRRaYH8X/8iN4oSz8odynIl4GpTvAJy/TUl0DwQa f4N3l/ZbA4yQ9sh1sA9mslHcaHY//qKSiRRXcIEOnKgFY+4p97X60d1N4rRHH5joj5Vt MUKlvo5hEC+ooEoEboJ2h3ufVQsKrv6NrG6LdBiWgv0kdKWjo+aPH9IHQ3TWP910dcU+ EQbA== X-Gm-Message-State: AC+VfDzfR8BGJ6lYwXbFA849wO9c3ixF6STsLFPAvd/Z0Xn6ntRzpMZu 6P53tlWIVCsjmpbMwjdRQcw= X-Google-Smtp-Source: ACHHUZ7JmVx1FatMFel0fO+FJBp6+hDCsBp0wVFJcm3h+43QEylImVo9l2iKh7YSuk/loqj1b4H6tQ== X-Received: by 2002:a17:903:228c:b0:1b3:e6ba:1575 with SMTP id b12-20020a170903228c00b001b3e6ba1575mr4788858plh.16.1687799639142; Mon, 26 Jun 2023 10:13:59 -0700 (PDT) Received: from google.com ([2620:15c:211:201:9abd:c54f:4c3a:e10a]) by smtp.gmail.com with ESMTPSA id f1-20020a170902ab8100b001b80b428d4bsm1662026plr.67.2023.06.26.10.13.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 10:13:58 -0700 (PDT) Date: Mon, 26 Jun 2023 10:13:56 -0700 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 2/3] zsmalloc: move migration destination zspage inuse check Message-ID: References: <20230624053120.643409-1-senozhatsky@chromium.org> <20230624053120.643409-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230624053120.643409-3-senozhatsky@chromium.org> X-Rspam-User: X-Stat-Signature: 4yowg6gxpn89wpw35xu3qw43m6bjwuix X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 744F7140018 X-HE-Tag: 1687799640-777379 X-HE-Meta: U2FsdGVkX1/3d+xuoKhbrYgUgr+Enc+ORtmiufymshNnehNn+CYcq3SuCWsmVia2J3LtY93PEmyutA+zvkBSwxvXLRQjVOLJZ4Wj3hkVSUjJ0ECm3JoyL9NfbokuPXVfK0DD6CPPYOobNQm6b4BTf1olt7rv9agz0lU5aKCBdgOl9+O5Vxt0GZi+vZgFGrkG67//7b2QDOoN9xy1N0gZxcmTvhx9FOjoH1fbUIZhOekN4GvS448gq2VFCPu2tfra4SDcIhui6cj/c7WZyrKhlMKZo+yuMXxEYTihiMiJXw67aBzJBkyC5gach3c56wO8eUccckHbiN25/a0lYAxxzJjbcnRxMeenWQDFwOzb8pHJBD2/vCbpQ1HXs1F3I7x2TAozROLUI1BpKSbheADnvltK7WpRBYk+YE+sUzF+9Jtb6fa62R7M24H/Hzq9tu6W2Q+mTK45AOFAZhzzmwMppKVVpiHnRMBEmLMmYi75Y6uKkDoA4C6P3UX8iaV3e/zCEDpK9svxbEahkK4ZGqmXxw+B0V5hTCgjqrigeu6Hfdzm4WqfBVm9YgiAfjy8F4vH6fJdotTVaSykvtFTZ0AzI+R/aHYVjhiAtSuVrVMRQ80Pg4zidl/cToDAEOhblXLpC0txYqbL+kZwI7Zf2lnQk5zI/7LBvDoDwWzMZfNa1SzRbSDvnrXpBdedFK/ACB2hjNZ6umqTGXEoTlPnHvtZUzHlzEquXgGGkS3Zd0UC/jqM8GP00e6bqCETKrdK72Rj3F9cRvMo7vY60XveDrGi8ElQSB13w40PrFwpSvKcUzeMq2PUPwYCLURMqVp1QGLIg3IKgnLHjb8cvVPRTxCoELmYvqEBHVmt0UADpd38QWhpeRoEoOmjXCLTUqJ/cPybABLSuxWyC/UmqXSUkkGOmhg1HXra7ex22P6gJu0QZgFqDjpYmoFAd+jNzWx7k/ENhYU3EFd5O3W766kFfsO gYopUop5 R164DId39Tp+pxlSaa4yRKiVAw6red4oJTSy7CvTQ1YTHD4y36O53G0aSTgxWdGhWnN2AB4Y6x6zKTv2gbwdpYp2m9Z5vP2lqd94U7ljjOw0fdCVJvEyki3stkjMVNmdM2hLHP2E7d/ehDhLa8MZclLsbT0ggGIgg5px+ha78sWqmo6c7yVQTGuRYtA/s5DFndB8RBsJggMpnK7MR2w94oqgHHxz0CLxwl7qNkCO1CvvNoX0Wx8JNGKA1grXkDISlAAKIVQYayz3qH7O3S7yIbvqSkTjGv9iNhWUnBdtviqVr+7x0Aozz5B1n770/ZsTAX1qXasmNH4bSFmlN7WGcJG01jhnQRvsVsbZ9j+h+XCdJhoeXDvWf0I57om3ft/NiPrTsuHzT7mjwMccmtQcpLCDE6gD0QvRAL9EZa2vfJjXVk7y1ZXSw8Qew31gY+4OSdZGL40RRA4STPe67SBouBYjDA8dmCDjbrWYq93WXPcsoQSANw9EuG2eujHYQnvGBaFsJNiOieoU4TG5kTTcF2PN0DPHgr1+gbCR/GLoD4RqUpgYD4nI538SjTA2AFaZEBKjSAdWp4hobWsnHVYQQymvtmCRbvm9PQlJyLb8YbRzNlUdbFuMUS+oAbZWt7RhhipBZcdFg9eD7iajHP0IIx5UPe5tXOOVTk7xZbcihiHbd+CZ9uH11vcCS3TqkubhjOAE62X4eR9Cao8o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 24, 2023 at 02:12:15PM +0900, Sergey Senozhatsky wrote: > Destination zspage fullness check need to be done after > zs_object_copy() because that's where source and destination > zspages fullness change. Checking destination zspage fullness > before zs_object_copy() may cause migration to loop through > source zspage sub-pages scanning for allocate objects just to > find out at the end that the destination zspage is full. > > Signed-off-by: Sergey Senozhatsky Acked-by: Minchan Kim