From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E39EB64D7 for ; Mon, 26 Jun 2023 06:21:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF6668D0003; Mon, 26 Jun 2023 02:21:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA5DA8D0001; Mon, 26 Jun 2023 02:21:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96E6B8D0003; Mon, 26 Jun 2023 02:21:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 85D708D0001 for ; Mon, 26 Jun 2023 02:21:51 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 50746AFC03 for ; Mon, 26 Jun 2023 06:21:51 +0000 (UTC) X-FDA: 80943903222.21.D7EB523 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id ADD14A001A for ; Mon, 26 Jun 2023 06:21:49 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WBqcc90o; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687760509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rb9n+zo8/7YDilqhPQGhjYMn13HwGky0JBW07nkRrJ0=; b=8gIkEMFGIbmXCOpBUufeOwT38y2obaCRx0EJ9gltrNtcpaVT4ck9GZrQhJdqzN+Y/tr/X7 +TY4rKcFqj1I9K1n1UrTQd+xlaltoLTJtXNw7HPCDLZdlOf9DpB96VrIglmQxWraDYv1nT 926+x8ZGfQKcnmncFmSmmBoEHuy8Og0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WBqcc90o; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687760509; a=rsa-sha256; cv=none; b=nHoJsQkABuKNzqaq+BfGggkhferPWjSpMxaRUU4ONT/Rjh82sq8zerVVysrf7NfkBDDg02 Z59MtpdEDnKHOTeF727JxTbCQkB4XvrfiGB+OTBPkZJRQ7BruuEOZO+LiZ+xjM9hjUlyXw LNbB5zQzoZG6s37X/cL++Knx4WT+pQk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D09B560C57; Mon, 26 Jun 2023 06:21:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDD2CC433C0; Mon, 26 Jun 2023 06:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687760508; bh=32adzyDlBFSBWtLEHoNT9pfLD4gF8dQdYVhhOXCfYD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WBqcc90oaWhYQCR+OXO6W6iA1ACE4SzpeVklyw8fJfxPwJz0K1YH3vIWMR84qSpaj OrwYeLr4DbDJTVWnrcaD6KDbdQfSQYSBFWOOlpgL7jB5vbzolI8iBDnA8JE6OPkBXm dbvViJB9f/0YTRMiBWnmnqVTLdOvLE/q63nO1zmW4NZXPmirC0L4RdZ4FCCQvKEqdv cPZ7mpUXnXdKxc1ryne6q4P3oABniHLHIoXGnVSLHcnSmNsERVnEm92VyNEuD7TaMA D2qtgyLYu1om93dBNc/LnJQpSuRvj5dz5MDHFvj+flBUWndo6hVGKx6EZtOH/8naDz xJWbQFYxOOYjg== Date: Mon, 26 Jun 2023 09:21:42 +0300 From: Mike Rapoport To: Yajun Deng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock: Introduce memblock_reserve_node() Message-ID: References: <20230625050850.GJ52412@kernel.org> <20230624024622.2959376-1-yajun.deng@linux.dev> <4c361d62e0b77242fe4b8592c82c4d90@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4c361d62e0b77242fe4b8592c82c4d90@linux.dev> X-Rspamd-Queue-Id: ADD14A001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 8a4qj5h769m4zdrgy9e3t43z336cjfg7 X-HE-Tag: 1687760509-957730 X-HE-Meta: U2FsdGVkX19ynJ5DoAwTU9P7gSN+ow5YmponZCiWZr8to/AnDCin6Wg5MsmtFXfkwbaWq83tuuQBfhl9i8Hzg+mX3YsQk+q4DwnRS+av1BpTcbxp+Eev/W6ABuMqCNMvQw3SUFUE9X2scCQZwpGQBj6hhmfwUc5UT4XLHe5EM4BzBgamdPRX3V4mHvkLtEo4v+qXDX3/r6tmGCSEYdaRR9ua/t6xEp+agQJPQXP4E9IV3Xm2ruCIbPsCudKbJR1bW0UsQduRnQyNrbPhRyEPa87M7xw0ghWTavAEK5fH5zVfn5RcHIeLf6irfOWDq6izAAh17TmW84dKrgeBJ/qebKjv4T9eer808o1Ot61zUXmj3gU63FK69aR+gBi4heMPEdPG4Ilfr0sHT2ZsgYNj5MaHhmAea9pbmz8oY5CzMeeL9NOphSUrkKi38bbDxhbdyeFE+YHx8b5Dp+rXsCbz7PcVR4mqH5GOeHqXSrhGmW21MzcogYiPsoCn1moYllq4StViDMXYLvL5LQsAEeRJp4F/C1ioJLQ5Figx6VaAK9bwEVpEjAAGaEUEvW/zwT0BguMUhIKCF5A9RysXI76lTvAsjKaQ8nKJ8bHbrEnQIEOeYgnOfF9uT0iD104aTtA7l+l6slpyh0FSMwXL/cE08v9KQbRnPPs2qRvrXQ7zmF+APeClZdsnM1+6A25yqlgURTgYpiIQu+b+GlFYNEkE3LhKx2DoIHXP6zNzUsX0GcDQRQe3NDpfOBS+4wAqDzfGLBXvY3WtQXu6ARaEYiX4lzGWkWk6di6WwMOmv8KqCgaaH0iHSay1hGLatr1cA7/98PmCfy1xN/Zf10JTmZmQrWPPcDqSM+4pvXjBRbTZOwivH1bt3gT7ZsLa4jtWWudQ6CVgz4U8ZscrMBYeceThGCYRtAoPUOpmVqZP5glLUqZGDNRJbOhYATqcTzSm7+eePbPgJ3IwemZNP1VGsGe e7mC8Z1v su9N9cLQaVLsilw2vyeYB6W5YF2scy2UosHbAb0hbVdK1hEYYy9D9xh3i24dNORiru/qwA02SSHgo6iZfHcgnPr2n25nzqDbUmfQwOcIVtWrU8GPfrNPbbdFakbbrpD51O5Qc0LiaT5vPbjXnMJyRry7GC8aYOV2tML6YiIRiQIVc88OsUVvDUKDlIrfU2nm3drKHXfaskKgTObd/mz/oLLN6PXFFD2rb/kOfwteA7iTstaGuyrd104vzxXISsDQJf1iHj9jQSB+h/Kygw0niC5Ow2FEppfQG9Jz1Vf8/rWUwA5Zf+8vVl5yuzSKTWo1EUJSm/wjkIbseoox0aiBZXnAVf4lBFhxxld0wC+BhY4o7Ew3aBOg642OtCEZT1XPHnRx7HMBsPCQ5Z9E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 25, 2023 at 07:39:10AM +0000, Yajun Deng wrote: > June 25, 2023 1:08 PM, "Mike Rapoport" wrote: > > > On Sat, Jun 24, 2023 at 10:46:22AM +0800, Yajun Deng wrote: > > > >> It only returns address now in memblock_find_in_range_node(), we can add a > >> parameter pointing to integer for node id of the range, which can be used > >> to pass the node id to the new reserve region. > >> > >> Introduce memblock_reserve_node() so that the node id can be passed to > >> the reserve region in memblock_alloc_range_nid(). > >> > >> Signed-off-by: Yajun Deng > > > > What problem does this patch solve? > > > > If we set nid and flags in memblock_alloc_range_nid(), we may not need > memblock_set_node() in memmap_init_reserved_pages(). When memblock_reserve() is called before NUMA setup, the node ids are still unset in memblock.memory, so very early reservations will be missed and we still have to update node ids in memblock.reserved later. > I tested this patch and delete memblock_set_node() in memmap_init_reserved_pages(). > It works fine. I did not delete memblock_set_node() in this patch just in case. -- Sincerely yours, Mike.