From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EB4AEB64DC for ; Sun, 25 Jun 2023 19:50:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD00D6B0071; Sun, 25 Jun 2023 15:50:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C59126B0072; Sun, 25 Jun 2023 15:50:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF9686B0074; Sun, 25 Jun 2023 15:50:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9BBA06B0071 for ; Sun, 25 Jun 2023 15:50:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5F4B5AFA94 for ; Sun, 25 Jun 2023 19:50:29 +0000 (UTC) X-FDA: 80942312178.24.668F586 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 64166180010 for ; Sun, 25 Jun 2023 19:50:27 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AGHDvpUN; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687722627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9+HzIBQVGlFL8xfvIAScJgtvtZfx8ZXXDTZw1yHSK9M=; b=b2+zrrejXKrz4FfXmzv0ND9fyw/gPDYxP15H6iu9NJYrDIhX3y/JxEOLChhllTzEsji8Ga oMZRqH6Z2h5PDfclnwawir98cSdlkLWrWl5W77TRwlPDhn36/45n6YnsYL04z/Tm1dawPd WUhCaGVZSNEQt/q8haHF7wqtG6ELVHc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AGHDvpUN; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687722627; a=rsa-sha256; cv=none; b=yGLOM6YrxdQ8fUc5WCeCX1y8BGJ+lrV2UARlYer1k8wKJPpefEFUKmHN7hsDjWD1TPn1fo 8yta9K7y6Rpi7wpbwGu2Jhdqc5bbmXLbYojDoLN4snYN3cJaCTV0XnvY3K0/Lsq1TGp9jo UnENzgIDLjMCZkmLiV2nQD8F7lIpRII= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9+HzIBQVGlFL8xfvIAScJgtvtZfx8ZXXDTZw1yHSK9M=; b=AGHDvpUN7zqMYZix6hbEiMUtWu /eINrp0No4beHCF+ZzOOM4MjwYRYpD9UTEKPGlQB5m0BKiXs1lPSrj/4TvA1e5l21z+oNs7Hh3ETK F+DwAWIVPJVLw/b3CyHF30bSdzHSQrQxnPKt2v4EqUSWRF4XMAs4eZt9gBcb1sfMU7CdvVo/fSunQ ddAR61Ug5JOXgYWeo4WiVW1AEqQ2FThiab64Gwi6GbcTSLiayt4rxzEQkbq7j4i4IZKi0EphOlWog zIF9Ws3ILuSyVGWXN2qQ9bD++8+KWMKWImWPZDAzaxAeSnbzMFPJmsEntdQcbRgb36Nypcbiz1uI+ 7A7KK0dw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qDVkP-0010Ph-W0; Sun, 25 Jun 2023 19:50:10 +0000 Date: Sun, 25 Jun 2023 20:50:09 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memory-failure: remove unneeded page state check in shake_page() Message-ID: References: <20230625113430.2310385-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230625113430.2310385-1-linmiaohe@huawei.com> X-Rspam-User: X-Stat-Signature: e1fo1nagjgkaotik3wgsriyfcg3uf47z X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 64166180010 X-HE-Tag: 1687722627-658111 X-HE-Meta: U2FsdGVkX18T53vvBKkds8q/Wb6tDGGc8fiu3WqLLMOwm6Vk7HhyIj6eQRNTthVVrva3fnJpDadEF49VadIMVmU37us+6pIN1IKPkWLMiJZsJHk04ynLqr/G0yYbAauBWIP99VOBC0uY4ya6RLMamE7aT5mVWxNVS+5rJoreXvcbQq3oAyIhtqj8482i0pcYiWMDrSuW3/JtF/hlvQAN5c8FutEqxXroc5UqPa84MdZ7vzuYL6X4h7zDqLddHAD6xqzfFmzMJ2glVTYByzdBbhfOGiX6BimnluItohbHwoo/lOz3b4TUy5fk/19X160u6CBeooinQauQjQCTwrENZuAIyLlenz71N5nwuCrLPwnGbfe6TTKwd6bsVDcM/7ce87YtheW5YNsJmAVdWJV1y/ebZ/7Kg87vZE47pO5suhsTKYcdnKd08Gwifie843dg6J0ZA/D2+MyfPQUj0K6x3bc89tHWtsMqP4OHnmDkfx5QpreEh2/iClbbN8R37bvzCWHctHfFz5wiCXOM/NPELdXWJbOY5Q3DUkNugZnEJQKFmSgPMW82Y+NEGSzuYmU2YWQBXFr+HFh2XgYXpaZyUB3Eitc3mUcA9LOlqepgMqD9WKaUC2eYbxUbSGt4ZIo+8Y4Jms+mLplzFm1RH05u/IdDsnJvdRXTBo+uLl2dNcnZfpTJHd0J+bw6n6xng7uq17Q0N/3YHGTH/WGgO6AaDMo9TiMk5ANk65D6GAzVnlsATWCeBCdPHom+0vSwesxyMfz+aEicqvDYinr13i3bCWilImV4LASRwdZy54QVrPD+7DIgJTpV4cgPvbIUIuw5voT9UsVEBLvk9gi+i1S7sVVbQ902S8ZcImUMNvHariE4NZ1WMNPuuQz+L/lYic64PCDcoSDM1AxRnuCPXZCkKSBekMcQj+Brl3mUyT0YktT+midTceV9cv7hoOvEC6ONEP+auU8wgsyJOPLnINs pqPJtcKC YGrG3Y01x07SPekC27AHbSSzU39UjNRfDgbyDv6dMkasdqqQvZvnhR/8v2DsXJPCZD5v2mbPg800m7Rkfxxdo1ruV83Og2rNciRVXUlTdkE6Hisl9E+WpzMKhaZ9HQ3FlCVJLT6PcM3kq2gFpT9PbNIJnAiUlBFNzLea4FinwH9X/FZC1knDAdR5OhMrEsGnfHDnEQCm8qPmZIJo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 25, 2023 at 07:34:30PM +0800, Miaohe Lin wrote: > Remove unneeded PageLRU(p) and is_free_buddy_page(p) check as slab caches > are not shrunk now. This check can be added back when a lightweight range > based shrinker is available. On further review, I think you've misunderstood the entire situation here and no patch should be applied. > Signed-off-by: Miaohe Lin > --- > mm/memory-failure.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 5b663eca1f29..92f951df3e87 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -373,11 +373,10 @@ void shake_page(struct page *p) > if (PageHuge(p)) > return; > > - if (!PageSlab(p)) { > - lru_add_drain_all(); > - if (PageLRU(p) || is_free_buddy_page(p)) > - return; > - } > + if (PageSlab(p)) > + return; > + > + lru_add_drain_all(); > > /* > * TODO: Could shrink slab caches here if a lightweight range-based > -- > 2.27.0 > >