From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8950EB64DC for ; Sun, 25 Jun 2023 13:32:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E5DF6B0071; Sun, 25 Jun 2023 09:32:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3961C6B0072; Sun, 25 Jun 2023 09:32:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 284B66B0074; Sun, 25 Jun 2023 09:32:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 168806B0071 for ; Sun, 25 Jun 2023 09:32:41 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D6266C04CE for ; Sun, 25 Jun 2023 13:32:40 +0000 (UTC) X-FDA: 80941360080.09.0F4BF6D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id DA5782001A for ; Sun, 25 Jun 2023 13:32:37 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YPft3+6P; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687699958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iQKsxGf0wGFzeonsn1JR0DJPTitXKOWsG26LbyalNmU=; b=Gv8Cv8upgsKjlQo/TpVnHps8dDU0AZhbdPdIAVuHYV5NsYturFCYejp0sV8bKjl+jFe77n JXploOHdougMzOlL/ke1+K9TmqXd8nQQUuXCUhrl9BbUGBqYEBi+LVPsOG8R15YHwxpjsg okS03gp3Qy4dkPVqRfXAA2UAlxBAr3g= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YPft3+6P; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687699958; a=rsa-sha256; cv=none; b=SBWaqhDGTCvFb23PM30Ycvn2wUnP0U1gBL6W9Ckxp6jo5aUpzvRrZqIuG/Flz5GlxeoLsE YCeQ33fjuCn+nHh572baVCOo6wFHHbBgB57wFNuxUA6TiwVrULhfxenu2c1InW9uOGtQL0 k3d97yHgvbCvPl0lAitKeni9rqDLzqU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iQKsxGf0wGFzeonsn1JR0DJPTitXKOWsG26LbyalNmU=; b=YPft3+6PHj814dmedSwtgiZgux Id/GrgPDfoaHMe4bnj+y6+RH57Xz0W6cRTfW9b178w8BSjicIu0cYUTnr9UDJfBhmfv33YNJcEFy4 5MlDg2Z6vi0o6L9dXP4Tn6rvDa/H+bmD1B/aeKzlLcDtYivorBZUZxaQXPIT6meIrHKe7UcPxk3sL 8dInKPw8+Kf3NumsWczIRs+Jw36gPqDMmGCQPw4xQNT6/fzBpcAi5iM1WIUYnP0cbGTQlM2rfi4av 8JfqgCI/Brn/Zb5rXHmSZuBPvbu65mqBya8kZZoNNPU/rwl76pv+Lk6F56afm/Bpo94g4maPg+nil BqntyrQA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qDPql-000lZ1-4b; Sun, 25 Jun 2023 13:32:19 +0000 Date: Sun, 25 Jun 2023 14:32:19 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memory-failure: remove unneeded page state check in shake_page() Message-ID: References: <20230625113430.2310385-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230625113430.2310385-1-linmiaohe@huawei.com> X-Rspamd-Queue-Id: DA5782001A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: gf44jsm6hb8bjxassqdg4rp9fbbxr17q X-HE-Tag: 1687699957-897453 X-HE-Meta: U2FsdGVkX18m4IAq2wt769Mt81dYZuuZDVAG3twbl2teTtFVyRS9IddL2hwGYLOk9MgkICvHbSLRIpQ54ZyKqji3kdFg/FP25fSgw278TmnLEuhbnyxp4tqLW8mlaJI1wR/VcQRpBRW0lgiF5Bl5bNolYqzrTQLBiRibNGYsQdUiRukY77KRhnDxpRiYRmrJfTQ6t3eXapty+IGkKwIvDZ7hd6lZi9c0hKa9PLcB1zvv6X1xwOIWV0oyPxWfkFMoT9+H2f4KchGRGgdftHMn8aFQVnmdg4MB12eXDIBzLJqs+4+MF5prWAZEN7VHt3gzQFWZQCmVQPuWohFAom5xgJcvmz//ILiCCEEJirop/cB0/OjDo3Cu1eH3eNl4mkgLq/GL0LBNaS5dpYxUbyLLzUbKEhw5Cayhh7B4MR3QHSzXeKMj6O707V5sqIxVgfdjDlkf/QkgkRKVRdNkeF6zq11z6T5KdTWmRNW3LuSuLy3LdkBi7AORobRPhs7CFcipuswdsnE7k8UwZ4R3MR7qhzOEJlAC2H1asbkgZd9er8GaHYG5xLLO40Y40jlv9uQxdCV6C7o9orZJIh8caWNareEe70Ji4USql96pXllqPOM4BF8Y6+ojfhau57t1sE/MedYczAINWkzfzgrGA/yVifudt4IzH856rM4iNkL8OkKkvfJe94AIvINe0fOoogXfuS/DTBd4KP+WDTfeb9oIwpQyfQGJhPEGoXHc3xV5JjE0dDIyHF+SgfmROK/rih7S81K/sbiBJlMY9zN4TvcbSA6siQrBZmf+Q/iSMzmlFVgeSkLAcosw9fxMZ0XIpL51FkS+526XqAXuMNCKNkv0mJJj0pwb3tiE5MR/xhKnT9/Ioo40KxhsXN8vGecz3FzrxbU5/6R1PPn8ici+Dc7YhxzyqKA/aZPOXur1Q7hH3T5PuXQVQKmQw9A7ya06LBvhlTZC6jjDZtrb6vs3Lhu 4n20f7Gw fJsVkDXxw9HpoqVw3wkcfypO+eKabnMioCp/QcmWEPnaltSTJbG0dykZoqCnYUOqyJvi+uG/lRt1zShTQt1hBDvG+3pvEbqyh2KyZLvNbX433G7a6g4fV0Oj9dqGhSG0ugaI2l+pD99zTpDsjNiyarH08a9qxFowwRjdIEEOBezPQ9Sk6IVSktpju8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 25, 2023 at 07:34:30PM +0800, Miaohe Lin wrote: > Remove unneeded PageLRU(p) and is_free_buddy_page(p) check as slab caches > are not shrunk now. This check can be added back when a lightweight range > based shrinker is available. I think your logic is faulty. Based on the reasoning above, this patch should be: > - if (!PageSlab(p)) { > - lru_add_drain_all(); > - if (PageLRU(p) || is_free_buddy_page(p)) > - return; > - } > + if (PageSlab(p)) > + return; > + > + lru_add_drain_all(); + if (PageLRU(p) || is_free_buddy_page(p)) + return; but maybe it's the description that is wrong.