From: Matthew Wilcox <willy@infradead.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memory-failure: remove unneeded page state check in shake_page()
Date: Sun, 25 Jun 2023 14:32:19 +0100 [thread overview]
Message-ID: <ZJhB45caQYmG+fwp@casper.infradead.org> (raw)
In-Reply-To: <20230625113430.2310385-1-linmiaohe@huawei.com>
On Sun, Jun 25, 2023 at 07:34:30PM +0800, Miaohe Lin wrote:
> Remove unneeded PageLRU(p) and is_free_buddy_page(p) check as slab caches
> are not shrunk now. This check can be added back when a lightweight range
> based shrinker is available.
I think your logic is faulty. Based on the reasoning above, this patch
should be:
> - if (!PageSlab(p)) {
> - lru_add_drain_all();
> - if (PageLRU(p) || is_free_buddy_page(p))
> - return;
> - }
> + if (PageSlab(p))
> + return;
> +
> + lru_add_drain_all();
+ if (PageLRU(p) || is_free_buddy_page(p))
+ return;
but maybe it's the description that is wrong.
next prev parent reply other threads:[~2023-06-25 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 11:34 Miaohe Lin
2023-06-25 13:32 ` Matthew Wilcox [this message]
2023-06-25 19:50 ` Matthew Wilcox
2023-06-26 1:40 ` Miaohe Lin
2023-06-26 0:52 ` Naoya Horiguchi
2023-06-26 1:43 ` Miaohe Lin
2023-06-28 0:04 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJhB45caQYmG+fwp@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox