From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3690BEB64DA for ; Sun, 25 Jun 2023 01:15:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45EDE8D0002; Sat, 24 Jun 2023 21:15:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40EA98D0001; Sat, 24 Jun 2023 21:15:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D6078D0002; Sat, 24 Jun 2023 21:15:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2001B8D0001 for ; Sat, 24 Jun 2023 21:15:19 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A41DD1204A3 for ; Sun, 25 Jun 2023 01:15:18 +0000 (UTC) X-FDA: 80939501916.13.3E27AEA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 91E24C0010 for ; Sun, 25 Jun 2023 01:15:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h53AEcOG; spf=pass (imf28.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687655716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KiamuhZaAd4YgPQ9PfX/2grjHw3MqsEpAzaxP15cekg=; b=3KFLXTi68T6zjE2ZxJRxF7ODcHtUp1CJmsGgatdItpv3GMAAc90WUhNro8e89vIkTkID9/ rgkyozbFMqgPQWK708BCmmUorAgEGYq21iOar20cUNyl1LY2bH5EG6YiUaMUXZPrgaJxYY noyrS2umOKDa0dEj1ghF95CZulKekhI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687655716; a=rsa-sha256; cv=none; b=4hO/G6CTkWuwehVjlIC4GHwo04wxiui6bSgjqDEo194YabT8vaQCq00o2ZTNPV7W4MWrKY m+fvKk4vE/ClIidJjsm5XpVjFT7bcsRdTSu6lRXtg38BanePzk+GMejlhhY30nl3JlTcKF C/GRv/DHgBxNHOwfadMlxmQkliC2imU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h53AEcOG; spf=pass (imf28.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687655715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KiamuhZaAd4YgPQ9PfX/2grjHw3MqsEpAzaxP15cekg=; b=h53AEcOG+ZLzBRqr3SDaCetUY9SORHC9SudG9EGVeIz/hZTrSP+msJ4IQ1KHcFpZbaXiQe tT8SvH2vAEo/JGm2j7wBdolXWfr7m6lTqL6P9LA6ZJDuiP1S54t7nFlXYmQdkE3oJ4pzbu hLgQ5Nz4QNo+Ck7CKcIaz3kY5BGl2fA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-553-6J9cT1aAMAOGf3KidcVA5Q-1; Sat, 24 Jun 2023 21:15:10 -0400 X-MC-Unique: 6J9cT1aAMAOGf3KidcVA5Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5AE398E44F9; Sun, 25 Jun 2023 01:15:09 +0000 (UTC) Received: from localhost (ovpn-12-72.pek2.redhat.com [10.72.12.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0978B200BA8B; Sun, 25 Jun 2023 01:15:08 +0000 (UTC) Date: Sun, 25 Jun 2023 09:15:05 +0800 From: Baoquan He To: Nathan Chancellor Cc: kernel test robot , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, hch@lst.de, christophe.leroy@csgroup.eu, rppt@kernel.org, willy@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, deller@gmx.de, glaubitz@physik.fu-berlin.de, Brian Cain , linux-hexagon@vger.kernel.org Subject: Re: [PATCH v7 02/19] hexagon: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230620131356.25440-3-bhe@redhat.com> <202306211030.DioMEPhl-lkp@intel.com> <20230621190834.GA842758@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621190834.GA842758@dev-arch.thelio-3990X> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Rspamd-Queue-Id: 91E24C0010 X-Rspam-User: X-Stat-Signature: ppa6bnfw3esene8zuk1suowfk1e6w8dk X-Rspamd-Server: rspam03 X-HE-Tag: 1687655716-815171 X-HE-Meta: U2FsdGVkX1/5/Kf/VPNgVNmjrLjHirOQJyTPnFdpIdnZY6qHC9vlO11GRc/l+hyJXoEDGXyDE4Hpf/iLWY9GvCzNwpMW5HvwUGmlgNP16n11MRmgTsfXDexj5ZDrqzD87sMPX7rCzgpDNpkmhBlJ8RzE6L3f8e39MyFFFI6KoIlu2StqBqW1qKxAmitZEVYReYcTKuqudO4UL3ZOYPmTivY6Sw3Dra/kpzPBa/pJe8llEU8gvBqDXfIoNVbi9eDr/uzzFq/XcDZ0D5oeLXcM10yfFidXEawqdYIdYxHKv3WZ13DQR2hIMNrC4Z+WEfHMs8qcKdQll10RR95V2yn+zaop6/a8aPTVkKaa9vW7bOyaouUeFvNXeOPDD2NOvRq+ps3UAf4ma+EkaxdD25HvXeeIurxRkyG/D+XqNTwCXQ7uFp2ploxT2fon+ITEK/mBtqFwDCr34yROFhg8XMmMkv6maWjXbk6h5UCIfeM61imR66Cpt9zakeirKWf2WjS0UCnsx1AtxqwLgeNn0ofIRR68piYIIDduJr9Q2Vnphn7oyEO0agJoTj8uedm09VP1UqXP0KhcAQnUiFTvDY/oUN9aO7FFS0RLyIMa3k1YRio/61LJGVWlfiut0hK6H6xiC+OCC0tXX465hx/NbNdRKQBXomkcoEody0YKaVu0v97eLu73uXNoyujrwRnFMX7qlKAlkGCz0/5MksGPUWbN4pMLPkC9KwD6Da3PZibGEoAsxczVwShvBXHHf+pkcBbmbYOzJgYeHCxmSj8MOzfEGNPsKvIDuqRh/lmCUVovwI3cOHz8bAmJU6ECbQ56NgxequrA7vjEuZ42JymGprvqoyHD7YfqbMAJHhT2111sYk52bk+gRJFoXkjRSCq+IZh77xWV4G1cPUtntyYuSts7LPQOSQP3ajqSODhI30THbeiHvXDPZS+0YfvoQ5wgjwaWiEUl5R3NW1MXRunTaZi 7geRuGHH 6UDijwB7M3FMu/+HSZ5jBNMr16VCxCWL9FfE15LtDU3YW1JzLC+DyMeLaKEwB9R3k200ZlB1+WjPd4CKEdBqYVKI8Q0zrJpt5oDCq19LIiqovdLDxp6YahXOyzy7x+FMqndstJnB0wJY+LZ9oqOaBps1N+ei902aM3GCdCFNUxSo+hxYFVmhxW6cGaNsySQAXYDBkvHkaemmH4Zwrc3LwDyu9huCX8mi/bw0MH1eHebrchBzynV2D0i55pTC+sfmEvcu09PxAQSZidQGBFBO5dqwpDQjG/x/5e0fRSXI3aUPp3iTe053i17bldUV+Qk7MuNHSiBdJsBj8zkUaiPdFXiT4PTctWXZZTmzlyn5gjvkYqgug2CDF6Mnx0XvisV0wkve30oDsNjFyJDabSRG+9FqPP0D2V7HLSIjMviR2J+mjD9QSh6Rziv/Bvw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/21/23 at 07:08pm, Nathan Chancellor wrote: > On Wed, Jun 21, 2023 at 04:50:53PM +0800, Baoquan He wrote: > > Hi, > > > > On 06/21/23 at 10:15am, kernel test robot wrote: > > > Hi Baoquan, > > > > > > kernel test robot noticed the following build errors: > > > > > > [auto build test ERROR on akpm-mm/mm-everything] > > > > > > url: https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/asm-generic-iomap-h-remove-ARCH_HAS_IOREMAP_xx-macros/20230620-212135 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > > patch link: https://lore.kernel.org/r/20230620131356.25440-3-bhe%40redhat.com > > > patch subject: [PATCH v7 02/19] hexagon: mm: Convert to GENERIC_IOREMAP > > > config: hexagon-randconfig-r041-20230620 (https://download.01.org/0day-ci/archive/20230621/202306211030.DioMEPhl-lkp@intel.com/config) > > > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) > > > reproduce: (https://download.01.org/0day-ci/archive/20230621/202306211030.DioMEPhl-lkp@intel.com/reproduce) > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202306211030.DioMEPhl-lkp@intel.com/ > > > > > > All errors (new ones prefixed by >>): > > > > > > >> arch/hexagon/kernel/hexagon_ksyms.o: error: local symbol ioremap was exported > > > > I followed steps in your reproduce link, didn't reproduce the error as > > above line reported. I can still see those PCI_IOMAP warning, however > > they will disappear when rebuilding. The clone3 warning can always ben > > seen. I didn't see the symbol ioremap error. Could you double check if > > anything missed in steps? > > > > [root@dell-pem620-01 linux]# COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash > > Compiler will be installed in /root/0day > > make --keep-going LLVM=1 CROSS_COMPILE=hexagon-linux- LLVM_IAS=1 --jobs=48 W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash > > make[1]: Entering directory '/root/linux/build_dir' > > GEN Makefile > > ld.lld: /lib64/libtinfo.so.6: no version information available (required by ld.lld) > > Hmmm, seems like a dynamic linking issue, likely because either libtinfo > is not available or the version on your system is older or newer than > the one that the compiler was built with. > > Intel folks, you can opt out of this particular library dependency with > '-DLLVM_ENABLE_TERMINFO=OFF' to cmake, which will make it easier for > others to use it; the compiler can still output color on most terminals > even without libtinfo. > > > tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files > > tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files > > tools/testing/selftests/arm64/tags/run_tags_test.sh: warning: ignored by one of the .gitignore files > > tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files > > tools/testing/selftests/kvm/.gitignore: warning: ignored by one of the .gitignore files > > tools/testing/selftests/kvm/Makefile: warning: ignored by one of the .gitignore files > > tools/testing/selftests/kvm/config: warning: ignored by one of the .gitignore files > > tools/testing/selftests/kvm/settings: warning: ignored by one of the .gitignore files > > CALL ../scripts/checksyscalls.sh > > clang: /lib64/libtinfo.so.6: no version information available (required by clang) > > :1519:2: warning: syscall clone3 not implemented [-W#warnings] > > 1519 | #warning syscall clone3 not implemented > > | ^ > > 1 warning generated. > > make[1]: Leaving directory '/root/linux/build_dir' > > [root@dell-pem620-01 linux]# > > > > > > I am able to reproduce this with the kernel.org LLVM builds that I do, > which should not have that library dependency: > > https://mirrors.edge.kernel.org/pub/tools/llvm/ > > $ curl -LSso .config https://download.01.org/0day-ci/archive/20230621/202306211030.DioMEPhl-lkp@intel.com/config > > $ make -skj"$(nproc)" ARCH=hexagon LLVM=$(realpath llvm-16.0.6-x86_64/bin)/ olddefconfig all > ... > make[5]: *** No rule to make target 'arch/hexagon/mm/ioremap.o', needed by 'arch/hexagon/mm/built-in.a'. > ... > arch/hexagon/kernel/hexagon_ksyms.o: error: local symbol ioremap was exported > ... > > The first issue is resolved with: > > diff --git a/arch/hexagon/mm/Makefile b/arch/hexagon/mm/Makefile > index 49911a906fd0..ba4b04d962d6 100644 > --- a/arch/hexagon/mm/Makefile > +++ b/arch/hexagon/mm/Makefile > @@ -3,5 +3,5 @@ > # Makefile for Hexagon memory management subsystem > # > > -obj-y := init.o ioremap.o uaccess.o vm_fault.o cache.o > +obj-y := init.o uaccess.o vm_fault.o cache.o > obj-y += copy_to_user.o copy_from_user.o vm_tlb.o Ah, right, arch/hexagon/mm/ioremap.c is removed, I forgot change that in Makefile. Thanks. > > For the second issue, it seems that ioremap is exported in > arch/hexagon/kernel/hexagon_ksyms.c but ioremap() is a static inline > function with CONFIG_GENERIC_IOREMAP. I think we can just remove the > ioremap and iounmap exports now, as ioremap() calls ioremap_prot(), > which is exported, and iounmap() is exported in mm/ioremap.c. > > diff --git a/arch/hexagon/kernel/hexagon_ksyms.c b/arch/hexagon/kernel/hexagon_ksyms.c > index ec56ce2d92a2..36a80e31d187 100644 > --- a/arch/hexagon/kernel/hexagon_ksyms.c > +++ b/arch/hexagon/kernel/hexagon_ksyms.c > @@ -14,12 +14,10 @@ > EXPORT_SYMBOL(__clear_user_hexagon); > EXPORT_SYMBOL(raw_copy_from_user); > EXPORT_SYMBOL(raw_copy_to_user); > -EXPORT_SYMBOL(iounmap); > EXPORT_SYMBOL(__vmgetie); > EXPORT_SYMBOL(__vmsetie); > EXPORT_SYMBOL(__vmyield); > EXPORT_SYMBOL(empty_zero_page); > -EXPORT_SYMBOL(ioremap); > EXPORT_SYMBOL(memcpy); > EXPORT_SYMBOL(memset); > > > With those two diffs, the randconfig the robot provides builds and links > without any errors. Thanks a lot, I will add this into patch 02/19 of v8 post.