From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2161EB64D7 for ; Fri, 23 Jun 2023 21:49:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C450C8D0002; Fri, 23 Jun 2023 17:49:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCD808D0001; Fri, 23 Jun 2023 17:49:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6E358D0002; Fri, 23 Jun 2023 17:49:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 950438D0001 for ; Fri, 23 Jun 2023 17:49:43 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 50566160352 for ; Fri, 23 Jun 2023 21:49:43 +0000 (UTC) X-FDA: 80935355046.01.BEC1462 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 1AD0F40010 for ; Fri, 23 Jun 2023 21:49:39 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=l4LxiaK6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of cel@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cel@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687556980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DWOIzaK4a3YapH9hOAXt6eyQLioooSQ0H9VdnVN39z4=; b=dinnsCglxtLwkS3QJ9/V/jC9yMMVcZhQGf9ZcxiCSXHEyIXzdoKlCEsikGcSVrTKPPHwo0 p0IPOLSHKiout/kmkCkutfKoKPUvOqQpUKVkkNVO00O7WHiogKzOZXzw51U+RC5hf6kEeZ ZDiQTlbfRFYQbXp+GPHnXu2fEAXNeLA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=l4LxiaK6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of cel@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cel@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687556980; a=rsa-sha256; cv=none; b=egpwKlKOp1srbE6Fzj22nK7hY1INt4Q/Bmh7MQhf0FpI4OGbwEYhWK8jPbCL9FaE0Me4LL UO5M9AQoNygx+FREMICxvfP1heVNGm8s3t8WrtHmstpwsCyQB3Oi7MCPB77gwCW3WpdXD8 ECqgA5rV9yM0TgIg/KIyussav9jlv7s= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC17D60F93; Fri, 23 Jun 2023 21:49:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1671C433C8; Fri, 23 Jun 2023 21:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687556978; bh=bPOn8vNljb4Kts16IvF12pTxf9JAyk3Q+pkgmofKYTI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l4LxiaK6FHJV+LaN+k19qJLvpsW7q6peMpRqQDAloqrBAb7yaQiFzdxyJRQOlUbhL XBecHa58jNv7ky9A034GYSD2hm6ptEDQNutUwI9YecVIS3WmPXE3L9OmXsZUz8kwS8 TTwQFFfOfOtb8MAgVm196q6ZTVuewtnjos3fSTZ9GEVB31g3k5MJS42AVjc5SzUh/V FyhyE7GMMMzgjXlbaXwq0dZEfCVwkgehGZA7UY2GwQKM2vvvfQX8LDHnVUTOmbhZdZ 3Ac0f71z1GBnxhPGwb/beOuZzWJU5QKmGVyY8UMScHTrLfTWh6qN+V7ajaXz+LKLHt /jQ/IQ+1PydAw== Date: Fri, 23 Jun 2023 17:49:34 -0400 From: Chuck Lever To: Qi Zheng Cc: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, linux-bcache@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-raid@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 15/29] NFSD: dynamically allocate the nfsd-client shrinker Message-ID: References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> <20230622085335.77010-16-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230622085335.77010-16-zhengqi.arch@bytedance.com> X-Rspamd-Queue-Id: 1AD0F40010 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7oie4qohu9zk7nn75hxynsb3sgnhjqmd X-HE-Tag: 1687556979-305359 X-HE-Meta: U2FsdGVkX18N34Ez/jjzO3NUMoXaosezFnJ/mjG0vBjQf1bPvIVSbTTfuQZBT5/dDQ9EmMCZvpbt8CaItnhLodhBd3kcNDUx9kFdmd1GNBmeBZATsxDoe7oXynF/laX4/jV3ndx0309H95uv+haVJys+KpsPAYYHiO8IUS6qmDJ4Y2wqyZETq7zYCEziiyqqAzRXcAkJ+rWPJ+Ynzc8oGmxv2n8oViUJjpAGcFHBY/cVuQdLlbNCN3ysLXfTdOvtwqjYfGZBov0RLxgm/lYlRq4O4+vbGwBUgacS37T5r6hcEw1l5K9zKod6ocxTGF+SxKoXsc1enyY80qgAYfl3VwV7fYXqQdYPv/dk4l03NkqvxcLgef6nq3bDS3b6KZJ4SF/Fw7+EpmehNmvaxl7Els0fPp64NI5fcLq8q3vdq0prAwgQ4aQxU4u6r7K9spWjpTJNhsYXW8LCDJLrWz50k2JIMPaa8Ls7fzU2ldac2Uk8QeuCTTXYlfbSRmmEWmg+sEGGLJjyD6y0CRFxNYI64RecqQ+/gTL4Gv6NGBp9DFjwN8s9zUjK6kgwqzvB2oFuHJ7gPFK9XRlFPoBQeg2QpxjrA31aooIZx/dFq3kPIGAJugPnBS7Ud3JlEfl1hkZrwhnRUzn85JaQEc23BqRjkz04MGHF5XtwU/LJo6i6jcTiZnWhhBa5HgIZ+uLRZgeQlm2vadsKUKlqC50mOkumKJESnotTCFXJ7BS26v1RPpno0OrlSoYcb0iE0N+HaE+mC1Uvx233lraFlTtZ/I6zE0zXxpfyW1SJt/2uhdGfdzL1Uv5su55uIKrsboajKlI6Hvg3nmejTjZahLGU06Mhf+c1GJi18gqDbvjAjW3LczZ7sZrH+WUS7ndGEvy//pbamaD6jdlbTbeFSGR6i8Z3kfzYm1R9KeTY8QdMicDXcjRmD0vfRi7CI0xdBgnJGQVTmskZIi63RW+sE/nucUy Xue1WdVA tlW4qMDoS2a3t5Szj7GTABFkjEVbGSMD+5F0aGQ/YjFGXAnFQmB43YAlxRKnxfU04iPtDIcQjmqjXZeRXqUun+BRhI5LqLg3fVlPNPrNwBON6mkyZ88XUZRHzgp8k77pm9AnkbXESti/BO1XuedTb4evLTY+vnnmB20wLUrBFe9BDu34zB6xTbCKXk91AbZclTlFOps5etuseOpaX+6mZeLWZtLkOuZIuujZfLYrht6kgksBt51fMLTyih5RuhPLpcZvU0QYD/sE1kz3DWO2UrxITfKpXrQcWWa8LC9Du34Ou15Ykk7wKsr+NYyDOyGe43aitqabduafEJzI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 22, 2023 at 04:53:21PM +0800, Qi Zheng wrote: > In preparation for implementing lockless slab shrink, > we need to dynamically allocate the nfsd-client shrinker, > so that it can be freed asynchronously using kfree_rcu(). > Then it doesn't need to wait for RCU read-side critical > section when releasing the struct nfsd_net. > > Signed-off-by: Qi Zheng For 15/29 and 16/29 of this series: Acked-by: Chuck Lever > --- > fs/nfsd/netns.h | 2 +- > fs/nfsd/nfs4state.c | 20 ++++++++++++-------- > 2 files changed, 13 insertions(+), 9 deletions(-) > > diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h > index ec49b200b797..f669444d5336 100644 > --- a/fs/nfsd/netns.h > +++ b/fs/nfsd/netns.h > @@ -195,7 +195,7 @@ struct nfsd_net { > int nfs4_max_clients; > > atomic_t nfsd_courtesy_clients; > - struct shrinker nfsd_client_shrinker; > + struct shrinker *nfsd_client_shrinker; > struct work_struct nfsd_shrinker_work; > }; > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index 6e61fa3acaf1..a06184270548 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -4388,8 +4388,7 @@ static unsigned long > nfsd4_state_shrinker_count(struct shrinker *shrink, struct shrink_control *sc) > { > int count; > - struct nfsd_net *nn = container_of(shrink, > - struct nfsd_net, nfsd_client_shrinker); > + struct nfsd_net *nn = shrink->private_data; > > count = atomic_read(&nn->nfsd_courtesy_clients); > if (!count) > @@ -8094,14 +8093,19 @@ static int nfs4_state_create_net(struct net *net) > INIT_WORK(&nn->nfsd_shrinker_work, nfsd4_state_shrinker_worker); > get_net(net); > > - nn->nfsd_client_shrinker.scan_objects = nfsd4_state_shrinker_scan; > - nn->nfsd_client_shrinker.count_objects = nfsd4_state_shrinker_count; > - nn->nfsd_client_shrinker.seeks = DEFAULT_SEEKS; > - > - if (register_shrinker(&nn->nfsd_client_shrinker, "nfsd-client")) > + nn->nfsd_client_shrinker = shrinker_alloc_and_init(nfsd4_state_shrinker_count, > + nfsd4_state_shrinker_scan, > + 0, DEFAULT_SEEKS, 0, > + nn); > + if (!nn->nfsd_client_shrinker) > goto err_shrinker; > + > + if (register_shrinker(nn->nfsd_client_shrinker, "nfsd-client")) > + goto err_register; > return 0; > > +err_register: > + shrinker_free(nn->nfsd_client_shrinker); > err_shrinker: > put_net(net); > kfree(nn->sessionid_hashtbl); > @@ -8197,7 +8201,7 @@ nfs4_state_shutdown_net(struct net *net) > struct list_head *pos, *next, reaplist; > struct nfsd_net *nn = net_generic(net, nfsd_net_id); > > - unregister_shrinker(&nn->nfsd_client_shrinker); > + unregister_and_free_shrinker(nn->nfsd_client_shrinker); > cancel_work(&nn->nfsd_shrinker_work); > cancel_delayed_work_sync(&nn->laundromat_work); > locks_end_grace(&nn->nfsd4_manager); > -- > 2.30.2 >